FixedQuotation::quoteHtml() - Code Metrics - Inspection of "create reply message" - genkgo/mail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#50)

by Frederik

created 2018-03-11 13:13 UTC

FixedQuotation::quoteHtml() B

↳ Parent: FixedQuotation

Complexity

Conditions	7
Paths	10

Size

Total Lines	55
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	30
CRAP Score	7.2269

Importance

Changes

Metric	Value
dl	0
loc	55
ccs	30
cts	36
cp	0.8333
rs	7.8235
c	0
b	0
f	0
cc	7
eloc	37
nc	10
nop	3
crap	7.2269

How to fix Long Method

<?php
declare(strict_types=1);

namespace Genkgo\Mail\Quote;

use Genkgo\Mail\Address;
use Genkgo\Mail\AlternativeText;
use Genkgo\Mail\MessageBodyCollection;
use Genkgo\Mail\MessageInterface;
use Genkgo\Mail\QuotationInterface;

final class FixedQuotation implements QuotationInterface
{
    /**
     * @var string
     */
    private $headerText;

    /**
     * @param string $headerText
     */
    public function __construct(string $headerText = '%s (%s):')
    {
        $this->headerText = $headerText;
    }

    /**
     * @param MessageBodyCollection $body
     * @param MessageInterface $originalMessage
     * @return MessageBodyCollection
     * @throws \DOMException
     */
    public function quote(MessageBodyCollection $body, MessageInterface $originalMessage): MessageBodyCollection
    {
        $originalBody = MessageBodyCollection::extract($originalMessage);
        $dateString = 'unknown';
        foreach ($originalMessage->getHeader('Date') as $header) {
            try {
                $date = new \DateTimeImmutable($header->getValue()->getRaw());
                $dateString = \IntlDateFormatter::create(
                    \Locale::getDefault(),
                    \IntlDateFormatter::MEDIUM,
                    \IntlDateFormatter::MEDIUM
                )->format($date);
            } catch (\Exception $e) {

            }
        }

        $fromString = '';
        foreach ($originalMessage->getHeader('From') as $header) {
            $from = Address::fromString($header->getValue()->getRaw());
            $fromString = $from->getName() ? $from->getName() : (string)$from->getAddress();
        }

        $headerText = \sprintf($this->headerText, $fromString, $dateString);

        return $body
            ->withHtmlAndNoGeneratedAlternativeText(
                $this->quoteHtml(
                    $body->getHtml(),
                    $originalBody->getHtml(),
                    $headerText
                )
            )
            ->withAlternativeText($this->quoteText($body->getText(), $originalBody->getText()));
    }

    /**
     * @param string $newHtml
     * @param string $originalHtml
     * @param string $headerText
     * @return string
     * @throws \DOMException
     */
    private function quoteHtml(string $newHtml, string $originalHtml, string $headerText): string
    {
        $originalHtml = \trim($originalHtml);
        if ($originalHtml === '') {
            return '';
        }

        $document = new \DOMDocument();
        $document->substituteEntities = false;
        $document->resolveExternals = false;

        $result = @$document->loadHTML($originalHtml);
        if ($result === false) {
            throw new \DOMException('Incorrect HTML');
        }

        $query = new \DOMXPath($document);
        $removeItems = $query->query('//head|//script|//body/@style|//html/@style', $document->documentElement);
        /** @var \DOMElement $removeItem */
        foreach ($removeItems as $removeItem) {
            $parent = $removeItem->parentNode;
            $parent->removeChild($removeItem);
        }

        $body = $document->getElementsByTagName('body');
        $quote = $document->createElement('blockquote');
        $quote->setAttribute('type', 'cite');

        if ($body->length === 0) {
            $quote->appendChild($document->removeChild($document->documentElement));
        } else {
            $root = $body->item(0);
            while ($root->childNodes->length !== 0) {
                $quote->appendChild($root->childNodes->item(0));
            }
        }

        $newDocument = new \DOMDocument();
        $newDocument->substituteEntities = false;
        $newDocument->resolveExternals = false;
        $result = @$newDocument->loadHTML($newHtml, LIBXML_HTML_NOIMPLIED | LIBXML_HTML_NODEFDTD);
        if ($result === false) {
            throw new \DOMException('Incorrect HTML');
        }

        $quotedNode = $newDocument->importNode($quote, true);
        $newBody = $this->prepareBody($newDocument);
        $newBody->appendChild($quotedNode);

        $header = $newDocument->createElement('p');
        $header->textContent = $headerText;

        $quotedNode->parentNode->insertBefore($header, $quotedNode);
        return \trim($newDocument->saveHTML());
    }

    /**
     * @param \DOMDocument $document
     * @return \DOMElement
     */
    private function prepareBody(\DOMDocument $document): \DOMElement
    {
        $bodyList = $document->getElementsByTagName('body');
        if ($bodyList->length === 0) {
            $html = $document->createElement('html');
            $body = $document->createElement('body');
            $html->appendChild($body);
            $body->appendChild($document->documentElement);
            $document->removeChild($document->documentElement);
            $document->appendChild($html);
            return $body;
        }

        $body = $bodyList->item(0);

        $queryHtml = new \DOMXPath($document);
        $htmlTags = $queryHtml->query('//html');
        if ($htmlTags->length > 0) {
            $html = $htmlTags->item(0);
            $html->appendChild($body);
            $document->removeChild($document->documentElement);
            $document->appendChild($html);
            return $body;
        }

        $html = $document->createElement('html');
        $html->appendChild($body);
        $document->removeChild($document->documentElement);
        $document->appendChild($html);
        return $body;
    }

    /**
     * @param AlternativeText $newText
     * @param AlternativeText $originalText
     * @return AlternativeText
     */
    private function quoteText(AlternativeText $newText, AlternativeText $originalText): AlternativeText

    {
        return $originalText;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Genkgo\Mail\Quote;
5
6		use Genkgo\Mail\Address;
7		use Genkgo\Mail\AlternativeText;
8		use Genkgo\Mail\MessageBodyCollection;
9		use Genkgo\Mail\MessageInterface;
10		use Genkgo\Mail\QuotationInterface;
11
12		final class FixedQuotation implements QuotationInterface
13		{
14		/**
15		* @var string
16		*/
17		private $headerText;
18
19		/**
20		* @param string $headerText
21		*/
22	8	public function __construct(string $headerText = '%s (%s):')
23		{
24	8	$this->headerText = $headerText;
25	8	}
26
27		/**
28		* @param MessageBodyCollection $body
29		* @param MessageInterface $originalMessage
30		* @return MessageBodyCollection
31		* @throws \DOMException
32		*/
33	8	public function quote(MessageBodyCollection $body, MessageInterface $originalMessage): MessageBodyCollection
34		{
35	8	$originalBody = MessageBodyCollection::extract($originalMessage);
36	8	$dateString = 'unknown';
37	8	foreach ($originalMessage->getHeader('Date') as $header) {
38		try {
39	1	$date = new \DateTimeImmutable($header->getValue()->getRaw());
40	1	$dateString = \IntlDateFormatter::create(
41	1	\Locale::getDefault(),
42	1	\IntlDateFormatter::MEDIUM,
43	1	\IntlDateFormatter::MEDIUM
44	1	)->format($date);
45	1	} catch (\Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-03-09 17:15 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
46		}
47		}
48
49	8	$fromString = '';
50	8	foreach ($originalMessage->getHeader('From') as $header) {
51	8	$from = Address::fromString($header->getValue()->getRaw());
52	8	$fromString = $from->getName() ? $from->getName() : (string)$from->getAddress();
53		}
54
55	8	$headerText = \sprintf($this->headerText, $fromString, $dateString);
56
57		return $body
58	8	->withHtmlAndNoGeneratedAlternativeText(
59	8	$this->quoteHtml(
60	8	$body->getHtml(),
61	8	$originalBody->getHtml(),
62	8	$headerText
63		)
64		)
65	8	->withAlternativeText($this->quoteText($body->getText(), $originalBody->getText()));
66		}
67
68		/**
69		* @param string $newHtml
70		* @param string $originalHtml
71		* @param string $headerText
72		* @return string
73		* @throws \DOMException
74		*/
75	8	private function quoteHtml(string $newHtml, string $originalHtml, string $headerText): string
76		{
77	8	$originalHtml = \trim($originalHtml);
78	8	if ($originalHtml === '') {
79		return '';
80		}
81
82	8	$document = new \DOMDocument();
83	8	$document->substituteEntities = false;
84	8	$document->resolveExternals = false;
85
86	8	$result = @$document->loadHTML($originalHtml);
87	8	if ($result === false) {
88		throw new \DOMException('Incorrect HTML');
89		}
90
91	8	$query = new \DOMXPath($document);
92	8	$removeItems = $query->query('//head\|//script\|//body/@style\|//html/@style', $document->documentElement);
93		/** @var \DOMElement $removeItem */
94	8	foreach ($removeItems as $removeItem) {
95		$parent = $removeItem->parentNode;
96		$parent->removeChild($removeItem);
97		}
98
99	8	$body = $document->getElementsByTagName('body');
100	8	$quote = $document->createElement('blockquote');
101	8	$quote->setAttribute('type', 'cite');
102
103	8	if ($body->length === 0) {
104		$quote->appendChild($document->removeChild($document->documentElement));
105		} else {
106	8	$root = $body->item(0);
107	8	while ($root->childNodes->length !== 0) {
108	8	$quote->appendChild($root->childNodes->item(0));
109		}
110		}
111
112	8	$newDocument = new \DOMDocument();
113	8	$newDocument->substituteEntities = false;
114	8	$newDocument->resolveExternals = false;
115	8	$result = @$newDocument->loadHTML($newHtml, LIBXML_HTML_NOIMPLIED \| LIBXML_HTML_NODEFDTD);
116	8	if ($result === false) {
117		throw new \DOMException('Incorrect HTML');
118		}
119
120	8	$quotedNode = $newDocument->importNode($quote, true);
121	8	$newBody = $this->prepareBody($newDocument);
122	8	$newBody->appendChild($quotedNode);
123
124	8	$header = $newDocument->createElement('p');
125	8	$header->textContent = $headerText;
126
127	8	$quotedNode->parentNode->insertBefore($header, $quotedNode);
128	8	return \trim($newDocument->saveHTML());
129		}
130
131		/**
132		* @param \DOMDocument $document
133		* @return \DOMElement
134		*/
135	8	private function prepareBody(\DOMDocument $document): \DOMElement
136		{
137	8	$bodyList = $document->getElementsByTagName('body');
138	8	if ($bodyList->length === 0) {
139		$html = $document->createElement('html');
140		$body = $document->createElement('body');
141		$html->appendChild($body);
142		$body->appendChild($document->documentElement);
143		$document->removeChild($document->documentElement);
144		$document->appendChild($html);
145		return $body;
146		}
147
148	8	$body = $bodyList->item(0);
149
150	8	$queryHtml = new \DOMXPath($document);
151	8	$htmlTags = $queryHtml->query('//html');
152	8	if ($htmlTags->length > 0) {
153	8	$html = $htmlTags->item(0);
154	8	$html->appendChild($body);
155	8	$document->removeChild($document->documentElement);
156	8	$document->appendChild($html);
157	8	return $body;
158		}
159
160		$html = $document->createElement('html');
161		$html->appendChild($body);
162		$document->removeChild($document->documentElement);
163		$document->appendChild($html);
164		return $body;
165		}
166
167		/**
168		* @param AlternativeText $newText
169		* @param AlternativeText $originalText
170		* @return AlternativeText
171		*/
172	8	private function quoteText(AlternativeText $newText, AlternativeText $originalText): AlternativeText
		0 ignored issues – show Unused Code introduced 2018-03-09 17:15 UTC by Report Bug Copy Issue Report The parameter `$newText` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
173		{
174	8	return $originalText;
175		}
176		}
177

genkgo / mail

Pull Request — master (#50)

FixedQuotation::quoteHtml() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like