EntryTest::testItAddsTransactionDetailsIfThereArePresentInXml() - Code Metrics - Inspection of "Add organisation id for related parties and add pr..." - genkgo/camt - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#141)

unknown

created 2023-03-07 13:31 UTC

EntryTest::testItAddsTransactionDetailsIfThereArePresentInXml() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	99
Code Lines	73

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	73
nc	1
nop	0
dl	0
loc	99
rs	8.589
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace Genkgo\TestCamt\Unit\Decoder;

use Genkgo\Camt\Decoder;
use Genkgo\Camt\Decoder\Entry;
use Genkgo\Camt\DTO;
use PHPUnit\Framework;
use SimpleXMLElement;

class EntryTest extends Framework\TestCase
{
    /**
     * @var Decoder\EntryTransactionDetail&Framework\MockObject\MockObject
     */
    private $mockedEntryTransactionDetailDecoder;

    private Entry $decoder;

    protected function setUp(): void
    {
        $this->mockedEntryTransactionDetailDecoder = $this->createMock(Decoder\EntryTransactionDetail::class);
        $this->decoder = new Entry($this->mockedEntryTransactionDetailDecoder);
    }

    public function testItDoesNotAddTransactionDetailsIfThereIsNoneInXml(): void
    {
        $entry = $this->createMock(DTO\Entry::class);

        $entry
            ->expects(self::never())
            ->method('addTransactionDetail')
            ->with(self::anything());

        $xmlEntry = new SimpleXMLElement('<content></content>');
        $this->decoder->addTransactionDetails($entry, $xmlEntry);
    }

    public function testItAddsTransactionDetailsIfThereArePresentInXml(): void
    {
        $entry = $this->createMock(DTO\Entry::class);

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addReference')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class)
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addRelatedParties')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addRelatedAgents')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addRemittanceInformation')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addRelatedDates')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addReturnInformation')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addAdditionalTransactionInformation')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addBankTransactionCode')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addCharges')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addAmountDetails')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $this->mockedEntryTransactionDetailDecoder
            ->expects(self::once())
            ->method('addAmount')
            ->with(
                self::isInstanceOf(DTO\EntryTransactionDetail::class),
                self::isInstanceOf(SimpleXMLElement::class),
                self::isInstanceOf(SimpleXMLElement::class),
            );

        $entry
            ->expects(self::once())
            ->method('addTransactionDetail')
            ->with(self::isInstanceOf(DTO\EntryTransactionDetail::class));

        $this->decoder->addTransactionDetails($entry, $this->getXmlEntry());
    }

    private function getXmlEntry(): SimpleXMLElement
    {
        $xmlContent = <<<XML
<content>
    <NtryDtls>
        <TxDtls>
            <EndToEndId>000000001</EndToEndId>
        </TxDtls>
    </NtryDtls>
</content>
XML;

        return new SimpleXMLElement($xmlContent);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Genkgo\TestCamt\Unit\Decoder;
6
7			use Genkgo\Camt\Decoder;
8			use Genkgo\Camt\Decoder\Entry;
9			use Genkgo\Camt\DTO;
10			use PHPUnit\Framework;
11			use SimpleXMLElement;
12
13			class EntryTest extends Framework\TestCase
14			{
15			/**
16			* @var Decoder\EntryTransactionDetail&Framework\MockObject\MockObject
17			*/
18			private $mockedEntryTransactionDetailDecoder;
19
20			private Entry $decoder;
21
22			protected function setUp(): void
23			{
24			$this->mockedEntryTransactionDetailDecoder = $this->createMock(Decoder\EntryTransactionDetail::class);
25			$this->decoder = new Entry($this->mockedEntryTransactionDetailDecoder);
26			}
27
28			public function testItDoesNotAddTransactionDetailsIfThereIsNoneInXml(): void
29			{
30			$entry = $this->createMock(DTO\Entry::class);
31
32			$entry
33			->expects(self::never())
34			->method('addTransactionDetail')
35			->with(self::anything());
36
37			$xmlEntry = new SimpleXMLElement('<content></content>');
38			$this->decoder->addTransactionDetails($entry, $xmlEntry);
39			}
40
41			public function testItAddsTransactionDetailsIfThereArePresentInXml(): void
42			{
43			$entry = $this->createMock(DTO\Entry::class);
44
45			$this->mockedEntryTransactionDetailDecoder
46			->expects(self::once())
47			->method('addReference')
48			->with(
49			self::isInstanceOf(DTO\EntryTransactionDetail::class),
50			self::isInstanceOf(SimpleXMLElement::class)
51			);
52
53			$this->mockedEntryTransactionDetailDecoder
54			->expects(self::once())
55			->method('addRelatedParties')
56			->with(
57			self::isInstanceOf(DTO\EntryTransactionDetail::class),
58			self::isInstanceOf(SimpleXMLElement::class),
59			);
60
61			$this->mockedEntryTransactionDetailDecoder
62			->expects(self::once())
63			->method('addRelatedAgents')
64			->with(
65			self::isInstanceOf(DTO\EntryTransactionDetail::class),
66			self::isInstanceOf(SimpleXMLElement::class),
67			);
68
69			$this->mockedEntryTransactionDetailDecoder
70			->expects(self::once())
71			->method('addRemittanceInformation')
72			->with(
73			self::isInstanceOf(DTO\EntryTransactionDetail::class),
74			self::isInstanceOf(SimpleXMLElement::class),
75			);
76
77			$this->mockedEntryTransactionDetailDecoder
78			->expects(self::once())
79			->method('addRelatedDates')
80			->with(
81			self::isInstanceOf(DTO\EntryTransactionDetail::class),
82			self::isInstanceOf(SimpleXMLElement::class),
83			);
84
85			$this->mockedEntryTransactionDetailDecoder
86			->expects(self::once())
87			->method('addReturnInformation')
88			->with(
89			self::isInstanceOf(DTO\EntryTransactionDetail::class),
90			self::isInstanceOf(SimpleXMLElement::class),
91			);
92
93			$this->mockedEntryTransactionDetailDecoder
94			->expects(self::once())
95			->method('addAdditionalTransactionInformation')
96			->with(
97			self::isInstanceOf(DTO\EntryTransactionDetail::class),
98			self::isInstanceOf(SimpleXMLElement::class),
99			);
100
101			$this->mockedEntryTransactionDetailDecoder
102			->expects(self::once())
103			->method('addBankTransactionCode')
104			->with(
105			self::isInstanceOf(DTO\EntryTransactionDetail::class),
106			self::isInstanceOf(SimpleXMLElement::class),
107			);
108
109			$this->mockedEntryTransactionDetailDecoder
110			->expects(self::once())
111			->method('addCharges')
112			->with(
113			self::isInstanceOf(DTO\EntryTransactionDetail::class),
114			self::isInstanceOf(SimpleXMLElement::class),
115			);
116
117			$this->mockedEntryTransactionDetailDecoder
118			->expects(self::once())
119			->method('addAmountDetails')
120			->with(
121			self::isInstanceOf(DTO\EntryTransactionDetail::class),
122			self::isInstanceOf(SimpleXMLElement::class),
123			);
124
125			$this->mockedEntryTransactionDetailDecoder
126			->expects(self::once())
127			->method('addAmount')
128			->with(
129			self::isInstanceOf(DTO\EntryTransactionDetail::class),
130			self::isInstanceOf(SimpleXMLElement::class),
131			self::isInstanceOf(SimpleXMLElement::class),
132			);
133
134			$entry
135			->expects(self::once())
136			->method('addTransactionDetail')
137			->with(self::isInstanceOf(DTO\EntryTransactionDetail::class));
138
139			$this->decoder->addTransactionDetails($entry, $this->getXmlEntry());
140			}
141
142			private function getXmlEntry(): SimpleXMLElement
143			{
144			$xmlContent = <<<XML
145			<content>
146			<NtryDtls>
147			<TxDtls>
148			<EndToEndId>000000001</EndToEndId>
149			</TxDtls>
150			</NtryDtls>
151			</content>
152			XML;
153
154			return new SimpleXMLElement($xmlContent);
155			}
156			}
157

genkgo / camt

Pull Request — master (#141)

EntryTest::testItAddsTransactionDetailsIfThereArePresentInXml() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like