EntryTransactionDetail::addRemittanceInformation() - Code Metrics - Inspection of "Add camt052 v2 support" - genkgo/camt - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Yann

created 2016-06-15 12:24 UTC

EntryTransactionDetail::addRemittanceInformation() B

↳ Parent: Project

Complexity

Conditions	6
Paths	4

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	6

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	27
ccs	21
cts	21
cp	1
rs	8.439
cc	6
eloc	16
nc	4
nop	2
crap	6

<?php

namespace Genkgo\Camt\Camt053\Decoder;

use Genkgo\Camt\DTO;
use Genkgo\Camt\Decoder\EntryTransactionDetail as BaseDecoder;
use \SimpleXMLElement;
use Genkgo\Camt\Iban;

class EntryTransactionDetail extends BaseDecoder
{
    /**
     * {@inheritdoc}
     */
    public function getRelatedPartyAccount(SimpleXMLElement $xmlRelatedPartyTypeAccount)
    {
        if (false === isset($xmlRelatedPartyTypeAccount->Id)) {
            return;
        }

        if (isset($xmlRelatedPartyTypeAccount->Id->IBAN) && $ibanCode = (string) $xmlRelatedPartyTypeAccount->Id->IBAN) {
            return new DTO\IbanAccount(new Iban($ibanCode));
        }

        if (false === isset($xmlRelatedPartyTypeAccount->Id->Othr)) {
            return;
        }

        $xmlOtherIdentification = $xmlRelatedPartyTypeAccount->Id->Othr;
        $otherAccount = new DTO\OtherAccount((string) $xmlOtherIdentification->Id);

        if (isset($xmlOtherIdentification->SchmeNm)) {
            if (isset($xmlOtherIdentification->SchmeNm->Cd)) {
                $otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Cd);
            }

            if (isset($xmlOtherIdentification->SchmeNm->Prtry)) {
                $otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Prtry);
            }
        }

        if (isset($xmlOtherIdentification->Issr)) {
            $otherAccount->setIssuer((string) $xmlOtherIdentification->Issr);
        }

        return $otherAccount;
    }
}


1		<?php
2
3		namespace Genkgo\Camt\Camt053\Decoder;
4
5		use Genkgo\Camt\DTO;
6		use Genkgo\Camt\Decoder\EntryTransactionDetail as BaseDecoder;
7		use \SimpleXMLElement;
8		use Genkgo\Camt\Iban;
9
10		class EntryTransactionDetail extends BaseDecoder
11		{
12		/**
13		* {@inheritdoc}
14		*/
15	11	public function getRelatedPartyAccount(SimpleXMLElement $xmlRelatedPartyTypeAccount)
16		{
17	11	if (false === isset($xmlRelatedPartyTypeAccount->Id)) {
18		return;
19		}
20
21	11	if (isset($xmlRelatedPartyTypeAccount->Id->IBAN) && $ibanCode = (string) $xmlRelatedPartyTypeAccount->Id->IBAN) {
22	10	return new DTO\IbanAccount(new Iban($ibanCode));
23		}
24
25	6	if (false === isset($xmlRelatedPartyTypeAccount->Id->Othr)) {
26		return;
27		}
28
29	6	$xmlOtherIdentification = $xmlRelatedPartyTypeAccount->Id->Othr;
30	6	$otherAccount = new DTO\OtherAccount((string) $xmlOtherIdentification->Id);
31
32	6	if (isset($xmlOtherIdentification->SchmeNm)) {
33		if (isset($xmlOtherIdentification->SchmeNm->Cd)) {
34		$otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Cd);
35		}
36
37		if (isset($xmlOtherIdentification->SchmeNm->Prtry)) {
38		$otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Prtry);
39		}
40		}
41
42	6	if (isset($xmlOtherIdentification->Issr)) {
43	6	$otherAccount->setIssuer((string) $xmlOtherIdentification->Issr);
44	6	}
45
46	6	return $otherAccount;
47		}
48		}
49

genkgo / camt

Pull Request — master (#21)

EntryTransactionDetail::addRemittanceInformation() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like