genkgo /
camt
| Conditions | 10 |
| Paths | 14 |
| Total Lines | 35 |
| Code Lines | 18 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 6 |
| CRAP Score | 42.0294 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | 11 | public function getRelatedPartyAccount(SimpleXMLElement $xmlRelatedPartyTypeAccount = null) |
|
| 16 | { |
||
| 17 | 11 | if($xmlRelatedPartyTypeAccount){ |
|
| 18 | 11 | if (false === isset($xmlRelatedPartyTypeAccount->Id)) { |
|
| 19 | return; |
||
| 20 | } |
||
| 21 | |||
| 22 | 11 | if (isset($xmlRelatedPartyTypeAccount->Id->IBAN) && $ibanCode = (string) $xmlRelatedPartyTypeAccount->Id->IBAN) { |
|
| 23 | 11 | return new DTO\IbanAccount(new Iban($ibanCode)); |
|
| 24 | } |
||
| 25 | |||
| 26 | if (false === isset($xmlRelatedPartyTypeAccount->Id->Othr)) { |
||
| 27 | return; |
||
| 28 | } |
||
| 29 | |||
| 30 | $xmlOtherIdentification = $xmlRelatedPartyTypeAccount->Id->Othr; |
||
| 31 | $otherAccount = new DTO\OtherAccount((string) $xmlOtherIdentification->Id); |
||
| 32 | |||
| 33 | if (isset($xmlOtherIdentification->SchmeNm)) { |
||
| 34 | if (isset($xmlOtherIdentification->SchmeNm->Cd)) { |
||
| 35 | $otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Cd); |
||
| 36 | } |
||
| 37 | |||
| 38 | if (isset($xmlOtherIdentification->SchmeNm->Prtry)) { |
||
| 39 | $otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Prtry); |
||
| 40 | } |
||
| 41 | } |
||
| 42 | |||
| 43 | if (isset($xmlOtherIdentification->Issr)) { |
||
| 44 | $otherAccount->setIssuer((string) $xmlOtherIdentification->Issr); |
||
| 45 | } |
||
| 46 | |||
| 47 | return $otherAccount; |
||
| 48 | } |
||
| 49 | 5 | } |
|
| 50 | } |
||
| 51 |
