genkgo /
camt
| Conditions | 12 |
| Paths | 17 |
| Total Lines | 46 |
| Code Lines | 23 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 14 |
| CRAP Score | 22.4191 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | 7 | public function getRelatedPartyAccount(SimpleXMLElement $xmlRelatedPartyTypeAccount = null) |
|
| 16 | { |
||
| 17 | 7 | if ($xmlRelatedPartyTypeAccount !== null) { |
|
| 18 | |||
| 19 | 7 | if (false === isset($xmlRelatedPartyTypeAccount->Id)) { |
|
| 20 | return; |
||
| 21 | } |
||
| 22 | |||
| 23 | 7 | if (isset($xmlRelatedPartyTypeAccount->Id->IBAN)) { |
|
| 24 | 6 | return new DTO\IbanAccount(new Iban((string)$xmlRelatedPartyTypeAccount->Id->IBAN)); |
|
| 25 | } |
||
| 26 | |||
| 27 | 1 | if (isset($xmlRelatedPartyTypeAccount->Id->BBAN)) { |
|
| 28 | return new DTO\BBANAccount((string)$xmlRelatedPartyTypeAccount->Id->BBAN); |
||
| 29 | } |
||
| 30 | |||
| 31 | 1 | if (isset($xmlRelatedPartyTypeAccount->Id->UPIC)) { |
|
| 32 | return new DTO\UPICAccount((string)$xmlRelatedPartyTypeAccount->Id->UPIC); |
||
| 33 | } |
||
| 34 | |||
| 35 | 1 | if (isset($xmlRelatedPartyTypeAccount->Id->PrtryAcct)) { |
|
| 36 | return new DTO\ProprietaryAccount((string)$xmlRelatedPartyTypeAccount->Id->PrtryAcct->Id); |
||
| 37 | } |
||
| 38 | |||
| 39 | 1 | if (isset($xmlRelatedPartyTypeAccount->Id->Othr)) { |
|
| 40 | 1 | $xmlOtherIdentification = $xmlRelatedPartyTypeAccount->Id->Othr; |
|
| 41 | 1 | $otherAccount = new DTO\OtherAccount((string)$xmlOtherIdentification->Id); |
|
| 42 | |||
| 43 | 1 | if (isset($xmlOtherIdentification->SchmeNm)) { |
|
| 44 | if (isset($xmlOtherIdentification->SchmeNm->Cd)) { |
||
| 45 | $otherAccount->setSchemeName((string)$xmlOtherIdentification->SchmeNm->Cd); |
||
| 46 | } |
||
| 47 | |||
| 48 | if (isset($xmlOtherIdentification->SchmeNm->Prtry)) { |
||
| 49 | $otherAccount->setSchemeName((string)$xmlOtherIdentification->SchmeNm->Prtry); |
||
| 50 | } |
||
| 51 | } |
||
| 52 | |||
| 53 | 1 | if (isset($xmlOtherIdentification->Issr)) { |
|
| 54 | $otherAccount->setIssuer($xmlOtherIdentification->Issr); |
||
| 55 | } |
||
| 56 | |||
| 57 | 1 | return $otherAccount; |
|
| 58 | } |
||
| 59 | } |
||
| 60 | } |
||
| 61 | } |
||
| 62 |
