View GitHub Repository camt

Schedule Inspection
Subscribe
Completed
Pull Request — master (#20)
by Yann
02:45
created

EntryTransactionDetail::addRelatedParties()   C

↳ Parent: Project

Complexity

Conditions 11
Paths 23

Size

Total Lines 42
Code Lines 27

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 29
CRAP Score 11.3851

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 42
ccs 29
cts 34
cp 0.8529
rs 5.2653
cc 11
eloc 27
nc 23
nop 2
crap 11.3851

How to fix   Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Genkgo\Camt\Camt053\Decoder;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
use Genkgo\Camt\DTO;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
use Genkgo\Camt\Camt053\DTO as Camt053DTO;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
use Genkgo\Camt\Decoder\EntryTransactionDetail as BaseDecoder;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
use \SimpleXMLElement;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
use Genkgo\Camt\Iban;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
class EntryTransactionDetail extends BaseDecoder

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
     * {@inheritdoc}

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
     */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                             11                         
                
                
                
    public function getRelatedPartyAccount(SimpleXMLElement $xmlRelatedPartyTypeAccount)

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                             11                         
                
                
                
        if (false === isset($xmlRelatedPartyTypeAccount->Id)) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
            return;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                             11                         
                
                
                
        if (isset($xmlRelatedPartyTypeAccount->Id->IBAN) && $ibanCode = (string) $xmlRelatedPartyTypeAccount->Id->IBAN) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    23
                

                                    
                             10                         
                
                
                
            return new DTO\IbanAccount(new Iban($ibanCode));

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    26
                

                                    
                             6                         
                
                
                
        if (false === isset($xmlRelatedPartyTypeAccount->Id->Othr)) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
            return;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    30
                

                                    
                             6                         
                
                
                
        $xmlOtherIdentification = $xmlRelatedPartyTypeAccount->Id->Othr;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    31
                

                                    
                             6                         
                
                
                
        $otherAccount = new Camt053DTO\OtherAccount((string) $xmlOtherIdentification->Id);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    33
                

                                    
                             6                         
                
                
                
        if (isset($xmlOtherIdentification->SchmeNm)) {

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    34
                

                                    
                                                    
                
                
                
            if (isset($xmlOtherIdentification->SchmeNm->Cd)) {

            


            
                                                        
            
                                    
            
            

                
                    35
                

                                    
                                                    
                
                
                
                $otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Cd);

            


            
                                                        
            
                                    
            
            

                
                    36
                

                                    
                                                    
                
                
                
            }

            


            
                                                        
            
                                    
            
            

                
                    37
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    38
                

                                    
                                                    
                
                
                
            if (isset($xmlOtherIdentification->SchmeNm->Prtry)) {

            


            
                                                        
            
                                    
            
            

                
                    39
                

                                    
                                                    
                
                
                
                $otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Prtry);

            


            
                                                        
            
                                    
            
            

                
                    40
                

                                    
                                                    
                
                
                
            }

            


            
                                                        
            
                                    
            
            

                
                    41
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    42
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    43
                

                                    
                             6                         
                
                
                
        if (isset($xmlOtherIdentification->Issr)) {

            


            
                                                        
            
                                    
            
            

                
                    44
                

                                    
                             6                         
                
                
                
            $otherAccount->setIssuer((string) $xmlOtherIdentification->Issr);

            


            
                                                        
            
                                    
            
            

                
                    45
                

                                    
                             6                         
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    46
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    47
                

                                    
                             6                         
                
                
                
        return $otherAccount;

            


            
                                                        
            
                                    
            
            

                
                    48
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    49
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    50