PhpGedcom\Parser\Indi\Fams::parse()

Complexity

Conditions	6
Paths	3

Size

Total Lines	44
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function parse(\PhpGedcom\Parser $parser)
    {
        $record = $parser->getCurrentLineRecord();
        $depth = (int) $record[0];

        if (count($record) < 3) {

It seems like $record can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

            $parser->logSkippedRecord('Missing family information; '.get_class(), ' @ '.__LINE__);

The call to PhpGedcom\Parser::logSkippedRecord() has too many arguments starting with ' @ ' . __LINE__.

            $parser->skipToNextLevel($depth);

            return null;
        }

        $fams = $parser->normalizeIdentifier($record[2]);

        $fam = new \PhpGedcom\Record\Indi\Fams();
        $fam->setFams($fams);

The method setFams() does not exist on PhpGedcom\Record\Indi\Fams. Since you implemented __call, consider adding a @method annotation.

        $parser->forward();

        while (!$parser->eof()) {
            $record = $parser->getCurrentLineRecord();
            $recordType = strtoupper(trim($record[1]));
            $currentDepth = (int) $record[0];

            if ($currentDepth <= $depth) {
                $parser->back();
                break;
            }

            switch ($recordType) {
                case 'NOTE':
                    $note = \PhpGedcom\Parser\NoteRef::parse($parser);
                    if ($note) {
                        $fam->addNote($note);
                    }
                    break;
                default:
                    $parser->logUnhandledRecord(get_class().' @ '.__LINE__);
            }

            $parser->forward();
        }

        return $fam;
    }