Passed
Push — develop ( a91f78...5f7986 )
by Paul
06:48 queued 03:30
created
src/MetaBox/Instruction.php 3 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -86,6 +86,7 @@
 block discarded – undo
86 86
 	abstract public function filter( $name, ...$args );
87 87
 
88 88
 	/**
89
+	 * @param boolean $bool
89 90
 	 * @return bool
90 91
 	 * @filter rwmb_show
91 92
 	 */
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -22,11 +22,11 @@  discard block
 block discarded – undo
22 22
 	{
23 23
 		$instructions = array_reduce( $this->getInstructionGroups(), function( $html, $metabox ) {
24 24
 			$fields = $this->getInstructionFields( $metabox );
25
-			if( empty( $fields )) {
25
+			if( empty( $fields ) ) {
26 26
 				return $html;
27 27
 			}
28 28
 			return $html . sprintf( '<p><strong>%s</strong></p><pre class="my-sites nav-tab-active misc-pub-section">%s</pre>',
29
-				$metabox['title'],
29
+				$metabox[ 'title' ],
30 30
 				$fields
31 31
 			);
32 32
 		});
@@ -38,10 +38,10 @@  discard block
 block discarded – undo
38 38
 	 */
39 39
 	protected function getInstructionFields( $metabox )
40 40
 	{
41
-		$skipFields = ['custom_html', 'divider', 'heading'];
42
-		return array_reduce( $metabox['fields'], function( $html, $field ) use( $metabox ) {
43
-			return $this->validate( $field['condition'] ) && !in_array( $field['type'], $skipFields )
44
-				? $html . $this->filter( 'instruction', "PostMeta::get('{$field['slug']}');", $field, $metabox ) . PHP_EOL
41
+		$skipFields = [ 'custom_html', 'divider', 'heading' ];
42
+		return array_reduce( $metabox[ 'fields' ], function( $html, $field ) use( $metabox ) {
43
+			return $this->validate( $field[ 'condition' ] ) && !in_array( $field[ 'type' ], $skipFields )
44
+				? $html . $this->filter( 'instruction', "PostMeta::get('{$field[ 'slug' ]}');", $field, $metabox ) . PHP_EOL
45 45
 				: $html;
46 46
 		});
47 47
 	}
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	protected function getInstructionGroups()
53 53
 	{
54 54
 		return array_filter( $this->metaboxes, function( $metabox ) {
55
-			return $this->validate( $metabox['condition'] )
55
+			return $this->validate( $metabox[ 'condition' ] )
56 56
 				&& $this->hasPostType( $metabox );
57 57
 		});
58 58
 	}
@@ -66,11 +66,11 @@  discard block
 block discarded – undo
66 66
 		return [
67 67
 			'infodiv' => [
68 68
 				'context' => 'side',
69
-				'fields' => [[
69
+				'fields' => [ [
70 70
 					'slug' => '',
71 71
 					'std' => $this->generateInstructions(),
72 72
 					'type' => 'custom_html',
73
-				]],
73
+				] ],
74 74
 				'post_types' => $this->getPostTypes(),
75 75
 				'priority' => 'low',
76 76
 				'title' => __( 'How to use in your theme', 'pollux' ),
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	{
86 86
 		return $this->filter( 'show/instructions', count( array_filter( $this->metaboxes, function( $metabox ) {
87 87
 			return $this->show( false, $metabox );
88
-		})) > 0 );
88
+		}) ) > 0 );
89 89
 	}
90 90
 
91 91
 	/**
Please login to merge, or discard this patch.
Braces   +11 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,7 +20,8 @@  discard block
 block discarded – undo
20 20
 	 */
21 21
 	protected function generateInstructions()
22 22
 	{
23
-		$instructions = array_reduce( $this->getInstructionGroups(), function( $html, $metabox ) {
23
+		$instructions = array_reduce( $this->getInstructionGroups(), function( $html, $metabox )
24
+		{
24 25
 			$fields = $this->getInstructionFields( $metabox );
25 26
 			if( empty( $fields )) {
26 27
 				return $html;
@@ -39,7 +40,8 @@  discard block
 block discarded – undo
39 40
 	protected function getInstructionFields( $metabox )
40 41
 	{
41 42
 		$skipFields = ['custom_html', 'divider', 'heading'];
42
-		return array_reduce( $metabox['fields'], function( $html, $field ) use( $metabox ) {
43
+		return array_reduce( $metabox['fields'], function( $html, $field ) use( $metabox )
44
+		{
43 45
 			return $this->validate( $field['condition'] ) && !in_array( $field['type'], $skipFields )
44 46
 				? $html . $this->filter( 'instruction', "PostMeta::get('{$field['slug']}');", $field, $metabox ) . PHP_EOL
45 47
 				: $html;
@@ -51,7 +53,8 @@  discard block
 block discarded – undo
51 53
 	 */
52 54
 	protected function getInstructionGroups()
53 55
 	{
54
-		return array_filter( $this->metaboxes, function( $metabox ) {
56
+		return array_filter( $this->metaboxes, function( $metabox )
57
+		{
55 58
 			return $this->validate( $metabox['condition'] )
56 59
 				&& $this->hasPostType( $metabox );
57 60
 		});
@@ -62,7 +65,9 @@  discard block
 block discarded – undo
62 65
 	 */
63 66
 	protected function initInstructions()
64 67
 	{
65
-		if( !$this->showInstructions() )return;
68
+		if( !$this->showInstructions() ) {
69
+			return;
70
+		}
66 71
 		return [
67 72
 			'infodiv' => [
68 73
 				'context' => 'side',
@@ -83,7 +88,8 @@  discard block
 block discarded – undo
83 88
 	 */
84 89
 	protected function showInstructions()
85 90
 	{
86
-		return $this->filter( 'show/instructions', count( array_filter( $this->metaboxes, function( $metabox ) {
91
+		return $this->filter( 'show/instructions', count( array_filter( $this->metaboxes, function( $metabox )
92
+		{
87 93
 			return $this->show( false, $metabox );
88 94
 		})) > 0 );
89 95
 	}
Please login to merge, or discard this patch.
src/MetaBox/MetaBox.php 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -25,23 +25,23 @@  discard block
 block discarded – undo
25 25
 	/**
26 26
 	 * @var array
27 27
 	 */
28
-	public $metaboxes = [];
28
+	public $metaboxes = [ ];
29 29
 
30 30
 	/**
31 31
 	 * {@inheritdoc}
32 32
 	 */
33 33
 	public function init()
34 34
 	{
35
-		if( empty( $this->app->config->{static::ID} ))return;
35
+		if( empty( $this->app->config->{static::ID} ) )return;
36 36
 
37 37
 		$this->normalize( $this->app->config->{static::ID}, [
38
-			'post_types' => [],
39
-		]);
38
+			'post_types' => [ ],
39
+		] );
40 40
 
41
-		add_filter( 'rwmb_normalize_map_field', [$this, 'normalizeMapField'] );
42
-		add_filter( 'rwmb_show',                [$this, 'show'], 10, 2 );
43
-		add_filter( 'rwmb_meta_boxes',          [$this, 'register'] );
44
-		add_filter( 'rwmb_outer_html',          [$this, 'renderField'], 10, 2 );
41
+		add_filter( 'rwmb_normalize_map_field', [ $this, 'normalizeMapField' ] );
42
+		add_filter( 'rwmb_show', [ $this, 'show' ], 10, 2 );
43
+		add_filter( 'rwmb_meta_boxes', [ $this, 'register' ] );
44
+		add_filter( 'rwmb_outer_html', [ $this, 'renderField' ], 10, 2 );
45 45
 
46 46
 	}
47 47
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	{
76 76
 		return PostMeta::get( $key, [
77 77
 			'id' => $this->getPostId(),
78
-		]);
78
+		] );
79 79
 	}
80 80
 
81 81
 	/**
@@ -84,15 +84,15 @@  discard block
 block discarded – undo
84 84
 	 */
85 85
 	public function normalizeMapField( $field )
86 86
 	{
87
-		if( empty( $field['address_field'] )) {
87
+		if( empty( $field[ 'address_field' ] ) ) {
88 88
 			return $field;
89 89
 		}
90
-		if( !$this->app->make( Helper::class )->startsWith( Application::PREFIX, $field['address_field'] )) {
91
-			$field['address_field'] = Application::PREFIX . $field['address_field'];
90
+		if( !$this->app->make( Helper::class )->startsWith( Application::PREFIX, $field[ 'address_field' ] ) ) {
91
+			$field[ 'address_field' ] = Application::PREFIX . $field[ 'address_field' ];
92 92
 		}
93
-		$apiKey = SiteMeta::services( $field['api_key'] );
94
-		if( !empty( $apiKey ) && is_string( $apiKey )) {
95
-			$field['api_key'] = $apiKey;
93
+		$apiKey = SiteMeta::services( $field[ 'api_key' ] );
94
+		if( !empty( $apiKey ) && is_string( $apiKey ) ) {
95
+			$field[ 'api_key' ] = $apiKey;
96 96
 		}
97 97
 		return $field;
98 98
 	}
@@ -103,15 +103,15 @@  discard block
 block discarded – undo
103 103
 	 */
104 104
 	public function register()
105 105
 	{
106
-		if( current_user_can( 'switch_themes' )) {
106
+		if( current_user_can( 'switch_themes' ) ) {
107 107
 			$instructions = $this->initInstructions();
108
-			if( is_array( $instructions )) {
108
+			if( is_array( $instructions ) ) {
109 109
 				$this->normalize( $instructions );
110 110
 			}
111 111
 		}
112 112
 		$metaboxes = func_num_args()
113
-			? ( new Helper )->toArray( func_get_arg(0) )
114
-			: [];
113
+			? ( new Helper )->toArray( func_get_arg( 0 ) )
114
+			: [ ];
115 115
 		return array_merge( $metaboxes, $this->metaboxes );
116 116
 	}
117 117
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 */
122 122
 	public function renderField( $html, $field )
123 123
 	{
124
-		return $this->validate( $field['condition'] )
124
+		return $this->validate( $field[ 'condition' ] )
125 125
 			? $html
126 126
 			: '';
127 127
 	}
@@ -133,11 +133,11 @@  discard block
 block discarded – undo
133 133
 	public function show( $bool, array $metabox )
134 134
 	{
135 135
 		if( defined( 'DOING_AJAX' )
136
-			|| !isset( $metabox['condition'] )
137
-			|| !$this->hasPostType( $metabox )) {
136
+			|| !isset( $metabox[ 'condition' ] )
137
+			|| !$this->hasPostType( $metabox ) ) {
138 138
 			return $bool;
139 139
 		}
140
-		return $this->validate( $metabox['condition'] );
140
+		return $this->validate( $metabox[ 'condition' ] );
141 141
 	}
142 142
 
143 143
 	/**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	 */
146 146
 	protected function getPostId()
147 147
 	{
148
-		if( !( $postId = filter_input( INPUT_GET, 'post' ))) {
148
+		if( !( $postId = filter_input( INPUT_GET, 'post' ) ) ) {
149 149
 			$postId = filter_input( INPUT_POST, 'post_ID' );
150 150
 		}
151 151
 		return intval( $postId );
@@ -158,10 +158,10 @@  discard block
 block discarded – undo
158 158
 	{
159 159
 		return array_unique( iterator_to_array(
160 160
 			new RecursiveIteratorIterator(
161
-				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ))
161
+				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ) )
162 162
 			),
163 163
 			false
164
-		));
164
+		) );
165 165
 	}
166 166
 
167 167
 	/**
@@ -169,26 +169,26 @@  discard block
 block discarded – undo
169 169
 	 */
170 170
 	protected function hasPostType( array $metabox )
171 171
 	{
172
-		if( !isset( $metabox['post_types'] )) {
172
+		if( !isset( $metabox[ 'post_types' ] ) ) {
173 173
 			return true;
174 174
 		}
175
-		return in_array( get_post_type( $this->getPostId() ), $metabox['post_types'] );
175
+		return in_array( get_post_type( $this->getPostId() ), $metabox[ 'post_types' ] );
176 176
 	}
177 177
 
178 178
 	/**
179 179
 	 * @return void
180 180
 	 */
181
-	protected function normalize( array $metaboxes, array $defaults = [] )
181
+	protected function normalize( array $metaboxes, array $defaults = [ ] )
182 182
 	{
183 183
 		foreach( $metaboxes as $id => $metabox ) {
184 184
 			$data = wp_parse_args( $defaults, [
185
-				'condition' => [],
186
-				'fields' => [],
185
+				'condition' => [ ],
186
+				'fields' => [ ],
187 187
 				'id' => $id,
188 188
 				'slug' => $id,
189
-				'validation' => [],
190
-			]);
191
-			$this->metaboxes[] = $this->setDependencies(
189
+				'validation' => [ ],
190
+			] );
191
+			$this->metaboxes[ ] = $this->setDependencies(
192 192
 				$this->normalizeThis( $metabox, $data, $id )
193 193
 			);
194 194
 		}
@@ -222,10 +222,10 @@  discard block
 block discarded – undo
222 222
 	protected function normalizeFields( array $fields, array $data, $parentId )
223 223
 	{
224 224
 		return array_map( function( $id, $field ) use( $parentId ) {
225
-			$defaults =  [
226
-				'attributes' => [],
225
+			$defaults = [
226
+				'attributes' => [ ],
227 227
 				'class' => '',
228
-				'condition' => [],
228
+				'condition' => [ ],
229 229
 				'depends' => '',
230 230
 				'field_name' => $id,
231 231
 				'id' => $id,
@@ -259,11 +259,11 @@  discard block
 block discarded – undo
259 259
 	 */
260 260
 	protected function normalizeValidation( array $validation, array $data, $parentId )
261 261
 	{
262
-		foreach( ['messages', 'rules'] as $key ) {
263
-			if( empty( $validation[$key] ))continue;
264
-			foreach( $validation[$key] as $id => $value ) {
265
-				$validation[$key][$this->normalizeFieldName( $id, ['slug' => $id], $parentId )] = $value;
266
-				unset( $validation[$key][$id] );
262
+		foreach( [ 'messages', 'rules' ] as $key ) {
263
+			if( empty( $validation[ $key ] ) )continue;
264
+			foreach( $validation[ $key ] as $id => $value ) {
265
+				$validation[ $key ][ $this->normalizeFieldName( $id, [ 'slug' => $id ], $parentId ) ] = $value;
266
+				unset( $validation[ $key ][ $id ] );
267 267
 			}
268 268
 		}
269 269
 		return $validation;
@@ -274,14 +274,14 @@  discard block
 block discarded – undo
274 274
 	 */
275 275
 	protected function setDependencies( array $metabox )
276 276
 	{
277
-		$fields = &$metabox['fields'];
277
+		$fields = &$metabox[ 'fields' ];
278 278
 		$depends = array_column( $fields, 'depends' );
279 279
 		array_walk( $depends, function( $value, $index ) use( &$fields, $metabox ) {
280
-			if( empty( $value ))return;
281
-			$dependency = array_search( $value, array_column( $fields, 'id' ));
282
-			$fields[$index]['attributes']['data-depends'] = $value;
283
-			if( !$this->getMetaValue( $fields[$dependency]['slug'], '', $metabox['slug'] )) {
284
-				$fields[$index]['class'] = trim( 'hidden ' . $fields[$index]['class'] );
280
+			if( empty( $value ) )return;
281
+			$dependency = array_search( $value, array_column( $fields, 'id' ) );
282
+			$fields[ $index ][ 'attributes' ][ 'data-depends' ] = $value;
283
+			if( !$this->getMetaValue( $fields[ $dependency ][ 'slug' ], '', $metabox[ 'slug' ] ) ) {
284
+				$fields[ $index ][ 'class' ] = trim( 'hidden ' . $fields[ $index ][ 'class' ] );
285 285
 			}
286 286
 		});
287 287
 		return $metabox;
Please login to merge, or discard this patch.