test/AsciiConverterTest.js - Code Metrics - Inspection of "moved tests to test" - geezify/geezify-js - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f7e79f...2439d9 )

by Samson

created 2018-05-15 16:24 UTC

test/AsciiConverterTest.js A

↳ Parent: Project

Size

Lines of Code

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	1
rs	10
noi	2
c	0
b	0
f	0

const assert = require('assert');

const TestCase = require('./TestCase');
const AsciiConverter = require('../src/Converter/AsciiConverter');
const NotGeezArgumentException = require('../src/Exception/NotGeezArgumentException');

asciiConverter = new AsciiConverter();


describe('AsciiConverterTest', function () {

    describe('#test_ascii_converter()', function () {
        it('should convert geez number to ascii', function () {
            TestCase.geezNumberTestDataProvider().forEach(([$ascii, $geez]) => {
                $result = asciiConverter.convert($geez);

                assert.equal($ascii, $result);
            });
        });
    });

    describe('#test_invalid_number_throw_exception()', function () {
        it('should throws NotGeezArgumentException', function () {
            TestCase.invalidNumberDataProvider().forEach(($value) => {
                assert.throws(() => {
                    asciiConverter.convert($value)
                }, NotGeezArgumentException);
            });
        });
    });

});


1			const assert = require('assert');
2
3			const TestCase = require('./TestCase');
4			const AsciiConverter = require('../src/Converter/AsciiConverter');
5			const NotGeezArgumentException = require('../src/Exception/NotGeezArgumentException');
6
7			asciiConverter = new AsciiConverter();
			0 ignored issues – show Bug introduced 2018-05-15 16:05 UTC by Report Bug Copy Issue Report The variable `asciiConverter` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.asciiConverter`. Loading history...
8
9			describe('AsciiConverterTest', function () {
10
11			describe('#test_ascii_converter()', function () {
12			it('should convert geez number to ascii', function () {
13			TestCase.geezNumberTestDataProvider().forEach(([$ascii, $geez]) => {
14			$result = asciiConverter.convert($geez);
			0 ignored issues – show Bug introduced 2018-05-15 16:05 UTC by Report Bug Copy Issue Report The variable `$result` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.$result`. Loading history...
15			assert.equal($ascii, $result);
16			});
17			});
18			});
19
20			describe('#test_invalid_number_throw_exception()', function () {
21			it('should throws NotGeezArgumentException', function () {
22			TestCase.invalidNumberDataProvider().forEach(($value) => {
23			assert.throws(() => {
24			asciiConverter.convert($value)
25			}, NotGeezArgumentException);
26			});
27			});
28			});
29
30			});
31

geezify / geezify-js

Push — master ( f7e79f...2439d9 )

test/AsciiConverterTest.js A

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like