Passed
Push — master ( 05faca...9c86bf )
by Richard
08:39 queued 13s
created

showThread()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 10
Code Lines 7

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
eloc 7
dl 0
loc 10
rs 10
c 0
b 0
f 0
cc 2
nc 2
nop 25

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
/**
3
 * XOOPS Deprecated Old Functions
4
 *
5
 * You may not change or alter any portion of this comment or credits
6
 * of supporting developers from this source code or any supporting source code
7
 * which is considered copyrighted (c) material of the original comment or credit authors.
8
 * This program is distributed in the hope that it will be useful,
9
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * @copyright       (c) 2000-2023 XOOPS Project (www.xoops.org)
13
 * @license             GNU GPL 2 (https://www.gnu.org/licenses/gpl-2.0.html)
14
 * @package             kernel
15
 * @since               2.0.0
16
 * @author              Kazumi Ono (AKA onokazu) http://www.myweb.ne.jp/, http://jp.xoops.org/
17
 * @author              Taiwen Jiang <[email protected]>
18
 */
19
defined('XOOPS_ROOT_PATH') || exit('Restricted access');
20
21
trigger_error('Functions in ' . __FILE__ . ' are deprecated, should not be used any more', E_USER_WARNING);
22
23
/**
24
 * Enter description here...
25
 *
26
 * @param string|\unknown_type $width
0 ignored issues
show
Bug introduced by
The type unknown_type was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
27
 */
28
function openThread($width = '100%')
29
{
30
    echo "<table border='0' cellpadding='0' cellspacing='0' align='center' width='$width'><tr><td class='bg2'><table border='0' cellpadding='4' cellspacing='1' width='100%'><tr class='bg3' align='left'><td class='bg3' width='20%'>" . _CM_POSTER . "</td><td class='bg3'>" . _CM_THREAD . '</td></tr>';
31
}
32
33
/**
34
 * showThread :: DO NOT USE
35
 *
36
 * @param unknown_type         $color_number
37
 * @param unknown_type         $subject_image
38
 * @param unknown_type         $subject
39
 * @param unknown_type         $text
40
 * @param unknown_type         $post_date
41
 * @param unknown_type         $ip_image
42
 * @param unknown_type         $reply_image
43
 * @param unknown_type         $edit_image
44
 * @param unknown_type         $delete_image
45
 * @param string|\unknown_type $username
46
 * @param string|\unknown_type $rank_title
47
 * @param string|\unknown_type $rank_image
48
 * @param string|\unknown_type $avatar_image
49
 * @param string|\unknown_type $reg_date
50
 * @param string|\unknown_type $posts
51
 * @param string|\unknown_type $user_from
52
 * @param string|\unknown_type $online_image
53
 * @param string|\unknown_type $profile_image
54
 * @param string|\unknown_type $pm_image
55
 * @param string|\unknown_type $email_image
56
 * @param string|\unknown_type $www_image
57
 * @param string|\unknown_type $icq_image
58
 * @param string|\unknown_type $aim_image
59
 * @param string|\unknown_type $yim_image
60
 * @param string|\unknown_type $msnm_image
61
 */
62
function showThread($color_number, $subject_image, $subject, $text, $post_date, $ip_image, $reply_image, $edit_image, $delete_image, $username = '', $rank_title = '', $rank_image = '', $avatar_image = '', $reg_date = '', $posts = '', $user_from = '', $online_image = '', $profile_image = '', $pm_image = '', $email_image = '', $www_image = '', $icq_image = '', $aim_image = '', $yim_image = '', $msnm_image = '')
63
{
64
    $bg = 'bg3';
65
    if ($color_number == 1) {
0 ignored issues
show
introduced by
The condition $color_number == 1 is always false.
Loading history...
66
        $bg = 'bg1';
67
    }
68
    echo "<tr align='left'><td valign='top' class='$bg' nowrap='nowrap'><strong>$username</strong><br>$rank_title<br>$rank_image<br>$avatar_image<br><br>$reg_date<br>$posts<br>$user_from<br><br>$online_image</td>";
69
    echo "<td valign='top' class='$bg'><table width='100%' border='0'><tr><td valign='top'>$subject_image&nbsp;<strong>$subject</strong></td><td align='right'>" . $ip_image . '' . $reply_image . '' . $edit_image . '' . $delete_image . '</td></tr>';
70
    echo "<tr><td colspan='2'><p>$text</p></td></tr></table></td></tr>";
71
    echo "<tr align='left'><td class='$bg' valign='middle'>$post_date</td><td class='$bg' valign='middle'>" . $profile_image . '' . $pm_image . '' . $email_image . '' . $www_image . '' . $icq_image . '' . $aim_image . '' . $yim_image . '' . $msnm_image . '</td></tr>';
72
}
73
74
/**
75
 * Enter description here...
76
 *
77
 */
78
function closeThread()
79
{
80
    echo '</table></td></tr></table>';
81
}
82