| Conditions | 6 |
| Paths | 32 |
| Total Lines | 68 |
| Code Lines | 45 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 50 | function xoStatsRegen() |
||
| 51 | { |
||
| 52 | global $xoopsUser, $xoopsModule; |
||
| 53 | |||
| 54 | $stats = array(); |
||
| 55 | |||
| 56 | /** @var \XoopsMemberHandler $memberHandler */ |
||
| 57 | $memberHandler = xoops_getHandler('member'); |
||
| 58 | |||
| 59 | // Getting Total Online Users |
||
| 60 | /** @var \XoopsOnlineHandler $onlineHandler */ |
||
| 61 | $onlineHandler = xoops_getHandler('online'); |
||
| 62 | // set gc probability to 10% for now.. |
||
| 63 | if (mt_rand(1, 100) < 11) { |
||
| 64 | $onlineHandler->gc(300); |
||
| 65 | } |
||
| 66 | if (is_object($xoopsUser)) { |
||
| 67 | $uid = $xoopsUser->getVar('uid'); |
||
| 68 | $uname = $xoopsUser->getVar('uname'); |
||
| 69 | } else { |
||
| 70 | $uid = 0; |
||
| 71 | $uname = ''; |
||
| 72 | } |
||
| 73 | |||
| 74 | $requestIp = IPAddress::fromRequest()->asReadable(); |
||
| 75 | $requestIp = (false === $requestIp) ? '0.0.0.0' : $requestIp; |
||
| 76 | if (is_object($xoopsModule)) { |
||
| 77 | $onlineHandler->write($uid, $uname, time(), $xoopsModule->getVar('mid'), $requestIp); |
||
| 78 | } else { |
||
| 79 | $onlineHandler->write($uid, $uname, time(), 0, $requestIp); |
||
| 80 | } |
||
| 81 | $onlines = $onlineHandler->getAll(); |
||
| 82 | if (empty($onlines)) { |
||
| 83 | $stats['totalOnline'] = 0; |
||
| 84 | } else { |
||
| 85 | $stats['totalOnline'] = count($onlines); |
||
| 86 | } |
||
| 87 | |||
| 88 | //Getting Total Registered Users |
||
| 89 | $levelCriteria = new \Criteria('level', 0, '>'); |
||
| 90 | $criteria = new \CriteriaCompo($levelCriteria); |
||
| 91 | $criteria24 = new \CriteriaCompo($levelCriteria); |
||
| 92 | $criteria24->add(new \Criteria('user_regdate', (mktime(0, 0, 0) - (24 * 3600)), '>='), 'AND'); |
||
| 93 | $criteria48 = new \CriteriaCompo($levelCriteria); |
||
| 94 | $criteria48->add(new \Criteria('user_regdate', (mktime(0, 0, 0) - (48 * 3600)), '>='), 'AND'); |
||
| 95 | $criteria48->add(new \Criteria('user_regdate', (mktime(0, 0, 0) - (24 * 3600)), '<'), 'AND'); |
||
| 96 | $stats['totalUsers'] = $memberHandler->getUserCount($levelCriteria); |
||
| 97 | |||
| 98 | //Getting User Registration Statistics |
||
| 99 | $stats['newUsersToday'] = $memberHandler->getUserCount($criteria24); |
||
| 100 | $stats['newUsersYesterday'] = $memberHandler->getUserCount($criteria48); |
||
| 101 | |||
| 102 | // Getting Last Registered Member |
||
| 103 | $criteria->setOrder('DESC'); |
||
| 104 | $criteria->setSort('user_regdate'); |
||
| 105 | $criteria->setLimit(1); |
||
| 106 | $lastMembers = $memberHandler->getUsers($criteria); |
||
| 107 | $stats['latestMemberName'] = $lastMembers[0]->getVar('name'); |
||
| 108 | $stats['latestMemberUname'] = $lastMembers[0]->getVar('uname'); |
||
| 109 | $stats['latestUid'] = $lastMembers[0]->getVar('uid'); |
||
| 110 | |||
| 111 | //Total Post Count |
||
| 112 | $sql = 'SELECT SUM(posts) AS totalposts FROM ' . $GLOBALS['xoopsDB']->prefix('users') . ' WHERE level > 0'; |
||
| 113 | $result = $GLOBALS['xoopsDB']->query($sql); |
||
| 114 | $myrow = $GLOBALS['xoopsDB']->fetchArray($result); |
||
| 115 | $stats['totalPosts'] = $myrow['totalposts']; |
||
| 116 | |||
| 117 | return $stats; |
||
| 118 | } |
||
| 119 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.