geekwright / XoopsCore

htdocs/modules/publisher/src/PermissionHandler.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
  * @author          The SmartFactory <www.smartfactory.ca>
  * @version         $Id$
  */
-require_once \dirname(__DIR__) . '/include/common.php';
+require_once \dirname(__DIR__).'/include/common.php';
 
 /**
  * Class PermissionHandler
@@ -165,7 +165,7 @@ 
         // Save the new permissions
         if (\count($groups) > 0) {
             foreach ($groups as $group_id) {
-                echo $group_id . '-';
+                echo $group_id.'-';
                 echo $gpermHandler->addRight($perm_name, $itemid, $group_id, $module_id);
             }
         }

htdocs/modules/publisher/src/file.php

Spacing +7 added lines, -7 removed lines

@@ -27,7 +27,7 @@ 
  * @author          The SmartFactory <www.smartfactory.ca>
  * @version         $Id$
  */
-require_once \dirname(__DIR__) . '/include/common.php';
+require_once \dirname(__DIR__).'/include/common.php';
 
 // File status
 \define('_PUBLISHER_STATUS_FILE_NOTSET', -1);
@@ -123,9 +123,9 @@ 
                 throw new RuntimeException(\sprintf('Directory "%s" was not created', $concurrentDirectory));
             }
         }
-        $uploader = new XoopsMediaUploader(Publisher\Utils::getUploadDir() . '/', $allowed_mimetypes, $maxfilesize, $maxfilewidth, $maxfileheight);
+        $uploader = new XoopsMediaUploader(Publisher\Utils::getUploadDir().'/', $allowed_mimetypes, $maxfilesize, $maxfilewidth, $maxfileheight);
         if ($uploader->fetchMedia($post_field)) {
-            $uploader->setTargetFileName($itemid . '_' . $uploader->getMediaName());
+            $uploader->setTargetFileName($itemid.'_'.$uploader->getMediaName());
             if ($uploader->upload()) {
                 $this->setVar('filename', $uploader->getSavedFileName());
                 if ('' == $this->getVar('name')) {
@@ -187,22 +187,22 @@ 
 
     public function getFileUrl(): string
     {
-        return Publisher\Utils::getUploadDir(false) . $this->getVar('filename');
+        return Publisher\Utils::getUploadDir(false).$this->getVar('filename');
     }
 
     public function getFilePath(): string
     {
-        return Publisher\Utils::getUploadDir() . $this->getVar('filename');
+        return Publisher\Utils::getUploadDir().$this->getVar('filename');
     }
 
     public function getFileLink(): string
     {
-        return "<a href='" . \PUBLISHER_URL . '/visit.php?fileid=' . $this->getVar('fileid') . "'>" . $this->getVar('name') . '</a>';
+        return "<a href='".\PUBLISHER_URL.'/visit.php?fileid='.$this->getVar('fileid')."'>".$this->getVar('name').'</a>';
     }
 
     public function getItemLink(): string
     {
-        return "<a href='" . \PUBLISHER_URL . '/item.php?itemid=' . $this->getVar('itemid') . "'>" . $this->getVar('name') . '</a>';
+        return "<a href='".\PUBLISHER_URL.'/item.php?itemid='.$this->getVar('itemid')."'>".$this->getVar('name').'</a>';
     }
 
     /**

htdocs/modules/publisher/src/metagen.php

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
  * @author          The SmartFactory <www.smartfactory.ca>
  * @version         $Id$
  */
-require_once \dirname(__DIR__) . '/include/common.php';
+require_once \dirname(__DIR__).'/include/common.php';
 
 /**
  * Class Metagen
@@ -204,7 +204,7 @@ 
 
     public function createMetaKeywords(): string
     {
-        $keywords = $this->findMetaKeywords($this->_original_title . ' ' . $this->_description, $this->_minChar);
+        $keywords = $this->findMetaKeywords($this->_original_title.' '.$this->_description, $this->_minChar);
         $moduleKeywords = $this->helper->getConfig('seo_meta_keywords');
         if ('' != $moduleKeywords) {
             $moduleKeywords = \explode(',', $moduleKeywords);

htdocs/modules/publisher/src/form/CategoryForm.php

Spacing +4 added lines, -4 removed lines

@@ -43,7 +43,7 @@ 
  * @author          trabis <lusopoemas@gmail.com>
  * @version         $Id$
  */
-require_once \dirname(\dirname(__DIR__)) . '/include/common.php';
+require_once \dirname(\dirname(__DIR__)).'/include/common.php';
 
 /**
  * Class CategoryForm
@@ -129,10 +129,10 @@ 
         // IMAGE
         $image_select = new Select('', 'image', $obj->image());
         ImageFile::setOptionsArray($image_select, Publisher\Utils::getImageDir('category'));
-        $image_select->setExtra("onchange='showImgSelected(\"image3\", \"image\", \"" . 'uploads/' . \PUBLISHER_DIRNAME . '/images/category/' . '", "", "' . XoopsBaseConfig::get('url') . "\")'");
+        $image_select->setExtra("onchange='showImgSelected(\"image3\", \"image\", \"".'uploads/'.\PUBLISHER_DIRNAME.'/images/category/'.'", "", "'.XoopsBaseConfig::get('url')."\")'");
         $image_tray = new ElementTray(_AM_PUBLISHER_IMAGE, '&nbsp;');
         $image_tray->addElement($image_select);
-        $image_tray->addElement(new Label('', "<br><br><img src='" . Publisher\Utils::getImageDir('category', false) . $obj->image() . "' name='image3' id='image3' alt=''>"));
+        $image_tray->addElement(new Label('', "<br><br><img src='".Publisher\Utils::getImageDir('category', false).$obj->image()."' name='image3' id='image3' alt=''>"));
         $image_tray->setDescription(_AM_PUBLISHER_IMAGE_DSC);
         $this->addElement($image_tray);
 
@@ -199,7 +199,7 @@ 
             } else {
                 $subname = '';
             }
-            $cat_tray->addElement(new Text('', 'scname[' . $i . ']', 50, 255, $subname));
+            $cat_tray->addElement(new Text('', 'scname['.$i.']', 50, 255, $subname));
         }
         $t = new Text('', 'nb_subcats', 3, 2);
         $l = new Label('', \sprintf(_AM_PUBLISHER_ADD_OPT, $t->render()));

htdocs/modules/publisher/src/form/FileForm.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 use XoopsModules\Publisher;
 use XoopsModules\Publisher\Helper;
 
-require_once \dirname(\dirname(__DIR__)) . '/include/common.php';
+require_once \dirname(\dirname(__DIR__)).'/include/common.php';
 
 /**
  * Class FileForm

htdocs/modules/publisher/src/form/ItemForm.php

Indentation +6 added lines, -6 removed lines

@@ -591,12 +591,12 @@
             $imagesTab->addElement($image_select3);
 
             $imgTag = new Img([
-                                         'src' => $xoops->url('uploads/' . $imageforpath),
-                                         'width' => 500,
-                                         'name' => 'image_display',
-                                         'id' => 'image_display',
-                                         'alt' => '',
-                                     ]);
+                                            'src' => $xoops->url('uploads/' . $imageforpath),
+                                            'width' => 500,
+                                            'name' => 'image_display',
+                                            'id' => 'image_display',
+                                            'alt' => '',
+                                        ]);
             $image_preview = new Label(_CO_PUBLISHER_IMAGE_PREVIEW, $imgTag->render());
             $imagesTab->addElement($image_preview);
         }

Spacing +28 added lines, -28 removed lines

@@ -40,7 +40,7 @@ 
 use XoopsModules\Publisher;
 use XoopsModules\Publisher\Helper;
 
-require_once \dirname(\dirname(__DIR__)) . '/include/common.php';
+require_once \dirname(\dirname(__DIR__)).'/include/common.php';
 
 $helper = Helper::getInstance();
 
@@ -206,7 +206,7 @@ 
             $wrap_pages = XoopsLists::getHtmlListAsArray(Publisher\Utils::getUploadDir(true, 'content'));
             $available_wrap_pages_text = [];
             foreach ($wrap_pages as $page) {
-                $available_wrap_pages_text[] = "<span onclick='publisherPageWrap(\"body\", \"[pagewrap=$page] \");'" . " onmouseover='style.cursor=\"pointer\"'>$page</span>";
+                $available_wrap_pages_text[] = "<span onclick='publisherPageWrap(\"body\", \"[pagewrap=$page] \");'"." onmouseover='style.cursor=\"pointer\"'>$page</span>";
             }
             $available_wrap_pages = new Label(_CO_PUBLISHER_AVAILABLE_PAGE_WRAP, \implode(', ', $available_wrap_pages_text));
             $available_wrap_pages->setDescription(_CO_PUBLISHER_AVAILABLE_PAGE_WRAP_DSC);
@@ -397,28 +397,28 @@ 
                     $table .= "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
                     $table .= '<tr>';
                     $table .= "<td width='50' class='bg3' align='center'><strong>ID</strong></td>";
-                    $table .= "<td width='150' class='bg3' align='left'><strong>" . _AM_PUBLISHER_FILENAME . '</strong></td>';
-                    $table .= "<td class='bg3' align='left'><strong>" . _AM_PUBLISHER_DESCRIPTION . '</strong></td>';
-                    $table .= "<td width='60' class='bg3' align='center'><strong>" . _AM_PUBLISHER_HITS . '</strong></td>';
-                    $table .= "<td width='100' class='bg3' align='center'><strong>" . _AM_PUBLISHER_UPLOADED_DATE . '</strong></td>';
-                    $table .= "<td width='60' class='bg3' align='center'><strong>" . _AM_PUBLISHER_ACTION . '</strong></td>';
+                    $table .= "<td width='150' class='bg3' align='left'><strong>"._AM_PUBLISHER_FILENAME.'</strong></td>';
+                    $table .= "<td class='bg3' align='left'><strong>"._AM_PUBLISHER_DESCRIPTION.'</strong></td>';
+                    $table .= "<td width='60' class='bg3' align='center'><strong>"._AM_PUBLISHER_HITS.'</strong></td>';
+                    $table .= "<td width='100' class='bg3' align='center'><strong>"._AM_PUBLISHER_UPLOADED_DATE.'</strong></td>';
+                    $table .= "<td width='60' class='bg3' align='center'><strong>"._AM_PUBLISHER_ACTION.'</strong></td>';
                     $table .= '</tr>';
 
                     /* @var Publisher\File $fileObj */
                     foreach ($filesObj as $fileObj) {
-                        $modify = "<a href='file.php?op=mod&fileid=" . $fileObj->getVar('fileid') . "'><img src='" . \PUBLISHER_URL . "/images/links/edit.gif' title='" . _CO_PUBLISHER_EDITFILE . "' alt='" . _CO_PUBLISHER_EDITFILE . "'></a>";
-                        $delete = "<a href='file.php?op=del&fileid=" . $fileObj->getVar('fileid') . "'><img src='" . \PUBLISHER_URL . "/images/links/delete.png' title='" . _CO_PUBLISHER_DELETEFILE . "' alt='" . _CO_PUBLISHER_DELETEFILE . "'></a>";
+                        $modify = "<a href='file.php?op=mod&fileid=".$fileObj->getVar('fileid')."'><img src='".\PUBLISHER_URL."/images/links/edit.gif' title='"._CO_PUBLISHER_EDITFILE."' alt='"._CO_PUBLISHER_EDITFILE."'></a>";
+                        $delete = "<a href='file.php?op=del&fileid=".$fileObj->getVar('fileid')."'><img src='".\PUBLISHER_URL."/images/links/delete.png' title='"._CO_PUBLISHER_DELETEFILE."' alt='"._CO_PUBLISHER_DELETEFILE."'></a>";
                         if (0 == $fileObj->getVar('status')) {
-                            $notVisible = "<img src='" . \PUBLISHER_URL . "/images/no.gif'>";
+                            $notVisible = "<img src='".\PUBLISHER_URL."/images/no.gif'>";
                         } else {
                             $notVisible = '';
                         }
                         $table .= '<tr>';
-                        $table .= "<td class='head' align='center'>" . $fileObj->getVar('fileid') . '</td>';
-                        $table .= "<td class='odd' align='left'>" . $notVisible . $fileObj->getFileLink() . '</td>';
-                        $table .= "<td class='even' align='left'>" . $fileObj->getVar('description') . '</td>';
-                        $table .= "<td class='even' align='center'>" . $fileObj->getVar('counter') . '';
-                        $table .= "<td class='even' align='center'>" . $fileObj->datesub() . '</td>';
+                        $table .= "<td class='head' align='center'>".$fileObj->getVar('fileid').'</td>';
+                        $table .= "<td class='odd' align='left'>".$notVisible.$fileObj->getFileLink().'</td>';
+                        $table .= "<td class='even' align='left'>".$fileObj->getVar('description').'</td>';
+                        $table .= "<td class='even' align='center'>".$fileObj->getVar('counter').'';
+                        $table .= "<td class='even' align='center'>".$fileObj->datesub().'</td>';
                         $table .= "<td class='even' align='center'> {$modify} {$delete} </td>";
                         $table .= '</tr>';
                     }
@@ -462,7 +462,7 @@ 
 
             $imageObjs = [];
             if (!empty($catids)) {
-                $criteria = new CriteriaCompo(new Criteria('imgcat_id', '(' . \implode(',', $catids) . ')', 'IN'));
+                $criteria = new CriteriaCompo(new Criteria('imgcat_id', '('.\implode(',', $catids).')', 'IN'));
                 $criteria->add(new Criteria('image_display', 1));
                 $criteria->setSort('image_nicename');
                 $criteria->setOrder('ASC');
@@ -478,38 +478,38 @@ 
 
             $image_select = new Select('', 'image_notused', '', 5);
             $image_select->addOptionArray($image_array);
-            $image_select->set('onchange', 'showImgSelected("image_display", "image_notused", "uploads/", "", "' . XoopsBaseConfig::get('url') . '")');
+            $image_select->set('onchange', 'showImgSelected("image_display", "image_notused", "uploads/", "", "'.XoopsBaseConfig::get('url').'")');
             unset($image_array);
 
             $image_select2 = new Select('', 'image_item', '', 5, true);
             $image_select2->addOptionArray($objimage_array);
-            $image_select2->set('onchange', 'publisher_updateSelectOption("image_item", "image_featured"), ' . 'showImgSelected("image_display", "image_item", "uploads/", "", "' . XoopsBaseConfig::get('url') . '");');
+            $image_select2->set('onchange', 'publisher_updateSelectOption("image_item", "image_featured"), '.'showImgSelected("image_display", "image_item", "uploads/", "", "'.XoopsBaseConfig::get('url').'");');
 
             $buttonadd = new Button('', 'buttonadd', _CO_PUBLISHER_ADD);
-            $buttonadd->set('onclick', 'publisher_appendSelectOption("image_notused", "image_item"), ' . 'publisher_updateSelectOption("image_item", "image_featured");');
+            $buttonadd->set('onclick', 'publisher_appendSelectOption("image_notused", "image_item"), '.'publisher_updateSelectOption("image_item", "image_featured");');
 
             $buttonremove = new Button('', 'buttonremove', _CO_PUBLISHER_REMOVE);
-            $buttonremove->set('onclick', 'publisher_appendSelectOption("image_item", "image_notused"), ' . 'publisher_updateSelectOption("image_item", "image_featured");');
+            $buttonremove->set('onclick', 'publisher_appendSelectOption("image_item", "image_notused"), '.'publisher_updateSelectOption("image_item", "image_featured");');
 
             $opentable = new Label('', '<table><tr><td>');
             $addcol = new Label('', '</td><td>');
             $addbreak = new Label('', '<br>');
             $closetable = new Label('', '</td></tr></table>');
 
-            $xoops->theme()->addScript(\PUBLISHER_URL . '/js/ajaxupload.3.9.js');
+            $xoops->theme()->addScript(\PUBLISHER_URL.'/js/ajaxupload.3.9.js');
             //todo, find replacement for error class
             $js_data = new Label('', '
 <script type= "text/javascript">/*<![CDATA[*/
 $(document).ready(function(){
     var button = $("#publisher_upload_button"), interval;
     new AjaxUpload(button,{
-        action: "' . \PUBLISHER_URL . '/include/ajax_upload.php", // I disabled uploads in this example for security reasons
+        action: "' . \PUBLISHER_URL.'/include/ajax_upload.php", // I disabled uploads in this example for security reasons
         responseType: "text/html",
         name: "publisher_upload_file",
         onSubmit : function(file, ext){
             // change button text, when user selects file
             $("#publisher_upload_message").html(" ");
-            button.html("<img src=\'' . \PUBLISHER_URL . '/images/loadingbar.gif\'>"); this.setData({
+            button.html("<img src=\'' . \PUBLISHER_URL.'/images/loadingbar.gif\'>"); this.setData({
                 "image_nicename": $("#image_nicename").val(),
                 "imgcat_id" : $("#imgcat_id").val()
             });
@@ -520,7 +520,7 @@ 
             }, 200);
         },
         onComplete: function(file, response){
-            button.text("' . _CO_PUBLISHER_IMAGE_UPLOAD_NEW . '");
+            button.text("' . _CO_PUBLISHER_IMAGE_UPLOAD_NEW.'");
             window.clearInterval(interval);
             // enable upload button
             this.enable();
@@ -529,7 +529,7 @@ 
             if (result[0] == "success") {
                  $("#image_item").append("<option value=\'" + result[1] + "\' selected=\'selected\'>" + result[2] + "</option>");
                  publisher_updateSelectOption(\'image_item\', \'image_featured\');
-                 showImgSelected(\'image_display\', \'image_item\', \'uploads/\', \'\', \'' . XoopsBaseConfig::get('url') . '\')
+                 showImgSelected(\'image_display\', \'image_item\', \'uploads/\', \'\', \'' . XoopsBaseConfig::get('url').'\')
             } else {
                  $("#publisher_upload_message").html("<div class=\'errorMsg\'>" + result[1] + "</div>");
             }
@@ -539,7 +539,7 @@ 
 /*]]>*/</script>
 ');
             $messages = new Label('', "<div id='publisher_upload_message'></div>");
-            $button = new Label('', "<div id='publisher_upload_button'>" . _CO_PUBLISHER_IMAGE_UPLOAD_NEW . '</div>');
+            $button = new Label('', "<div id='publisher_upload_button'>"._CO_PUBLISHER_IMAGE_UPLOAD_NEW.'</div>');
             $nicename = new Text('', 'image_nicename', 30, 30, \_CO_PUBLISHER_IMAGE_NICENAME);
 
             $catlist = $imgcatHandler->getListByPermission($group, 'imgcat_read', 1);
@@ -586,12 +586,12 @@ 
 
             $image_select3 = new Select(_CO_PUBLISHER_IMAGE_ITEM, 'image_featured', $imagename, 1);
             $image_select3->addOptionArray($objimage_array);
-            $image_select3->set('onchange', 'showImgSelected("image_display", "image_featured", "uploads/", "", "' . XoopsBaseConfig::get('url') . '");');
+            $image_select3->set('onchange', 'showImgSelected("image_display", "image_featured", "uploads/", "", "'.XoopsBaseConfig::get('url').'");');
             $image_select3->setDescription(_CO_PUBLISHER_IMAGE_ITEM_DSC);
             $imagesTab->addElement($image_select3);
 
             $imgTag = new Img([
-                                         'src' => $xoops->url('uploads/' . $imageforpath),
+                                         'src' => $xoops->url('uploads/'.$imageforpath),
                                          'width' => 500,
                                          'name' => 'image_display',
                                          'id' => 'image_display',

htdocs/modules/publisher/src/utils.php

Spacing +48 added lines, -48 removed lines

@@ -183,7 +183,7 @@ 
             return $helper->getModule()->getVar('name');
         }
 
-        return '<a href="' . $xoops->url(\PUBLISHER_URL) . '/">' . $helper->getModule()->getVar('name') . '</a>';
+        return '<a href="'.$xoops->url(\PUBLISHER_URL).'/">'.$helper->getModule()->getVar('name').'</a>';
     }
 
     /**
@@ -260,10 +260,10 @@ 
             $path_status = _AM_PUBLISHER_AVAILABLE;
         } elseif (!@\is_dir($thePath)) {
             $pathCheckResult = -1;
-            $path_status = _AM_PUBLISHER_NOTAVAILABLE . " <a href='" . $helper->url("admin/index.php?op=createdir&amp;path={$item}") . "'>" . _AM_PUBLISHER_CREATETHEDIR . '</a>';
+            $path_status = _AM_PUBLISHER_NOTAVAILABLE." <a href='".$helper->url("admin/index.php?op=createdir&amp;path={$item}")."'>"._AM_PUBLISHER_CREATETHEDIR.'</a>';
         } else {
             $pathCheckResult = -2;
-            $path_status = \_AM_PUBLISHER_NOTWRITABLE . " <a href='" . $helper->url("admin/index.php?op=setperm&amp;path={$item}") . "'>" . _AM_SCS_SETMPERM . '</a>';
+            $path_status = \_AM_PUBLISHER_NOTWRITABLE." <a href='".$helper->url("admin/index.php?op=setperm&amp;path={$item}")."'>"._AM_SCS_SETMPERM.'</a>';
         }
         if (!$getStatus) {
             return $path_status;
@@ -327,17 +327,17 @@ 
             if ('root' === $item) {
                 $item = '';
             } else {
-                $item = $item . '/';
+                $item = $item.'/';
             }
         } else {
             $item = '';
         }
 
         if ($hasPath) {
-            return $xoops->path(\PUBLISHER_UPLOADS_PATH . '/' . $item);
+            return $xoops->path(\PUBLISHER_UPLOADS_PATH.'/'.$item);
         }
 
-        return $xoops->url(\PUBLISHER_UPLOADS_URL . '/' . $item);
+        return $xoops->url(\PUBLISHER_UPLOADS_URL.'/'.$item);
     }
 
     /**
@@ -362,7 +362,7 @@ 
     {
         $ret = '';
         foreach ($errors as $value) {
-            $ret .= '<br> - ' . $value;
+            $ret .= '<br> - '.$value;
         }
 
         return $ret;
@@ -447,11 +447,11 @@ 
             $display = 'block';
         }
 
-        echo "<h3 style=\"color: #2F5376; font-weight: bold; font-size: 14px; margin: 6px 0 0 0; \"><a href='javascript:;' onclick=\"toggle('" . $tablename . "'); toggleIcon('" . $iconname . "')\";>";
-        echo "<img id='" . $iconname . "' src='" . $helper->url('images/links/' . $image) . "' alt=''></a>&nbsp;" . $tabletitle . '</h3>';
-        echo "<div id='" . $tablename . "' style='display: " . $display . ";'>";
+        echo "<h3 style=\"color: #2F5376; font-weight: bold; font-size: 14px; margin: 6px 0 0 0; \"><a href='javascript:;' onclick=\"toggle('".$tablename."'); toggleIcon('".$iconname."')\";>";
+        echo "<img id='".$iconname."' src='".$helper->url('images/links/'.$image)."' alt=''></a>&nbsp;".$tabletitle.'</h3>';
+        echo "<div id='".$tablename."' style='display: ".$display.";'>";
         if ('' != $tabledsc) {
-            echo '<span style="color: #567; margin: 3px 0 12px 0; font-size: small; display: block; ">' . $tabledsc . '</span>';
+            echo '<span style="color: #567; margin: 3px 0 12px 0; font-size: small; display: block; ">'.$tabledsc.'</span>';
         }
     }
 
@@ -466,14 +466,14 @@ 
         $urls = self::getCurrentUrls();
         $path = $urls['phpself'];
 
-        $cookie_name = $path . '_publisher_collaps_' . $name;
+        $cookie_name = $path.'_publisher_collaps_'.$name;
         $cookie_name = \str_replace('.', '_', $cookie_name);
         $cookie = self::getCookieVar($cookie_name, '');
 
         if ('none' === $cookie) {
             echo '
         <script type="text/javascript"><!--
-        toggle("' . $name . '"); toggleIcon("' . $icon . '");
+        toggle("' . $name.'"); toggleIcon("'.$icon.'");
         //-->
         </script>
         ';
@@ -516,10 +516,10 @@ 
         $querystring = $_SERVER['QUERY_STRING'] ?? '';
 
         if ('' != $querystring) {
-            $querystring = '?' . $querystring;
+            $querystring = '?'.$querystring;
         }
 
-        $currenturl = $http . $httphost . $phpself . $querystring;
+        $currenturl = $http.$httphost.$phpself.$querystring;
 
         $urls = [];
         $urls['http'] = $http;
@@ -555,13 +555,13 @@ 
             $spaces .= '--';
         }
 
-        $ret .= "<option value='" . $categoryObj->getVar('categoryid') . "'";
+        $ret .= "<option value='".$categoryObj->getVar('categoryid')."'";
         if (\is_array($selectedid) && \in_array($categoryObj->getVar('categoryid'), $selectedid)) {
             $ret .= " selected='selected'";
         } elseif ($categoryObj->getVar('categoryid') == $selectedid) {
             $ret .= " selected='selected'";
         }
-        $ret .= '>' . $spaces . $categoryObj->getVar('name') . "</option>\n";
+        $ret .= '>'.$spaces.$categoryObj->getVar('name')."</option>\n";
 
         $subCategoriesObj = $helper->getCategoryHandler()->getCategories(0, 0, $categoryObj->getVar('categoryid'));
         if (\count($subCategoriesObj) > 0) {
@@ -588,13 +588,13 @@ 
 
         $selectedid = \explode(',', $selectedid);
 
-        $ret = "<select name='" . $selectname . "[]' multiple='multiple' size='10'>";
+        $ret = "<select name='".$selectname."[]' multiple='multiple' size='10'>";
         if ($allCatOption) {
             $ret .= "<option value='0'";
             if (\in_array(0, $selectedid)) {
                 $ret .= " selected='selected'";
             }
-            $ret .= '>' . _MB_PUBLISHER_ALLCAT . '</option>';
+            $ret .= '>'._MB_PUBLISHER_ALLCAT.'</option>';
         }
 
         // Creating category objects
@@ -624,7 +624,7 @@ 
         $ret = '';
         if ($allCatOption) {
             $ret .= "<option value='0'";
-            $ret .= '>' . _MB_PUBLISHER_ALLCAT . "</option>\n";
+            $ret .= '>'._MB_PUBLISHER_ALLCAT."</option>\n";
         }
 
         // Creating category objects
@@ -647,12 +647,12 @@ 
     public static function renderErrors(&$err_arr, $reseturl = ''): void
     {
         if (\is_array($err_arr) && \count($err_arr) > 0) {
-            echo '<div id="readOnly" class="errorMsg" style="border:1px solid #D24D00; background:#FEFECC url(' . \PUBLISHER_URL . '/images/important-32.png) no-repeat 7px 50%;color:#333;padding-left:45px;">';
+            echo '<div id="readOnly" class="errorMsg" style="border:1px solid #D24D00; background:#FEFECC url('.\PUBLISHER_URL.'/images/important-32.png) no-repeat 7px 50%;color:#333;padding-left:45px;">';
 
-            echo '<h4 style="text-align:left;margin:0; padding-top:0">' . _AM_PUBLISHER_MSG_SUBMISSION_ERR;
+            echo '<h4 style="text-align:left;margin:0; padding-top:0">'._AM_PUBLISHER_MSG_SUBMISSION_ERR;
 
             if ($reseturl) {
-                echo ' <a href="' . $reseturl . '">[' . _AM_PUBLISHER_TEXT_SESSION_RESET . ']</a>';
+                echo ' <a href="'.$reseturl.'">['._AM_PUBLISHER_TEXT_SESSION_RESET.']</a>';
             }
 
             echo '</h4><ul>';
@@ -660,10 +660,10 @@ 
             foreach ($err_arr as $key => $error) {
                 if (\is_array($error)) {
                     foreach ($error as $err) {
-                        echo '<li><a href="#' . $key . '" onclick="var e = xoopsGetElementById(\'' . $key . '\'); e.focus();">' . \htmlspecialchars($err) . '</a></li>';
+                        echo '<li><a href="#'.$key.'" onclick="var e = xoopsGetElementById(\''.$key.'\'); e.focus();">'.\htmlspecialchars($err).'</a></li>';
                     }
                 } else {
-                    echo '<li><a href="#' . $key . '" onclick="var e = xoopsGetElementById(\'' . $key . '\'); e.focus();">' . \htmlspecialchars($error) . '</a></li>';
+                    echo '<li><a href="#'.$key.'" onclick="var e = xoopsGetElementById(\''.$key.'\'); e.focus();">'.\htmlspecialchars($error).'</a></li>';
                 }
             }
             echo '</ul></div><br>';
@@ -691,11 +691,11 @@ 
 
         $qs = '';
         foreach ($vars as $key => $value) {
-            $qs .= $joinStr . $key . '=' . $value;
+            $qs .= $joinStr.$key.'='.$value;
             $joinStr = $amp;
         }
 
-        return $page . '?' . $qs;
+        return $page.'?'.$qs;
     }
 
     /**
@@ -709,7 +709,7 @@ 
         }
         $target_uri = $xoops->url($_SERVER['REQUEST_URI']);
 
-        return $xoops->url('modules/tellafriend/index.php?target_uri=' . \rawurlencode($target_uri) . '&amp;subject=' . \rawurlencode($subject));
+        return $xoops->url('modules/tellafriend/index.php?target_uri='.\rawurlencode($target_uri).'&amp;subject='.\rawurlencode($subject));
     }
 
     /**
@@ -757,7 +757,7 @@ 
 
                 $message = \sprintf(_CO_PUBLISHER_MESSAGE_FILE_ERROR, $errorstxt);
                 if ($withRedirect) {
-                    $xoops->redirect('file.php?op=mod&itemid=' . $itemid, 5, $message);
+                    $xoops->redirect('file.php?op=mod&itemid='.$itemid, 5, $message);
                 } else {
                     return $message;
                 }
@@ -767,15 +767,15 @@ 
         // Storing the file
         if (!$fileObj->store($allowed_mimetypes)) {
             if ($withRedirect) {
-                $xoops->redirect('file.php?op=mod&itemid=' . $fileObj->getVar('itemid'), 3, _CO_PUBLISHER_FILEUPLOAD_ERROR . self::formatErrors($fileObj->getErrors()));
+                $xoops->redirect('file.php?op=mod&itemid='.$fileObj->getVar('itemid'), 3, _CO_PUBLISHER_FILEUPLOAD_ERROR.self::formatErrors($fileObj->getErrors()));
             } else {
-                return _CO_PUBLISHER_FILEUPLOAD_ERROR . self::formatErrors($fileObj->getErrors());
+                return _CO_PUBLISHER_FILEUPLOAD_ERROR.self::formatErrors($fileObj->getErrors());
             }
         }
 
         if ($withRedirect) {
             $redirect_page = $another ? 'file.php' : 'item.php';
-            $xoops->redirect($redirect_page . '?op=mod&itemid=' . $fileObj->getVar('itemid'), 2, _CO_PUBLISHER_FILEUPLOAD_SUCCESS);
+            $xoops->redirect($redirect_page.'?op=mod&itemid='.$fileObj->getVar('itemid'), 2, _CO_PUBLISHER_FILEUPLOAD_SUCCESS);
         }
 
         return true;
@@ -783,7 +783,7 @@ 
 
     public static function newFeatureTag(): string
     {
-        $ret = '<span style="padding-right: 4px; font-weight: bold; color: #ff0000;">' . _CO_PUBLISHER_NEW_FEATURE . '</span>';
+        $ret = '<span style="padding-right: 4px; font-weight: bold; color: #ff0000;">'._CO_PUBLISHER_NEW_FEATURE.'</span>';
 
         return $ret;
     }
@@ -826,7 +826,7 @@ 
                 $string = self::closeTags($string);
             }
 
-            return $string . $etc;
+            return $string.$etc;
         }
 
         return $string;
@@ -862,7 +862,7 @@ 
 
             $complete_tags = \array_reverse($complete_tags);
             foreach ($complete_tags as $iValue) {
-                $string .= '</' . $iValue . '>';
+                $string .= '</'.$iValue.'>';
             }
         }
 
@@ -911,27 +911,27 @@ 
 
         if (!$gpermHandler->checkRight('global', \_PUBLISHER_RATE, $groups, $helper->getModule()->getVar('mid'))) {
             $static_rater = [];
-            $static_rater[] .= "\n" . '<div class="publisher_ratingblock">';
-            $static_rater[] .= '<div id="unit_long' . $itemid . '">';
-            $static_rater[] .= '<div id="unit_ul' . $itemid . '" class="publisher_unit-rating" style="width:' . $rating_unitwidth * $units . 'px;">';
-            $static_rater[] .= '<div class="publisher_current-rating" style="width:' . $rating_width . 'px;">' . _MD_PUBLISHER_VOTE_RATING . ' ' . $rating2 . '/' . $units . '</div>';
+            $static_rater[] .= "\n".'<div class="publisher_ratingblock">';
+            $static_rater[] .= '<div id="unit_long'.$itemid.'">';
+            $static_rater[] .= '<div id="unit_ul'.$itemid.'" class="publisher_unit-rating" style="width:'.$rating_unitwidth * $units.'px;">';
+            $static_rater[] .= '<div class="publisher_current-rating" style="width:'.$rating_width.'px;">'._MD_PUBLISHER_VOTE_RATING.' '.$rating2.'/'.$units.'</div>';
             $static_rater[] .= '</div>';
-            $static_rater[] .= '<div class="publisher_static">' . _MD_PUBLISHER_VOTE_RATING . ': <strong> ' . $rating1 . '</strong>/' . $units . ' (' . $count . ' ' . $tense . ') <br><em>' . _MD_PUBLISHER_VOTE_DISABLE . '</em></div>';
+            $static_rater[] .= '<div class="publisher_static">'._MD_PUBLISHER_VOTE_RATING.': <strong> '.$rating1.'</strong>/'.$units.' ('.$count.' '.$tense.') <br><em>'._MD_PUBLISHER_VOTE_DISABLE.'</em></div>';
             $static_rater[] .= '</div>';
-            $static_rater[] .= '</div>' . "\n\n";
+            $static_rater[] .= '</div>'."\n\n";
 
             return \implode("\n", $static_rater);
         }
 
         $rater = '';
         $rater .= '<div class="publisher_ratingblock">';
-        $rater .= '<div id="unit_long' . $itemid . '">';
-        $rater .= '<div id="unit_ul' . $itemid . '" class="publisher_unit-rating" style="width:' . $rating_unitwidth * $units . 'px;">';
-        $rater .= '<div class="publisher_current-rating" style="width:' . $rating_width . 'px;">' . _MD_PUBLISHER_VOTE_RATING . ' ' . $rating2 . '/' . $units . '</div>';
+        $rater .= '<div id="unit_long'.$itemid.'">';
+        $rater .= '<div id="unit_ul'.$itemid.'" class="publisher_unit-rating" style="width:'.$rating_unitwidth * $units.'px;">';
+        $rater .= '<div class="publisher_current-rating" style="width:'.$rating_width.'px;">'._MD_PUBLISHER_VOTE_RATING.' '.$rating2.'/'.$units.'</div>';
 
         for ($ncount = 1; $ncount <= $units; ++$ncount) { // loop from 1 to the number of units
             if (!$voted) { // if the user hasn't yet voted, draw the voting stars
-                $rater .= '<div><a href="' . \PUBLISHER_URL . '/rate.php?itemid=' . $itemid . '&amp;rating=' . $ncount . '" title="' . $ncount . ' ' . _MD_PUBLISHER_VOTE_OUTOF . ' ' . $units . '" class="publisher_r' . $ncount . '-unit rater" rel="nofollow">' . $ncount . '</a></div>';
+                $rater .= '<div><a href="'.\PUBLISHER_URL.'/rate.php?itemid='.$itemid.'&amp;rating='.$ncount.'" title="'.$ncount.' '._MD_PUBLISHER_VOTE_OUTOF.' '.$units.'" class="publisher_r'.$ncount.'-unit rater" rel="nofollow">'.$ncount.'</a></div>';
             }
         }
 
@@ -942,7 +942,7 @@ 
             $rater .= ' class="publisher_voted"';
         }
 
-        $rater .= '>' . _MD_PUBLISHER_VOTE_RATING . ': <strong> ' . $rating1 . '</strong>/' . $units . ' (' . $count . ' ' . $tense . ')';
+        $rater .= '>'._MD_PUBLISHER_VOTE_RATING.': <strong> '.$rating1.'</strong>/'.$units.' ('.$count.' '.$tense.')';
         $rater .= '  </div>';
         $rater .= '</div>';
         $rater .= '</div>';
@@ -1152,12 +1152,12 @@ 
         $helper = Helper::getInstance();
         if ('none' !== $helper->getConfig('seo_url_rewrite')) {
             if (!empty($short_url)) {
-                $short_url = $short_url . '.html';
+                $short_url = $short_url.'.html';
             }
 
             if ('htaccess' === $helper->getConfig('seo_url_rewrite')) {
                 // generate SEO url using htaccess
-                return XoopsBaseConfig::get('url') . '/' . $helper->getConfig('seo_module_name') . ".${op}.${id}/${short_url}";
+                return XoopsBaseConfig::get('url').'/'.$helper->getConfig('seo_module_name').".${op}.${id}/${short_url}";
             }
 
             if ('path-info' === $helper->getConfig('seo_url_rewrite')) {

htdocs/modules/publisher/src/FileHandler.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
  * @author          The SmartFactory <www.smartfactory.ca>
  * @version         $Id$
  */
-require_once \dirname(__DIR__) . '/include/common.php';
+require_once \dirname(__DIR__).'/include/common.php';
 
 // File status
 \define('_PUBLISHER_STATUS_FILE_NOTSET', -1);

htdocs/modules/publisher/src/formdatetime.php

Spacing +4 added lines, -4 removed lines

@@ -26,7 +26,7 @@ 
  * @author          trabis <lusopoemas@gmail.com>
  * @version         $Id$
  */
-require_once \dirname(__DIR__) . '/include/common.php';
+require_once \dirname(__DIR__).'/include/common.php';
 
 /**
  * Class FormDateTime
@@ -48,16 +48,16 @@ 
         $value = (int)$value;
         $value = ($value > 0) ? $value : \time();
         $datetime = \getdate($value);
-        $this->addElement(new DateSelect('', $name . '[date]', $value));
+        $this->addElement(new DateSelect('', $name.'[date]', $value));
         $timearray = [];
         for ($i = 0; $i < 24; ++$i) {
             for ($j = 0; $j < 60; $j = $j + 10) {
                 $key = ($i * 3600) + ($j * 60);
-                $timearray[$key] = (0 != $j) ? $i . ':' . $j : $i . ':0' . $j;
+                $timearray[$key] = (0 != $j) ? $i.':'.$j : $i.':0'.$j;
             }
         }
         \ksort($timearray);
-        $timeselect = new Select('', $name . '[time]', $datetime['hours'] * 3600 + 600 * \floor($datetime['minutes'] / 10));
+        $timeselect = new Select('', $name.'[time]', $datetime['hours'] * 3600 + 600 * \floor($datetime['minutes'] / 10));
         $timeselect->addOptionArray($timearray);
         $this->addElement($timeselect);
     }