publisher_items_recent_show()

Complexity

Conditions	5
Paths	8

Size

Total Lines	53
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function publisher_items_recent_show($options)
{
    $helper = Helper::getInstance();
    $myts   = Sanitizer::getInstance();

    $block = [];

    $selectedcatids = explode(',', $options[0]);

    if (in_array(0, $selectedcatids)) {
        $allcats = true;
    } else {
        $allcats = false;
    }

    $sort  = $options[1];
    $order = Publisher\Utils::getOrderBy($sort);
    $limit = $options[2];
    $start = 0;

    // creating the ITEM objects that belong to the selected category
    if ($allcats) {
        $criteria = null;
    } else {
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('categoryid', '(' . $options[0] . ')', 'IN'));
    }
    $itemsObj = $helper->getItemHandler()->getItems($limit, $start, [_PUBLISHER_STATUS_PUBLISHED], -1, $sort, $order, '', true, $criteria, true);

true of type true is incompatible with the type string expected by parameter $id_key of XoopsModules\Publisher\ItemHandler::getItems().

It seems like $criteria can also be of type CriteriaCompo; however, parameter $otherCriteria of XoopsModules\Publisher\ItemHandler::getItems() does only seem to accept null, maybe add an additional type check?

array(_PUBLISHER_STATUS_PUBLISHED) of type array<integer,integer> is incompatible with the type string expected by parameter $status of XoopsModules\Publisher\ItemHandler::getItems().

    if ($itemsObj) {
        foreach ($itemsObj as $iValue) {

            $newItems['itemid']       = $iValue->getVar('itemid');
            $newItems['title']        = $iValue->title();
            $newItems['categoryname'] = $iValue->getCategoryName();
            $newItems['categoryid']   = $iValue->getVar('categoryid');
            $newItems['date']         = $iValue->datesub();
            $newItems['poster']       = $iValue->linkedPosterName();
            $newItems['itemlink']     = $iValue->getItemLink(false, $options[3] ?? 65);
            $newItems['categorylink'] = $iValue->getCategoryLink();

            $block['items'][] = $newItems;

The variable $newItems seems to be defined later in this foreach loop on line 69. Are you sure it is defined here?

        }

        $block['lang_title']     = _MB_PUBLISHER_ITEMS;
        $block['lang_category']  = _MB_PUBLISHER_CATEGORY;
        $block['lang_poster']    = _MB_PUBLISHER_POSTEDBY;
        $block['lang_date']      = _MB_PUBLISHER_DATE;
        $modulename              = $myts->displayTarea($helper->getModule()->getVar('name'));

It seems like $helper->getModule()->getVar('name') can also be of type string[]; however, parameter $text of Xoops\Core\Text\Sanitizer::displayTarea() does only seem to accept string, maybe add an additional type check?

        $block['lang_visitItem'] = _MB_PUBLISHER_VISITITEM . ' ' . $modulename;
    }

    return $block;
}