Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Logger often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Logger, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
45 | class Logger implements LoggerInterface |
||
46 | { |
||
47 | /** |
||
48 | * @var LoggerInterface[] chain of PSR-3 compatible loggers to call |
||
49 | */ |
||
50 | private $loggers = array(); |
||
51 | |||
52 | /** |
||
53 | * @var boolean do we have active loggers? |
||
54 | */ |
||
55 | private $logging_active = false; |
||
56 | |||
57 | /** |
||
58 | * @var boolean just to prevent fatal legacy errors. Does nothing. Stop it! |
||
59 | */ |
||
60 | //public $activated = false; |
||
61 | |||
62 | /** |
||
63 | * Get the Xoops\Core\Logger instance |
||
64 | * |
||
65 | * @return Logger object |
||
66 | */ |
||
67 | 18 | public static function getInstance() |
|
68 | { |
||
69 | 18 | static $instance; |
|
70 | 18 | if (!isset($instance)) { |
|
71 | $class = __CLASS__; |
||
72 | $instance = new $class(); |
||
73 | // Always catch errors, for security reasons |
||
74 | set_error_handler(array($instance, 'handleError')); |
||
75 | // grab any uncaught exception |
||
76 | set_exception_handler(array($instance, 'handleException')); |
||
77 | } |
||
78 | |||
79 | 18 | return $instance; |
|
80 | } |
||
81 | |||
82 | /** |
||
83 | * Error handling callback. |
||
84 | * |
||
85 | * This will |
||
86 | * |
||
87 | * @param integer $errorNumber error number |
||
88 | * @param string $errorString error message |
||
89 | * @param string $errorFile file |
||
90 | * @param integer $errorLine line number |
||
91 | * |
||
92 | * @return void |
||
93 | */ |
||
94 | 53 | public function handleError($errorNumber, $errorString, $errorFile, $errorLine) |
|
95 | { |
||
96 | 53 | if ($this->logging_active && ($errorNumber & error_reporting())) { |
|
97 | |||
98 | // if an error occurs before a locale is established, |
||
99 | // we still need messages, so check and deal with it |
||
100 | |||
101 | 5 | $msg = ': ' . sprintf( |
|
102 | 5 | (class_exists('\XoopsLocale', false) ? \XoopsLocale::EF_LOGGER_FILELINE : "%s in file %s line %s"), |
|
103 | 5 | $this->sanitizePath($errorString), |
|
104 | 5 | $this->sanitizePath($errorFile), |
|
105 | $errorLine |
||
106 | 5 | ); |
|
107 | |||
108 | switch ($errorNumber) { |
||
109 | 5 | View Code Duplication | case E_USER_NOTICE: |
110 | 1 | $msg = (class_exists('\XoopsLocale', false) ? \XoopsLocale::E_LOGGER_ERROR : '*Error:') . $msg; |
|
111 | 1 | $this->log(LogLevel::NOTICE, $msg); |
|
112 | 1 | break; |
|
113 | 4 | View Code Duplication | case E_NOTICE: |
114 | 1 | $msg = (class_exists('\XoopsLocale', false) ? \XoopsLocale::E_LOGGER_NOTICE : '*Notice:') . $msg; |
|
115 | 1 | $this->log(LogLevel::NOTICE, $msg); |
|
116 | 1 | break; |
|
117 | 3 | View Code Duplication | case E_WARNING: |
118 | 1 | $msg = (class_exists('\XoopsLocale', false) ? \XoopsLocale::E_LOGGER_WARNING : '*Warning:') . $msg; |
|
119 | 1 | $this->log(LogLevel::WARNING, $msg); |
|
120 | 1 | break; |
|
121 | 2 | View Code Duplication | case E_STRICT: |
122 | 1 | $msg = (class_exists('\XoopsLocale', false) ? \XoopsLocale::E_LOGGER_STRICT : '*Strict:') . $msg; |
|
123 | 1 | $this->log(LogLevel::WARNING, $msg); |
|
124 | 1 | break; |
|
125 | 1 | View Code Duplication | case E_USER_ERROR: |
126 | $msg = (class_exists('\XoopsLocale', false) ? \XoopsLocale::E_LOGGER_ERROR : '*Error:') . $msg; |
||
127 | @$this->log(LogLevel::CRITICAL, $msg); |
||
|
|||
128 | break; |
||
129 | 1 | View Code Duplication | default: |
130 | 1 | $msg = (class_exists('\XoopsLocale', false) ? \XoopsLocale::E_LOGGER_UNKNOWN : '*Unknown:') . $msg; |
|
131 | 1 | $this->log(LogLevel::ERROR, $msg); |
|
132 | 1 | break; |
|
133 | 1 | } |
|
134 | 5 | } |
|
135 | |||
136 | 53 | if ($errorNumber == E_USER_ERROR) { |
|
137 | $trace = true; |
||
138 | if (substr($errorString, 0, '8') === 'notrace:') { |
||
139 | $trace = false; |
||
140 | $errorString = substr($errorString, 8); |
||
141 | } |
||
142 | $this->reportFatalError($errorString); |
||
143 | if ($trace) { |
||
144 | $trace = debug_backtrace(); |
||
145 | array_shift($trace); |
||
146 | if ('cli' === php_sapi_name()) { |
||
147 | foreach ($trace as $step) { |
||
148 | if (isset($step['file'])) { |
||
149 | fprintf(STDERR, "%s (%d)\n", $this->sanitizePath($step['file']), $step['line']); |
||
150 | } |
||
151 | } |
||
152 | } else { |
||
153 | echo "<div style='color:#f0f0f0;background-color:#f0f0f0'>" . _XOOPS_FATAL_BACKTRACE . ":<br />"; |
||
154 | foreach ($trace as $step) { |
||
155 | if (isset($step['file'])) { |
||
156 | printf("%s (%d)\n<br />", $this->sanitizePath($step['file']), $step['line']); |
||
157 | } |
||
158 | } |
||
159 | echo '</div>'; |
||
160 | } |
||
161 | } |
||
162 | exit(); |
||
163 | } |
||
164 | 53 | } |
|
165 | |||
166 | /** |
||
167 | * Exception handling callback. |
||
168 | * |
||
169 | * This will |
||
170 | * |
||
171 | * @param \Exception|\Throwable $e uncaught Exception or Error |
||
172 | * |
||
173 | * @return void |
||
174 | */ |
||
175 | public function handleException($e) |
||
176 | { |
||
177 | $msg = $e->getMessage(); |
||
178 | $this->reportFatalError($msg); |
||
179 | } |
||
180 | |||
181 | /** |
||
182 | * Announce fatal error, attempt to log |
||
183 | * |
||
184 | * @param string $msg error message to report |
||
185 | * |
||
186 | * @return void |
||
187 | */ |
||
188 | private function reportFatalError($msg) |
||
189 | { |
||
190 | $msg=$this->sanitizePath($msg); |
||
191 | if ('cli' === php_sapi_name()) { |
||
192 | fprintf(STDERR, "\nError : %s\n", $msg); |
||
193 | } else { |
||
194 | printf(_XOOPS_FATAL_MESSAGE, XOOPS_URL, $msg); |
||
195 | } |
||
196 | @$this->log(LogLevel::CRITICAL, $msg); |
||
197 | } |
||
198 | |||
199 | /** |
||
200 | * clean a path to remove sensitive details |
||
201 | * |
||
202 | * @param string $message text to sanitize |
||
203 | * |
||
204 | * @return string sanitized message |
||
205 | */ |
||
206 | 21 | public function sanitizePath($message) |
|
207 | { |
||
208 | $cleaners = [ |
||
209 | 21 | ['\\', '/',], |
|
210 | 21 | [\XoopsBaseConfig::get('var-path'), 'VAR',], |
|
211 | 21 | [str_replace('\\', '/', realpath(\XoopsBaseConfig::get('var-path'))), 'VAR',], |
|
212 | 21 | [\XoopsBaseConfig::get('lib-path'), 'LIB',], |
|
213 | 21 | [str_replace('\\', '/', realpath(\XoopsBaseConfig::get('lib-path'))), 'LIB',], |
|
214 | 21 | [\XoopsBaseConfig::get('root-path'), 'ROOT',], |
|
215 | 21 | [str_replace('\\', '/', realpath(\XoopsBaseConfig::get('root-path'))), 'ROOT',], |
|
216 | 21 | [\XoopsBaseConfig::get('db-name') . '.', '',], |
|
217 | 21 | [\XoopsBaseConfig::get('db-name'), '',], |
|
218 | 21 | [\XoopsBaseConfig::get('db-prefix') . '_', '',], |
|
219 | 21 | [\XoopsBaseConfig::get('db-user'), '***',], |
|
220 | 21 | [\XoopsBaseConfig::get('db-pass'), '***',], |
|
221 | 21 | ]; |
|
222 | 21 | $stringsToClean = array_column($cleaners, 0); |
|
223 | 21 | $replacementStings = array_column($cleaners, 1); |
|
224 | |||
225 | 21 | $message = str_replace($stringsToClean, $replacementStings, $message); |
|
226 | |||
227 | 21 | return $message; |
|
228 | } |
||
229 | |||
230 | /** |
||
231 | * add a PSR-3 compatible logger to the chain |
||
232 | * |
||
233 | * @param object $logger a PSR-3 compatible logger object |
||
234 | * |
||
235 | * @return void |
||
236 | */ |
||
237 | 22 | public function addLogger($logger) |
|
238 | { |
||
239 | 22 | if (is_object($logger) && method_exists($logger, 'log')) { |
|
240 | 22 | $this->loggers[] = $logger; |
|
241 | 22 | $this->logging_active = true; |
|
242 | 22 | } |
|
243 | 22 | } |
|
244 | |||
245 | /** |
||
246 | * System is unusable. |
||
247 | * |
||
248 | * @param string $message message |
||
249 | * @param array $context array of context data for this log entry |
||
250 | * |
||
251 | * @return void |
||
252 | */ |
||
253 | 1 | public function emergency($message, array $context = array()) |
|
257 | |||
258 | /** |
||
259 | * Action must be taken immediately. |
||
260 | * |
||
261 | * Example: Entire website down, database unavailable, etc. This should |
||
262 | * trigger the SMS alerts and wake you up. |
||
263 | * |
||
264 | * @param string $message message |
||
265 | * @param array $context array of context data for this log entry |
||
266 | * |
||
267 | * @return void |
||
268 | */ |
||
269 | 1 | public function alert($message, array $context = array()) |
|
273 | |||
274 | /** |
||
275 | * Critical conditions. |
||
276 | * |
||
277 | * Example: Application component unavailable, unexpected exception. |
||
278 | * |
||
279 | * @param string $message message |
||
280 | * @param array $context array of context data for this log entry |
||
281 | * |
||
282 | * @return void |
||
283 | */ |
||
284 | 1 | public function critical($message, array $context = array()) |
|
288 | |||
289 | /** |
||
290 | * Runtime errors that do not require immediate action but should typically |
||
291 | * be logged and monitored. |
||
292 | * |
||
293 | * @param string $message message |
||
294 | * @param array $context array of context data for this log entry |
||
295 | * |
||
296 | * @return void |
||
297 | */ |
||
298 | 1 | public function error($message, array $context = array()) |
|
302 | |||
303 | /** |
||
304 | * Exceptional occurrences that are not errors. |
||
305 | * |
||
306 | * Example: Use of deprecated APIs, poor use of an API, undesirable things |
||
307 | * that are not necessarily wrong. |
||
308 | * |
||
309 | * @param string $message message |
||
310 | * @param array $context array of context data for this log entry |
||
311 | * |
||
312 | * @return void |
||
313 | */ |
||
314 | 1 | public function warning($message, array $context = array()) |
|
318 | |||
319 | /** |
||
320 | * Normal but significant events. |
||
321 | * |
||
322 | * @param string $message message |
||
323 | * @param array $context array of context data for this log entry |
||
324 | * |
||
325 | * @return void |
||
326 | */ |
||
327 | 1 | public function notice($message, array $context = array()) |
|
331 | |||
332 | /** |
||
333 | * Interesting events. |
||
334 | * |
||
335 | * Example: User logs in, SQL logs. |
||
336 | * |
||
337 | * @param string $message message |
||
338 | * @param array $context array of context data for this log entry |
||
339 | * |
||
340 | * @return void |
||
341 | */ |
||
342 | 1 | public function info($message, array $context = array()) |
|
346 | |||
347 | /** |
||
348 | * Detailed debug information. |
||
349 | * |
||
350 | * @param string $message message |
||
351 | * @param array $context array of context data for this log entry |
||
352 | * |
||
353 | * @return void |
||
354 | */ |
||
355 | 1 | public function debug($message, array $context = array()) |
|
359 | |||
360 | /** |
||
361 | * Logs with an arbitrary level. |
||
362 | * |
||
363 | * @param mixed $level PSR-3 LogLevel constant |
||
364 | * @param string $message message |
||
365 | * @param array $context array of context data for this log entry |
||
366 | * |
||
367 | * @return void |
||
368 | */ |
||
369 | 14 | public function log($level, $message, array $context = array()) |
|
370 | { |
||
371 | 14 | if (!empty($this->loggers)) { |
|
372 | 13 | foreach ($this->loggers as $logger) { |
|
373 | 13 | if (is_object($logger)) { |
|
374 | try { |
||
375 | 13 | $logger->log($level, $message, $context); |
|
376 | 13 | } catch (\Exception $e) { |
|
377 | // just ignore, as we can't do anything, not even log it. |
||
378 | } |
||
379 | 13 | } |
|
380 | 13 | } |
|
381 | 13 | } |
|
382 | 14 | } |
|
383 | |||
384 | /** |
||
385 | * quiet - turn off output if output is rendered in XOOPS page output. |
||
386 | * This is intended to assist ajax code that may fail with any extra |
||
387 | * content the logger may introduce. |
||
388 | * |
||
389 | * It should have no effect on loggers using other methods, such a write |
||
390 | * to file. |
||
391 | * |
||
392 | * @return void |
||
393 | */ |
||
394 | 2 | public function quiet() |
|
395 | { |
||
396 | 2 | if (!empty($this->loggers)) { |
|
397 | 2 | foreach ($this->loggers as $logger) { |
|
398 | 2 | if (is_object($logger) && method_exists($logger, 'quiet')) { |
|
399 | try { |
||
400 | 2 | $logger->quiet(); |
|
401 | 2 | } catch (\Exception $e) { |
|
402 | // just ignore, as we can't do anything, not even log it. |
||
403 | } |
||
404 | 2 | } |
|
405 | 2 | } |
|
406 | 2 | } |
|
407 | 2 | } |
|
408 | |||
409 | // Deprecated uses |
||
410 | |||
411 | /** |
||
412 | * Keep deprecated calls from failing |
||
413 | * |
||
414 | * @param string $var property |
||
415 | * @param string $val value |
||
416 | * |
||
417 | * @return void |
||
418 | * |
||
419 | * @deprecated |
||
420 | */ |
||
421 | public function __set($var, $val) |
||
422 | { |
||
423 | $this->deprecatedMessage(); |
||
424 | // legacy compatibility: turn off logger display for $xoopsLogger->activated = false; usage |
||
425 | if ($var==='activated' && !$val) { |
||
426 | $this->quiet(); |
||
427 | } |
||
428 | |||
429 | } |
||
430 | |||
431 | /** |
||
432 | * Keep deprecated calls from failing |
||
433 | * |
||
434 | * @param string $var property |
||
435 | * |
||
436 | * @return void |
||
437 | * |
||
438 | * @deprecated |
||
439 | */ |
||
440 | public function __get($var) |
||
441 | { |
||
442 | $this->deprecatedMessage(); |
||
443 | } |
||
444 | |||
445 | /** |
||
446 | * Keep deprecated calls from failing |
||
447 | * |
||
448 | * @param string $method method |
||
449 | * @param string $args arguments |
||
450 | * |
||
451 | * @return void |
||
452 | * |
||
453 | * @deprecated |
||
454 | */ |
||
455 | public function __call($method, $args) |
||
456 | { |
||
457 | $this->deprecatedMessage(); |
||
458 | } |
||
459 | |||
460 | /** |
||
461 | * issue a deprecated warning |
||
462 | * |
||
463 | * @return void |
||
464 | */ |
||
465 | 3 | private function deprecatedMessage() |
|
470 | } |
||
471 |
If you suppress an error, we recommend checking for the error condition explicitly: