PublisherItemHandler::getAllRejected() - Code Metrics - Inspection of "Merge pull request #557 from harupu/dev" - XOOPS/XoopsCore - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( fc2c42...d0941c )

by Richard
created 2017-10-04 20:58 UTC
PublisherItemHandler::getAllRejected() A

↳ Parent: PublisherItemHandler
Complexity

Conditions	1
Paths	1
Size

Total Lines	4
Code Lines	2
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	2
nc	1
nop	8
dl	0
loc	4
rs	10
c	0
b	0
f	0
How to fix Many Parameters

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

use Xoops\Core\Database\Connection;
use Xoops\Core\Kernel\XoopsObject;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Xoops\Core\Kernel\XoopsPersistableObjectHandler;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Xoops\Core\Kernel\Criteria;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Xoops\Core\Kernel\CriteriaCompo;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Xmf\Request;

/**
 * @copyright       The XUUPS Project http://sourceforge.net/projects/xuups/
 * @license         GNU GPL V2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @package         Publisher
 * @since           1.0
 * @author          trabis <[email protected]>
 * @author          The SmartFactory <www.smartfactory.ca>
 * @version         $Id$
 */

include_once dirname(__DIR__) . '/include/common.php';

class PublisherItem extends XoopsObject
{
    /**
     * @var Publisher
     * @access public
     */
    public $publisher = null;

    /**
     * @var PublisherCategory
     * @access public
     */
    public $_category = null;

    /**
     * @param int|null $id
     */
    public function __construct($id = null)
    {
        $this->publisher = Publisher::getInstance();
        $this->initVar("itemid", XOBJ_DTYPE_INT, 0);
        $this->initVar("categoryid", XOBJ_DTYPE_INT, 0, false);
        $this->initVar("title", XOBJ_DTYPE_TXTBOX, '', true, 255);
        $this->initVar("subtitle", XOBJ_DTYPE_TXTBOX, '', false, 255);
        $this->initVar("summary", XOBJ_DTYPE_TXTAREA, '', false);
        $this->initVar("body", XOBJ_DTYPE_TXTAREA, '', false);
        $this->initVar("uid", XOBJ_DTYPE_INT, 0, false);
        $this->initVar("author_alias", XOBJ_DTYPE_TXTBOX, '', false, 255);
        $this->initVar("datesub", XOBJ_DTYPE_INT, '', false);
        $this->initVar("status", XOBJ_DTYPE_INT, -1, false);
        $this->initVar("image", XOBJ_DTYPE_INT, 0, false);
        $this->initVar("images", XOBJ_DTYPE_TXTBOX, '', false, 255);
        $this->initVar("counter", XOBJ_DTYPE_INT, 0, false);
        $this->initVar("rating", XOBJ_DTYPE_OTHER, 0, false);
        $this->initVar("votes", XOBJ_DTYPE_INT, 0, false);
        $this->initVar("weight", XOBJ_DTYPE_INT, 0, false);
        $this->initVar("dohtml", XOBJ_DTYPE_INT, 1, true);
        $this->initVar("dosmiley", XOBJ_DTYPE_INT, 1, true);
        $this->initVar("doimage", XOBJ_DTYPE_INT, 1, true);
        $this->initVar("dobr", XOBJ_DTYPE_INT, 1, false);
        $this->initVar("doxcode", XOBJ_DTYPE_INT, 1, true);
        $this->initVar("cancomment", XOBJ_DTYPE_INT, 1, true);
        $this->initVar("comments", XOBJ_DTYPE_INT, 0, false);
        $this->initVar("notifypub", XOBJ_DTYPE_INT, 1, false);
        $this->initVar("meta_keywords", XOBJ_DTYPE_TXTAREA, '', false);
        $this->initVar("meta_description", XOBJ_DTYPE_TXTAREA, '', false);
        $this->initVar("short_url", XOBJ_DTYPE_TXTBOX, '', false, 255);
        $this->initVar("item_tag", XOBJ_DTYPE_TXTAREA, '', false);
        // Non consistent values
        $this->initVar("pagescount", XOBJ_DTYPE_INT, 0, false);
        if (isset($id)) {
            $item = $this->publisher->getItemHandler()->get($id);
            foreach ($item->vars as $k => $v) {
                $this->assignVar($k, $v['value']);
            }
        }
    }

    /**
     * @return null|PublisherCategory
     */
    public function category()
    {
        if (!isset($this->_category)) {
            $this->_category = $this->publisher->getCategoryHandler()->get($this->getVar('categoryid'));
        }
        return $this->_category;
    }

    /**
     * @param int    $maxLength
     * @param string $format
     *
     * @return string
     */
    public function title($maxLength = 0, $format = "S")
    {
        $ret = $this->getVar("title", $format);
        if ($maxLength != 0) {
            if (!XoopsLocale::isMultiByte()) {

                if (strlen($ret) >= $maxLength) {
                    $ret = PublisherUtils::substr($ret, 0, $maxLength);
                }
            }
        }
        return $ret;
    }

    /**
     * @param int    $maxLength
     * @param string $format
     *
     * @return mixed|string
     */
    public function subtitle($maxLength = 0, $format = "S")
    {
        $ret = $this->getVar("subtitle", $format);
        if ($maxLength != 0) {
            if (!XoopsLocale::isMultiByte()) {

                if (strlen($ret) >= $maxLength) {
                    $ret = PublisherUtils::substr($ret, 0, $maxLength);
                }
            }
        }
        return $ret;
    }

    /**
     * @param int    $maxLength
     * @param string $format
     * @param string $stripTags
     *
     * @return mixed|string
     */
    public function summary($maxLength = 0, $format = "S", $stripTags = '')
    {
        $ret = $this->getVar("summary", $format);
        if (!empty($stripTags)) {
            $ret = strip_tags($ret, $stripTags);
        }
        if ($maxLength != 0) {
            if (!XoopsLocale::isMultiByte()) {

                if (strlen($ret) >= $maxLength) {
                    //$ret = PublisherUtils::substr($ret , 0, $maxLength);
                    $ret = PublisherUtils::truncateTagSafe($ret, $maxLength, $etc = '...', $break_words = false);
                }
            }
        }
        return $ret;
    }

    /**
     * @param int  $maxLength
     * @param bool $fullSummary
     *
     * @return mixed|string
     */
    public function getBlockSummary($maxLength = 0, $fullSummary = false)
    {
        if ($fullSummary) {
            $ret = $this->summary(0, 's', '<br></ br>');
        } else {
            $ret = $this->summary($maxLength, 's', '<br></ br>');
        }
        //no summary? get body!
        if (strlen($ret) == 0) {
            $ret = $this->body($maxLength, 's', '<br></ br>');
        }
        return $ret;
    }

    /**
     * @param string $file_name
     *
     * @return string
     */
    public function wrappage($file_name)
    {
        $content = '';
        $page = PublisherUtils::getUploadDir(true, 'content') . $file_name;
        if (XoopsLoad::fileExists($page)) {
            // this page uses smarty template
            ob_start();
            include($page);
            $content = ob_get_contents();
            ob_end_clean();
            // Cleaning the content
            $body_start_pos = strpos($content, '<body>');
            if ($body_start_pos) {
                $body_end_pos = strpos($content, '</body>', $body_start_pos);
                $content = substr($content, $body_start_pos + strlen('<body>'), $body_end_pos - strlen('<body>') - $body_start_pos);
            }
            // Check if ML Hack is installed, and if yes, parse the $content in formatForML
            $myts = \Xoops\Core\Text\Sanitizer::getInstance();
            if (method_exists($myts, 'formatForML')) {
                $content = $myts->formatForML($content);

            }
        }
        return $content;
    }

    /**
     * This method returns the body to be displayed. Not to be used for editing
     *
     * @param int    $maxLength
     * @param string $format
     * @param string $stripTags
     *
     * @return mixed|string
     */
    public function body($maxLength = 0, $format = 'S', $stripTags = '')
    {
        $ret = $this->getVar('body', $format);
        $wrap_pos = strpos($ret, '[pagewrap=');
        if (!($wrap_pos === false)) {
            $wrap_pages = array();
            $wrap_code_length = strlen('[pagewrap=');
            while (!($wrap_pos === false)) {
                $end_wrap_pos = strpos($ret, ']', $wrap_pos);
                if ($end_wrap_pos) {
                    $wrap_page_name = substr($ret, $wrap_pos + $wrap_code_length, $end_wrap_pos - $wrap_code_length - $wrap_pos);
                    $wrap_pages[] = $wrap_page_name;
                }
                $wrap_pos = strpos($ret, '[pagewrap=', $end_wrap_pos - 1);
            }
            foreach ($wrap_pages as $page) {
                $wrap_page_content = $this->wrappage($page);
                $ret = str_replace("[pagewrap={$page}]", $wrap_page_content, $ret);
            }
        }
        if ($this->publisher->getConfig('item_disp_blocks_summary')) {
            $summary = $this->summary($maxLength, $format, $stripTags);
            if ($summary) {
                $ret = $this->summary() . '<br /><br />' . $ret;
            }
        }
        if (!empty($stripTags)) {
            $ret = strip_tags($ret, $stripTags);
        }
        if ($maxLength != 0) {
            if (!XoopsLocale::isMultiByte()) {

                if (strlen($ret) >= $maxLength) {
                    //$ret = PublisherUtils::substr($ret , 0, $maxLength);
                    $ret = PublisherUtils::truncateTagSafe($ret, $maxLength, $etc = '...', $break_words = false);
                }
            }
        }
        return $ret;
    }

    /**
     * @param string $dateFormat
     * @param string $format
     *
     * @return string
     */
    public function datesub($dateFormat = '', $format = 'S')
    {
        if (empty($dateformat)) {

            $dateFormat = $this->publisher->getConfig('format_date');
        }
        return XoopsLocale::formatTimestamp($this->getVar('datesub', $format), $dateFormat);
    }

    /**
     * @param int $realName
     *
     * @return string
     */
    public function posterName($realName = -1)
    {
        if ($realName == -1) {
            $realName = $this->publisher->getConfig('format_realname');
        }
        $ret = $this->getVar('author_alias');
        if ($ret == '') {
            $ret = XoopsUserUtility::getUnameFromId($this->getVar('uid'), $realName);
        }
        return $ret;
    }

    /**
     * @return string
     */
    public function posterAvatar()
    {
        $xoops = Xoops::getInstance();
        $ret = 'blank.gif';
        $member_handler = $xoops->getHandlerMember();
        $thisUser = $member_handler->getUser($this->getVar('uid'));
        if (is_object($thisUser)) {
            $ret = $xoops->service('avatar')->getAvatarUrl($thisUser)->getValue();
        }
        return $ret;
    }

    /**
     * @return string
     */
    public function linkedPosterName()
    {
        $ret = $this->getVar('author_alias');
        if ($ret == '') {
            $ret = XoopsUserUtility::getUnameFromId($this->getVar('uid'), $this->publisher->getConfig('format_realname'), true);
        }
        return $ret;
    }

    /**
     * @return mixed
     */
    public function updateCounter()
    {
        return $this->publisher->getItemHandler()->updateCounter($this->getVar('itemid'));
    }

    /**
     * @param bool $force
     *
     * @return bool
     */
    public function store($force = true)
    {
        $xoops = Xoops::getInstance();
        $isNew = $this->isNew();
        if (!$this->publisher->getItemHandler()->insert($this, $force)) {
            return false;
        }
        if ($isNew && $this->getVar('status') == _PUBLISHER_STATUS_PUBLISHED) {
            // Increment user posts
            $user_handler = $xoops->getHandlerUser();
            $member_handler = $xoops->getHandlerMember();
            $poster = $user_handler->get($this->getVar('uid'));
            if (is_object($poster) && !$poster->isNew()) {
                $poster->setVar('posts', $poster->getVar('posts') + 1);
                if (!$member_handler->insertUser($poster, true)) {
                    $this->setErrors('Article created but could not increment user posts.');
                    return false;
                }
            }
        }
        return true;
    }

    /**
     * @return string
     */
    public function getCategoryName()
    {
        return $this->category()->getVar('name');
    }

    /**
     * @return string
     */
    public function getCategoryUrl()
    {
        return $this->category()->getCategoryUrl();
    }

    /**
     * @return string
     */
    public function getCategoryLink()
    {
        return $this->category()->getCategoryLink();
    }

    /**
     * @param bool $withAllLink
     *
     * @return string
     */
    public function getCategoryPath($withAllLink = true)
    {
        return $this->category()->getCategoryPath($withAllLink);
    }

    /**
     * @return string
     */
    public function getCategoryImagePath()
    {
        return PublisherUtils::getImageDir('category', false) . $this->category()->image();
    }

    /**
     * @return mixed
     */
    public function getFiles()
    {
        return $this->publisher->getFileHandler()->getAllFiles($this->getVar('itemid'), _PUBLISHER_STATUS_FILE_ACTIVE);
    }

    /**
     * @return string
     */
    public function getAdminLinks()
    {
        $xoops = Xoops::getInstance();
        $adminLinks = '';
        if ($xoops->isUser() && (PublisherUtils::IsUserAdmin() || PublisherUtils::IsUserAuthor($this) || $this->publisher->getPermissionHandler()->isGranted('item_submit', $this->getVar('categoryid')))) {
            if (PublisherUtils::IsUserAdmin() || PublisherUtils::IsUserAuthor($this) || PublisherUtils::IsUserModerator($this)) {
                if ($this->publisher->getConfig('perm_edit') || PublisherUtils::IsUserModerator($this) || PublisherUtils::IsUserAdmin()) {
                    // Edit button
                    $adminLinks .= "<a href='" . PUBLISHER_URL . "/submit.php?itemid=" . $this->getVar('itemid') . "'><img src='" . PUBLISHER_URL . "/images/links/edit.gif'" . " title='" . _CO_PUBLISHER_EDIT . "' alt='" . _CO_PUBLISHER_EDIT . "'/></a>";
                    $adminLinks .= " ";
                }
                if ($this->publisher->getConfig('perm_delete') || PublisherUtils::IsUserModerator($this) || PublisherUtils::IsUserAdmin()) {
                    // Delete button
                    $adminLinks .= "<a href='" . PUBLISHER_URL . "/submit.php?op=del&amp;itemid=" . $this->getVar('itemid') . "'><img src='" . PUBLISHER_URL . "/images/links/delete.png'" . " title='" . _CO_PUBLISHER_DELETE . "' alt='" . _CO_PUBLISHER_DELETE . "' /></a>";
                    $adminLinks .= " ";
                }
            }
            if ($this->publisher->getConfig('perm_clone') || PublisherUtils::IsUserModerator($this) || PublisherUtils::IsUserAdmin()) {
                // Duplicate button
                $adminLinks .= "<a href='" . PUBLISHER_URL . "/submit.php?op=clone&amp;itemid=" . $this->getVar('itemid') . "'><img src='" . PUBLISHER_URL . "/images/links/clone.gif'" . " title='" . _CO_PUBLISHER_CLONE . "' alt='" . _CO_PUBLISHER_CLONE . "' /></a>";
                $adminLinks .= " ";
            }
        }
        // PDF button
        if ($xoops->service('htmltopdf')->isAvailable()) {
            $adminLinks .= "<a href='" . PUBLISHER_URL . "/makepdf.php?itemid=" . $this->getVar('itemid') . "' rel='nofollow' target='_blank'><img src='" . PUBLISHER_URL . "/images/links/pdf.gif' title='" . _CO_PUBLISHER_PDF . "' alt='" . _CO_PUBLISHER_PDF . "' /></a>";
            $adminLinks .= " ";
        }
        // Print button
        $adminLinks .= "<a href='" . PublisherUtils::seoGenUrl("print", $this->getVar('itemid'), $this->getVar('short_url')) . "' rel='nofollow' target='_blank'><img src='" . PUBLISHER_URL . "/images/links/print.gif' title='" . _CO_PUBLISHER_PRINT . "' alt='" . _CO_PUBLISHER_PRINT . "' /></a>";
        $adminLinks .= " ";
        // Email button
        if ($xoops->isActiveModule('tellafriend')) {
            $subject = sprintf(_CO_PUBLISHER_INTITEMFOUND, $xoops->getConfig('sitename'));
            $subject = $this->_convert_for_japanese($subject);
            $maillink = PublisherUtils::tellafriend($subject);
            $adminLinks .= '<a href="' . $maillink . '"><img src="' . PUBLISHER_URL . '/images/links/friend.gif" title="' . _CO_PUBLISHER_MAIL . '" alt="' . _CO_PUBLISHER_MAIL . '" /></a>';
            $adminLinks .= " ";
        }
        return $adminLinks;
    }

    /**
     * @param array $notifications
     */
    public function sendNotifications($notifications = array())
    {
        $xoops = Xoops::getInstance();
        if ($xoops->isActiveModule('notifications')) {

            $notification_handler = Notifications::getInstance()->getHandlerNotification();

            $tags = array();
            $tags['MODULE_NAME'] = $this->publisher->getModule()->getVar('name');
            $tags['ITEM_NAME'] = $this->title();
            $tags['CATEGORY_NAME'] = $this->getCategoryName();
            $tags['CATEGORY_URL'] = PUBLISHER_URL . '/category.php?categoryid=' . $this->getVar('categoryid');
            $tags['ITEM_BODY'] = $this->body();
            $tags['DATESUB'] = $this->datesub();
            foreach ($notifications as $notification) {
                switch ($notification) {
                    case _PUBLISHER_NOT_ITEM_PUBLISHED :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                        $tags['ITEM_URL'] = PUBLISHER_URL . '/item.php?itemid=' . $this->getVar('itemid');
                        $notification_handler->triggerEvent('global', 0, 'published', $tags, array(), $this->publisher->getModule()->getVar('mid'));
                        $notification_handler->triggerEvent('category', $this->getVar('categoryid'), 'published', $tags, array(), $this->publisher->getModule()->getVar('mid'));
                        $notification_handler->triggerEvent('item', $this->getVar('itemid'), 'approved', $tags, array(), $this->publisher->getModule()->getVar('mid'));
                        break;
                    case _PUBLISHER_NOT_ITEM_SUBMITTED :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                        $tags['WAITINGFILES_URL'] = PUBLISHER_URL . '/admin/item.php?itemid=' . $this->getVar('itemid');
                        $notification_handler->triggerEvent('global', 0, 'submitted', $tags, array(), $this->publisher->getModule()->getVar('mid'));
                        $notification_handler->triggerEvent('category', $this->getVar('categoryid'), 'submitted', $tags, array(), $this->publisher->getModule()->getVar('mid'));
                        break;
                    case _PUBLISHER_NOT_ITEM_REJECTED :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                        $notification_handler->triggerEvent('item', $this->getVar('itemid'), 'rejected', $tags, array(), $this->publisher->getModule()->getVar('mid'));
                        break;
                    case -1 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
                    default:
                        break;
                }
            }
        }
    }

    /**
     * @return bool
     */
    public function notLoaded()
    {
        return $this->getVar('itemid') == -1;
    }

    /**
     * @return string
     */
    public function getItemUrl()
    {
        return PublisherUtils::seoGenUrl('item', $this->getVar('itemid'), $this->getVar('short_url'));
    }

    /**
     * @param bool $class
     * @param int  $maxsize
     *
     * @return string
     */
    public function getItemLink($class = false, $maxsize = 0)
    {
        if ($class) {
            return '<a class=' . $class . ' href="' . $this->getItemUrl() . '">' . $this->title($maxsize) . '</a>';
        } else {
            return '<a href="' . $this->getItemUrl() . '">' . $this->title($maxsize) . '</a>';
        }
    }

    /**
     * @return string
     */
    public function getWhoAndWhen()
    {
        $posterName = $this->linkedPosterName();
        $postdate = $this->datesub();
        return sprintf(_CO_PUBLISHER_POSTEDBY, $posterName, $postdate);
    }

    /**
     * @param null|string $body
     *
     * @return string
     */
    public function plain_maintext($body = null)
    {
        $ret = '';
        if (!$body) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $body = $this->body();
        }
        $ret .= str_replace('[pagebreak]', '<br /><br />', $body);
        return $ret;
    }

    /**
     * @param int         $item_page_id
     * @param null|string $body
     *
     * @return string
     */
    public function buildmaintext($item_page_id = -1, $body = null)
    {
        if (!$body) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $body = $this->body();
        }
        $body_parts = explode('[pagebreak]', $body);
        $this->setVar('pagescount', count($body_parts));
        if (count($body_parts) <= 1) {
            return $this->plain_maintext($body);
        }
        $ret = '';
        if ($item_page_id == -1) {
            $ret .= trim($body_parts[0]);
            return $ret;
        }
        if ($item_page_id >= count($body_parts)) {
            $item_page_id = count($body_parts) - 1;
        }
        $ret .= trim($body_parts[$item_page_id]);
        return $ret;
    }

    /**
     * @return mixed
     */
    public function getImages()
    {
        static $ret;

        $xoops = Xoops::getInstance();
        if (!$xoops->isActiveModule('images')) {
            return array();
        }
        $itemid = $this->getVar('itemid');
        if (!isset($ret[$itemid])) {
            $ret[$itemid]['main'] = '';
            $ret[$itemid]['others'] = array();
            $images_ids = array();
            $image = $this->getVar('image');
            $images = $this->getVar('images');
            if ($images != '') {
                $images_ids = explode('|', $images);
            }
            if ($image > 0) {
                $images_ids = array_merge($images_ids, array($image));
            }
            $imageObjs = array();
            if (count($images_ids) > 0) {
                $image_handler = Images::getInstance()->getHandlerImages();
                $criteria = new CriteriaCompo(new Criteria('image_id', '(' . implode(',', $images_ids) . ')', 'IN'));
                $imageObjs = $image_handler->getObjects($criteria, true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                unset($criteria);
            }
            foreach ($imageObjs as $id => $imageObj) {
                if ($id == $image) {
                    $ret[$itemid]['main'] = $imageObj;
                } else {
                    $ret[$itemid]['others'][] = $imageObj;
                }
                unset($imageObj);
            }
            unset($imageObjs);
        }
        return $ret[$itemid];
    }

    /**
     * @param string $display
     * @param int    $max_char_title
     * @param int    $max_char_summary
     * @param bool   $full_summary
     *
     * @return array
     */
    public function toArray($display = 'default', $max_char_title = 0, $max_char_summary = 0, $full_summary = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $item_page_id = -1;
        if (is_numeric($display)) {
            $item_page_id = $display;
            $display = 'all';
        }
        $item['itemid'] = $this->getVar('itemid');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $item['uid'] = $this->getVar('uid');
        $item['titlelink'] = $this->getItemLink(false, $max_char_title);
        $item['subtitle'] = $this->subtitle();
        $item['datesub'] = $this->datesub();
        $item['counter'] = $this->getVar('counter');
        switch ($display) {
            case 'summary':
            case 'list':
                break;
            case 'full':
            case 'wfsection':
            case 'default':
                $summary = $this->summary($max_char_summary);
                if (!$summary) {
                    $summary = $this->body($max_char_summary);
                }
                $item['summary'] = $summary;
                $item = $this->toArrayFull($item);
                break;
            case 'all':
                $item = $this->toArrayFull($item);
                $item = $this->toArrayAll($item, $item_page_id);
                break;
        }
        // Highlighting searched words
        $highlight = true;
        if ($highlight && isset($_GET['keywords'])) {
            $myts = \Xoops\Core\Text\Sanitizer::getInstance();
            $keywords = $myts->htmlSpecialChars(trim(urldecode($_GET['keywords'])));
            $fields = array('title', 'maintext', 'summary');
            foreach ($fields as $field) {
                if (isset($item[$field])) {
                    $item[$field] = $this->highlight($item[$field], $keywords);
                }
            }
        }
        return $item;
    }

    /**
     * @param array $item
     *
     * @return array
     */
    public function toArrayFull($item)
    {
        $item['title'] = $this->title();
        $item['clean_title'] = $this->title();
        $item['itemurl'] = $this->getItemUrl();
        $item['cancomment'] = $this->getVar('cancomment');
        $item['comments'] = $this->getVar('comments');
        $item['adminlink'] = $this->getAdminLinks();
        $item['categoryPath'] = $this->getCategoryPath($this->publisher->getConfig('format_linked_path'));
        $item['who_when'] = $this->getWhoAndWhen();
        $item = $this->getMainImage($item);
        return $item;
    }

    /**
     * @param array $item
     * @param int   $item_page_id
     *
     * @return array
     */
    public function toArrayAll($item, $item_page_id)
    {
        $item['maintext'] = $this->buildmaintext($item_page_id, $this->body());
        $item = $this->getOtherImages($item);
        return $item;
    }

    /**
     * @param array $item
     *
     * @return array
     */
    public function getMainImage($item = array())
    {
        $images = $this->getImages();
        $item['image_path'] = '';
        $item['image_name'] = '';
        if (is_object($images['main'])) {
            /* @var $image ImagesImage */
            $image = $images['main'];
            $dimensions = getimagesize(\XoopsBaseConfig::get('root-path') . '/uploads/' . $image->getVar('image_name'));
            $item['image_width'] = $dimensions[0];
            $item['image_height'] = $dimensions[1];
            $item['image_path'] = \XoopsBaseConfig::get('url') . '/uploads/' . $image->getVar('image_name');
            // pass this on since some consumers build custom thumbnails
            $item['image_vpath'] = 'uploads/' . $image->getVar('image_name');
            $item['image_thumb'] = \Xoops::getInstance()
                ->service('thumbnail')
                ->getImgUrl($item['image_vpath'], 0, 180)
                ->getValue();
            $item['image_name'] = $image->getVar('image_nicename');
        }
        return $item;
    }

    /**
     * @param array $item
     *
     * @return array
     */
    public function getOtherImages($item = array())
    {
        $thumbService = \Xoops::getInstance()->service('thumbnail');
        $images = $this->getImages();
        $item['images'] = array();
        $i = 0;
        /* @var $image ImagesImage */
        foreach ($images['others'] as $image) {
            $dimensions = getimagesize(\XoopsBaseConfig::get('root-path') . '/uploads/' . $image->getVar('image_name'));
            $item['images'][$i]['width'] = $dimensions[0];
            $item['images'][$i]['height'] = $dimensions[1];
            $item['images'][$i]['path'] = \XoopsBaseConfig::get('url') . '/uploads/' . $image->getVar('image_name');
            $item['images'][$i]['thumb'] = $thumbService
                ->getImgUrl('uploads/' . $image->getVar('image_name'), 240, 0)
                ->getValue();
            $item['images'][$i]['name'] = $image->getVar('image_nicename');
            ++$i;
        }
        return $item;
    }

    /**
     * @param string       $content
     * @param string|array $keywords
     *
     * @return string Text
     */
    public function highlight($content, $keywords)
    {
        $color = $this->publisher->getConfig('format_highlight_color');
        if (substr($color, 0, 1) !== '#') {
            $color = '#' . $color;
        }
        $pre = '<span style="font-weight: bolder; background-color: ' . $color . ';">';
        $post = '</span>';
        return \Xmf\Highlighter::apply($keywords, $content, $pre, $post);

    }

    /**
     *  Create metada and assign it to template
     */
    public function createMetaTags()
    {
        $publisher_metagen = new PublisherMetagen($this->title(), $this->getVar('meta_keywords'), $this->getVar('meta_description'), $this->_category->_categoryPath);
        $publisher_metagen->createMetaTags();
    }

    /**
     * @param string $str
     *
     * @return string
     */
    public function _convert_for_japanese($str)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}
        // no action, if not flag
        if (!defined('_PUBLISHER_FLAG_JP_CONVERT')) {
            return $str;
        }
        // no action, if not Japanese
        if ($xoopsConfig['language'] !== 'japanese') {
            return $str;
        }
        // presume OS Browser
        $agent = $_SERVER["HTTP_USER_AGENT"];
        $os = '';
        $browser = '';
        if (preg_match("/Win/i", $agent)) {
            $os = 'win';
        }
        if (preg_match("/MSIE/i", $agent)) {
            $browser = 'msie';
        }
        // if msie
        if (($os === 'win') && ($browser === 'msie')) {
            // if multibyte
            if (function_exists('mb_convert_encoding')) {
                $str = mb_convert_encoding($str, 'SJIS', 'EUC-JP');
                $str = rawurlencode($str);
            }
        }
        return $str;
    }

    /**
     * Checks if a user has access to a selected item. if no item permissions are
     * set, access permission is denied. The user needs to have necessary category
     * permission as well.
     * Also, the item needs to be Published
     *
     * @return boolean : TRUE if the no errors occured
     */
    public function accessGranted()
    {
        if (PublisherUtils::IsUserAdmin()) {
            return true;
        }
        if ($this->getVar('status') != _PUBLISHER_STATUS_PUBLISHED) {
            return false;
        }
        // Do we have access to the parent category
        if ($this->publisher->getPermissionHandler()->isGranted('category_read', $this->getVar('categoryid'))) {
            return true;
        }
        return false;
    }

    /**
     * The name says it all
     */
    public function setVarsFromRequest()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $xoops = Xoops::getInstance();
        //Required fields
        if (isset($_REQUEST['categoryid'])) {
            $this->setVar('categoryid', Request::getInt('categoryid'));
        }
        if (isset($_REQUEST['title'])) {
            $this->setVar('title', Request::getString('title'));
        }
        if (isset($_REQUEST['body'])) {
            $this->setVar('body', Request::getText('body'));
        }
        //Not required fields
        if (isset($_REQUEST['summary'])) {
            $this->setVar('summary', Request::getText('summary'));
        }
        if (isset($_REQUEST['subtitle'])) {
            $this->setVar('subtitle', Request::getString('subtitle'));
        }
        if (isset($_REQUEST['item_tag'])) {
            $this->setVar('item_tag', Request::getString('item_tag'));
        }
        if (isset($_REQUEST['image_featured'])) {
            $image_item = Request::getArray('image_item');
            $image_featured = Request::getString('image_featured');
            //Todo: get a better image class for xoops!
            //Image hack
            $image_item_ids = array();

            $qb = \Xoops::getInstance()->db()->createXoopsQueryBuilder();
            $qb ->select('i.image_id', 'i.image_name')
                ->fromPrefix('image', 'i')
                ->orderBy('i.image_id');
            $result = $qb->execute();

            while ($myrow = $result->fetch(\PDO::FETCH_ASSOC)) {
                $image_name = $myrow['image_name'];
                $id = $myrow['image_id'];
                if ($image_name == $image_featured) {
                    $this->setVar('image', $id);
                }
                if (in_array($image_name, $image_item)) {
                    $image_item_ids[] = $id;
                }
            }
            $this->setVar('images', implode('|', $image_item_ids));
        }
        if (isset($_REQUEST['uid'])) {
            $this->setVar('uid', Request::getInt('uid'));
        } elseif ($this->isNew()) {
            $this->setVar('uid', $xoops->isUser() ? $xoops->user->getVar('uid') : 0);
        }
        if (isset($_REQUEST['author_alias'])) {
            $this->setVar('author_alias', Request::getString('author_alias'));
            if ($this->getVar('author_alias') != '') {
                $this->setVar('uid', 0);
            }
        }
        if (isset($_REQUEST['datesub'])) {
            $this->setVar('datesub', strtotime($_REQUEST['datesub']['date']) + $_REQUEST['datesub']['time']);
        } elseif ($this->isNew()) {
            $this->setVar('datesub', time());
        }
        if (isset($_REQUEST['item_short_url'])) {
            $this->setVar('short_url', Request::getString('item_short_url'));
        }
        if (isset($_REQUEST['item_meta_keywords'])) {
            $this->setVar('meta_keywords', Request::getString('item_meta_keywords'));
        }
        if (isset($_REQUEST['item_meta_description'])) {
            $this->setVar('meta_description', Request::getString('item_meta_description'));
        }
        if (isset($_REQUEST['weight'])) {
            $this->setVar('weight', Request::getInt('weight'));
        }
        if (isset($_REQUEST['allowcomments'])) {
            $this->setVar('cancomment', Request::getInt('allowcomments'));
        } elseif ($this->isNew()) {
            $this->setVar('cancoment', $this->publisher->getConfig('submit_allowcomments'));
        }
        if (isset($_REQUEST['status'])) {
            $this->setVar('status', Request::getInt('status'));
        } elseif ($this->isNew()) {
            $this->setVar('status', $this->publisher->getConfig('submit_status'));
        }
        if (isset($_REQUEST['dohtml'])) {
            $this->setVar('dohtml', Request::getInt('dohtml'));
        } elseif ($this->isNew()) {
            $this->setVar('dohtml', $this->publisher->getConfig('submit_dohtml'));
        }
        if (isset($_REQUEST['dosmiley'])) {
            $this->setVar('dosmiley', Request::getInt('dosmiley'));
        } elseif ($this->isNew()) {
            $this->setVar('dosmiley', $this->publisher->getConfig('submit_dosmiley'));
        }
        if (isset($_REQUEST['doxcode'])) {
            $this->setVar('doxcode', Request::getInt('doxcode'));
        } elseif ($this->isNew()) {
            $this->setVar('doxcode', $this->publisher->getConfig('submit_doxcode'));
        }
        if (isset($_REQUEST['doimage'])) {
            $this->setVar('doimage', Request::getInt('doimage'));
        } elseif ($this->isNew()) {
            $this->setVar('doimage', $this->publisher->getConfig('submit_doimage'));
        }
        if (isset($_REQUEST['dolinebreak'])) {
            $this->setVar('dobr', Request::getInt('dolinebreak'));
        } elseif ($this->isNew()) {
            $this->setVar('dobr', $this->publisher->getConfig('submit_dobr'));
        }
        if (isset($_REQUEST['notify'])) {
            $this->setVar('notifypub', Request::getInt('notify'));
        }
    }
}

/**
 * Items handler class.
 * This class is responsible for providing data access mechanisms to the data source
 * of Q&A class objects.
 *
 * @author  marcan <[email protected]>
 * @package Publisher
 */
class PublisherItemHandler extends XoopsPersistableObjectHandler

{
    /**
     * @var Publisher
     * @access public
     */
    public $publisher = null;

    /**
     * @param Connection $db
     */
    public function __construct(Connection $db)
    {
        parent::__construct($db, "publisher_items", 'PublisherItem', "itemid", "title");
        $this->publisher = Publisher::getInstance();
    }

    /**
     * insert a new item in the database
     *
     * @param XoopsObject $item reference to the {@link PublisherItem} object
     * @param bool        $force
     *
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */
    public function insert(XoopsObject $item, $force = true)
    {
        $xoops = Xoops::getInstance();
        if (!$item->getVar('meta_keywords') || !$item->getVar('meta_description') || !$item->getVar('short_url')) {
            $publisher_metagen = new PublisherMetagen($item->title(), $item->getVar('meta_keywords'), $item->getVar('summary'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            // Auto create meta tags if empty
            if (!$item->getVar('meta_keywords')) {
                $item->setVar('meta_keywords', $publisher_metagen->_keywords);
            }
            if (!$item->getVar('meta_description')) {
                $item->setVar('meta_description', $publisher_metagen->_description);
            }
            // Auto create short_url if empty
            if (!$item->getVar('short_url')) {
                $item->setVar('short_url', $publisher_metagen->generateSeoTitle($item->getVar('title', 'n'), false));
            }
        }
        if (!parent::insert($item, $force)) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return false;
        }
        if ($xoops->isActiveModule('tag')) {
            // Storing tags information
            $tag_handler = $xoops->getModuleHandler('tag', 'tag');
            $tag_handler->updateByItem($item->getVar('item_tag'), $item->getVar('itemid'), PUBLISHER_DIRNAME, 0);
        }
        return true;
    }

    /**
     * delete an item from the database
     *
     * @param XoopsObject $item reference to the ITEM to delete
     * @param bool        $force
     *
     * @return bool FALSE if failed.
     */
    public function delete(XoopsObject $item, $force = false)
    {
        $xoops = Xoops::getInstance();
        // Deleting the files
        if (!$this->publisher->getFileHandler()->deleteItemFiles($item)) {
            $item->setErrors('An error while deleting a file.');
        }
        if (!parent::delete($item, $force)) {
            $item->setErrors('An error while deleting.');
            return false;
        }
        // Removing tags information
        if ($xoops->isActiveModule('tag')) {
            $tag_handler = $xoops->getModuleHandler('tag', 'tag');
            $tag_handler->updateByItem('', $item->getVar('itemid'), PUBLISHER_DIRNAME, 0);
        }
        return true;
    }

    /**
     * retrieve items from the database
     *
     * @param object $criteria      {@link CriteriaElement} conditions to be met
     * @param string $id_key        what shall we use as array key ? none, itemid, categoryid
     * @param string $notNullFields fields that cannot be null or empty
     *
     * @return array array of {@link PublisherItem} objects
     */
    public function getItemObjects($criteria = null, $id_key = 'none', $notNullFields = '')
    {
        $ret = array();
        $whereMode = '';

        $qb = $this->db2->createXoopsQueryBuilder();
        $qb ->select('*')
            ->fromPrefix('publisher_items', '');
        if (isset($criteria) && is_subclass_of($criteria, 'Xoops\Core\Kernel\CriteriaElement')) {
            $criteria->renderQb($qb, '');
            $whereMode = 'AND';
        }
        $this->addNotNullFieldClause($qb, $notNullFields, $whereMode);
        $theObjects = array();
        $result = $qb->execute();
        while ($myrow = $result->fetch(\PDO::FETCH_ASSOC)) {
            $item = new PublisherItem();
            $item->assignVars($myrow);
            $theObjects[$myrow['itemid']] = $item;
            unset($item);
        }

        /* @var $theObject PublisherItem */
        foreach ($theObjects as $theObject) {
            if ($id_key === 'none') {
                $ret[] = $theObject;
            } elseif ($id_key === 'itemid') {
                $ret[$theObject->getVar('itemid')] = $theObject;
            } else {
                $ret[$theObject->getVar($id_key)][$theObject->getVar('itemid')] = $theObject;
            }
            unset($theObject);
        }
        return $ret;
    }

    /**
     * count items matching a condition
     *
     * @param object $criteria {@link CriteriaElement} to match
     * @param string $notNullFields fields that cannot be null or empty
     *
     * @return int count of items
     */
    public function getItemCount($criteria = null, $notNullFields = '')
    {
        $whereMode = '';

        $qb = $this->db2->createXoopsQueryBuilder();
        $qb ->select('COUNT(*)')
            ->fromPrefix('publisher_items', '');
        if (isset($criteria) && is_subclass_of($criteria, 'Xoops\Core\Kernel\CriteriaElement')) {
            $whereClause = $criteria->renderQb($qb, '');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $whereMode = 'AND';
        }
        $this->addNotNullFieldClause($qb, $notNullFields, $whereMode);
        $result = $qb->execute();

        if (!$result) {
            return 0;
        }
        list($count) = $result->fetch(PDO::FETCH_NUM);
        return $count;
    }

    /**
     * @param        $categoryid
     * @param string $status
     * @param string $notNullFields
     *
     * @return int
     */
    public function getItemsCount($categoryid = -1, $status = '', $notNullFields = '')
    {
        global $publisher_isAdmin;
function myFunction($a, $b) {
    // Do something
}
        if (!$publisher_isAdmin) {
            $criteriaPermissions = new CriteriaCompo();
            // Categories for which user has access
            $categoriesGranted = $this->publisher->getPermissionHandler()->getGrantedItems('category_read');
            if (!empty($categoriesGranted)) {
                $grantedCategories = new Criteria('categoryid', "(" . implode(',', $categoriesGranted) . ")", 'IN');
                $criteriaPermissions->add($grantedCategories, 'AND');
            } else {
                return 0;
            }
        }
        if (isset($categoryid) && $categoryid != -1) {
            $criteriaCategory = new criteria('categoryid', $categoryid);
        }
        $criteriaStatus = new CriteriaCompo();
        if (!empty($status) && is_array($status)) {
            foreach ($status as $v) {
                $criteriaStatus->add(new Criteria('status', $v), 'OR');
            }
        } elseif (!empty($status) && $status != -1) {
            $criteriaStatus->add(new Criteria('status', $status), 'OR');
        }
        $criteria = new CriteriaCompo();
        if (!empty($criteriaCategory)) {
            $criteria->add($criteriaCategory);
        }
        if (!empty($criteriaPermissions)) {
            $criteria->add($criteriaPermissions);
        }
        if (!empty($criteriaStatus)) {
            $criteria->add($criteriaStatus);
        }
        return $this->getItemCount($criteria, $notNullFields);
    }

    /**
     * @param int    $limit
     * @param int    $start
     * @param int    $categoryid
     * @param string $sort
     * @param string $order
     * @param string $notNullFields
     * @param bool   $asobject
     * @param string $id_key
     *
     * @return array
     */
    public function getAllPublished($limit = 0, $start = 0, $categoryid = -1, $sort = 'datesub', $order = 'DESC', $notNullFields = '', $asobject = true, $id_key = 'none')
    {
        $otherCriteria = new Criteria('datesub', time(), '<=');
        return $this->getItems($limit, $start, array(_PUBLISHER_STATUS_PUBLISHED), $categoryid, $sort, $order, $notNullFields, $asobject, $otherCriteria, $id_key);
    }

    /**
     * @param PublisherItem $obj
     *
     * @return bool
     */
    public function getPreviousPublished($obj)
    {
        $ret = false;
        $otherCriteria = new CriteriaCompo();
        $otherCriteria->add(new Criteria('datesub', $obj->getVar('datesub'), '<'));
        $objs = $this->getItems(1, 0, array(_PUBLISHER_STATUS_PUBLISHED), $obj->getVar('categoryid'), 'datesub', 'DESC', '', true, $otherCriteria, 'none');
        if (count($objs) > 0) {
            $ret = $objs[0];
        }
        return $ret;
    }

    /**
     * @param PublisherItem $obj
     *
     * @return bool
     */
    public function getNextPublished($obj)
    {
        $ret = false;
        $otherCriteria = new CriteriaCompo();
        $otherCriteria->add(new Criteria('datesub', $obj->getVar('datesub'), '>'));
        $otherCriteria->add(new Criteria('datesub', time(), '<='));
        $objs = $this->getItems(1, 0, array(_PUBLISHER_STATUS_PUBLISHED), $obj->getVar('categoryid'), 'datesub', 'ASC', '', true, $otherCriteria, 'none');
        if (count($objs) > 0) {
            $ret = $objs[0];
        }
        return $ret;
    }

    /**
     * @param int    $limit
     * @param int    $start
     * @param int    $categoryid
     * @param string $sort
     * @param string $order
     * @param string $notNullFields
     * @param bool   $asobject
     * @param string $id_key
     *
     * @return array
     */
    public function getAllSubmitted($limit = 0, $start = 0, $categoryid = -1, $sort = 'datesub', $order = 'DESC', $notNullFields = '', $asobject = true, $id_key = 'none')
    {
        return $this->getItems($limit, $start, array(_PUBLISHER_STATUS_SUBMITTED), $categoryid, $sort, $order, $notNullFields, $asobject, null, $id_key);
    }

    /**
     * @param int    $limit
     * @param int    $start
     * @param int    $categoryid
     * @param string $sort
     * @param string $order
     * @param string $notNullFields
     * @param bool   $asobject
     * @param string $id_key
     *
     * @return array
     */
    public function getAllOffline($limit = 0, $start = 0, $categoryid = -1, $sort = 'datesub', $order = 'DESC', $notNullFields = '', $asobject = true, $id_key = 'none')
    {
        return $this->getItems($limit, $start, array(_PUBLISHER_STATUS_OFFLINE), $categoryid, $sort, $order, $notNullFields, $asobject, null, $id_key);
    }

    /**
     * @param int    $limit
     * @param int    $start
     * @param int    $categoryid
     * @param string $sort
     * @param string $order
     * @param string $notNullFields
     * @param bool   $asobject
     * @param string $id_key
     *
     * @return array
     */
    public function getAllRejected($limit = 0, $start = 0, $categoryid = -1, $sort = 'datesub', $order = 'DESC', $notNullFields = '', $asobject = true, $id_key = 'none')
    {
        return $this->getItems($limit, $start, array(_PUBLISHER_STATUS_REJECTED), $categoryid, $sort, $order, $notNullFields, $asobject, null, $id_key);
    }

    /**
     * @param int    $limit
     * @param int    $start
     * @param string $status
     * @param  int   $categoryid
     * @param string $sort
     * @param string $order
     * @param string $notNullFields
     * @param bool   $asobject
     * @param null   $otherCriteria
     * @param string $id_key
     *
     * @return array
     */
    public function getItems($limit = 0, $start = 0, $status = '', $categoryid = -1, $sort = 'datesub', $order = 'DESC', $notNullFields = '', $asobject = true, $otherCriteria = null, $id_key = 'none')

    {
        global $publisher_isAdmin;
function myFunction($a, $b) {
    // Do something
}
        if (!$publisher_isAdmin) {
            $criteriaPermissions = new CriteriaCompo();
            // Categories for which user has access
            $categoriesGranted = $this->publisher->getPermissionHandler()->getGrantedItems('category_read');
            if (!empty($categoriesGranted)) {
                $grantedCategories = new Criteria('categoryid', "(" . implode(',', $categoriesGranted) . ")", 'IN');
                $criteriaPermissions->add($grantedCategories, 'AND');
            } else {
                return array();
            }
        }
        if (isset($categoryid) && ($categoryid != -1)) {
            $criteriaCategory = new criteria('categoryid', $categoryid);
        }
        if (!empty($status) && is_array($status)) {
            $criteriaStatus = new CriteriaCompo();
            foreach ($status as $v) {
                $criteriaStatus->add(new Criteria('status', $v), 'OR');
            }
        } elseif (!empty($status) && $status != -1) {
            $criteriaStatus = new CriteriaCompo();
            $criteriaStatus->add(new Criteria('status', $status), 'OR');
        }
        $criteria = new CriteriaCompo();
        if (!empty($criteriaCategory)) {
            $criteria->add($criteriaCategory);
        }
        if (!empty($criteriaPermissions)) {
            $criteria->add($criteriaPermissions);
        }
        if (!empty($criteriaStatus)) {
            $criteria->add($criteriaStatus);
        }
        if (!empty($otherCriteria)) {
            $criteria->add($otherCriteria);
        }
        $criteria->setLimit($limit);
        $criteria->setStart($start);
        $criteria->setSort($sort);
        $criteria->setOrder($order);
        $ret = $this->getItemObjects($criteria, $id_key, $notNullFields);
        return $ret;
    }

    /**
     * @param string $field
     * @param string $status
     * @param int    $categoryId
     *
     * @return bool
     */
    public function getRandomItem($field = '', $status = '', $categoryId = -1)
    {
        $ret = false;
        $notNullFields = $field;
        // Getting the number of published Items
        $totalItems = $this->getItemsCount($categoryId, $status, $notNullFields);
        if ($totalItems > 0) {
            $totalItems = $totalItems - 1;
            mt_srand((double)microtime() * 1000000);
            $entrynumber = mt_rand(0, $totalItems);
            $item = $this->getItems(1, $entrynumber, $status, $categoryId, $sort = 'datesub', $order = 'DESC', $notNullFields);
            if ($item) {

                $ret = $item[0];
            }
        }
        return $ret;
    }

    /**
     * @param $itemid
     *
     * @return bool
     */
    public function updateCounter($itemid)
    {
        $qb = $this->db2->createXoopsQueryBuilder();
        $qb->updatePrefix('publisher_items', 'i')
            ->set('i.counter', 'i.counter+1')
            ->where('i.itemid = :itemid')
            ->setParameter(':itemid', $itemid, \PDO::PARAM_INT);
        $result = $qb->execute();
        if ($result) {
            return true;
        } else {
            return false;
        }
    }

    /**
     * addNotNullFieldClause exclude rows where specified columns are empty or null
     *
     * @param QueryBuilder $qb            QueryBuilder instance
     * @param string|array $notNullFields fields that should not be empty
     * @param string       $whereMode     Initial where method, 'AND' andWhere(), otherwise where()
     *
     * @return QueryBuilder instance
     */
    protected function addNotNullFieldClause(\Xoops\Core\Database\QueryBuilder $qb, $notNullFields = array(), $whereMode = '')
    {
        $eb = $qb->expr();
        if (!empty($notNullFields)) {
            if (!is_array($notNullFields)) {
                $notNullFields = (array) $notNullFields;
            }
            foreach ($notNullFields as $v) {
                if ($whereMode === 'AND') {
                    $qb ->andWhere($eb->isNotNull($v, ''))

                        ->andWhere($eb->neq($v, "''"));
                } else {
                    $qb ->where($eb->isNotNull($v, ''))

                        ->andWhere($eb->neq($v, "''"));
                    $whereMode = 'AND';
                }
            }
        }

        return $qb;
    }

    /**
     * @param array  $queryarray
     * @param string $andor
     * @param int    $limit
     * @param int    $offset
     * @param int    $userid
     * @param array  $categories
     * @param int    $sortby
     * @param string $searchin
     * @param string $extra
     *
     * @return array
     */
    public function getItemsFromSearch($queryarray = array(), $andor = 'AND', $limit = 0, $offset = 0, $userid = 0, $categories = array(), $sortby = 0, $searchin = "", $extra = "")

    {
        $xoops = Xoops::getInstance();
        $ret = array();
        $gperm_handler = $xoops->getHandlerGroupPermission();
        $groups = $xoops->getUserGroups();
        $searchin = empty($searchin) ? array(
            "title",
            "body",
            "summary"
        ) : (is_array($searchin) ? $searchin : array($searchin));
        if (in_array("all", $searchin) || count($searchin) == 0) {
            $searchin = array("title", "subtitle", "body", "summary", "meta_keywords");
        }
        if (is_array($userid) && count($userid) > 0) {
            $userid = array_map("intval", $userid);
            $criteriaUser = new CriteriaCompo();
            $criteriaUser->add(new Criteria('uid', '(' . implode(',', $userid) . ')', 'IN'), 'OR');
        } elseif (is_numeric($userid) && $userid > 0) {
            $criteriaUser = new CriteriaCompo();
            $criteriaUser->add(new Criteria('uid', $userid), 'OR');
        }
        $count = count($queryarray);
        if (is_array($queryarray) && $count > 0) {
            $criteriaKeywords = new CriteriaCompo();
            for ($i = 0; $i < count($queryarray); ++$i) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $criteriaKeyword = new CriteriaCompo();
                if (in_array('title', $searchin)) {
                    $criteriaKeyword->add(new Criteria('title', '%' . $queryarray[$i] . '%', 'LIKE'), 'OR');
                }
                if (in_array('subtitle', $searchin)) {
                    $criteriaKeyword->add(new Criteria('subtitle', '%' . $queryarray[$i] . '%', 'LIKE'), 'OR');
                }
                if (in_array('body', $searchin)) {
                    $criteriaKeyword->add(new Criteria('body', '%' . $queryarray[$i] . '%', 'LIKE'), 'OR');
                }
                if (in_array('summary', $searchin)) {
                    $criteriaKeyword->add(new Criteria('summary', '%' . $queryarray[$i] . '%', 'LIKE'), 'OR');
                }
                if (in_array('meta_keywords', $searchin)) {
                    $criteriaKeyword->add(new Criteria('meta_keywords', '%' . $queryarray[$i] . '%', 'LIKE'), 'OR');
                }
                $criteriaKeywords->add($criteriaKeyword, $andor);
                unset($criteriaKeyword);
            }
        }
        if (!PublisherUtils::IsUserAdmin() && (count($categories) > 0)) {
            $criteriaPermissions = new CriteriaCompo();
            // Categories for which user has access
            $categoriesGranted = $gperm_handler->getItemIds('category_read', $groups, $this->publisher->getModule()->getVar('mid'));
            if (count($categories) > 0) {
                $categoriesGranted = array_intersect($categoriesGranted, $categories);
            }
            if (count($categoriesGranted) == 0) {
                return $ret;
            }
            $grantedCategories = new Criteria('categoryid', "(" . implode(',', $categoriesGranted) . ")", 'IN');
            $criteriaPermissions->add($grantedCategories, 'AND');
        } elseif (count($categories) > 0) {
            $criteriaPermissions = new CriteriaCompo();
            $grantedCategories = new Criteria('categoryid', "(" . implode(',', $categories) . ")", 'IN');
            $criteriaPermissions->add($grantedCategories, 'AND');
        }
        $criteriaItemsStatus = new CriteriaCompo();
        $criteriaItemsStatus->add(new Criteria('status', _PUBLISHER_STATUS_PUBLISHED));
        $criteria = new CriteriaCompo();
        if (!empty($criteriaUser)) {
            $criteria->add($criteriaUser, 'AND');
        }
        if (!empty($criteriaKeywords)) {
            $criteria->add($criteriaKeywords, 'AND');
        }
        if (!empty($criteriaPermissions)) {
            $criteria->add($criteriaPermissions);
        }
        if (!empty($criteriaItemsStatus)) {
            $criteria->add($criteriaItemsStatus, 'AND');
        }
        $criteria->setLimit($limit);
        $criteria->setStart($offset);
        if (empty($sortby)) {
            $sortby = "datesub";
        }
        $criteria->setSort($sortby);
        $order = 'ASC';
        if ($sortby === "datesub") {
            $order = 'DESC';
        }
        $criteria->setOrder($order);
        $ret = $this->getItemObjects($criteria);
        return $ret;
    }

    /**
     * @param array  $categoriesObj
     * @param array  $status
     *
     * @return array
     */
    public function getLastPublishedByCat($categoriesObj, $status = array(_PUBLISHER_STATUS_PUBLISHED))
    {
        $ret = array();
        $catIds = array();
        /* @var $category PublisherCategory */
        foreach ($categoriesObj as $parentid) {
            foreach ($parentid as $category) {
                $catId = $category->getVar('categoryid');
                $catIds[$catId] = $catId;
            }
        }
        if (empty($catIds)) {
            return $ret;
        }

        // $sql = "SELECT mi.categoryid, mi.itemid, mi.title, mi.short_url, mi.uid, mi.datesub";
        // $sql .= " FROM (SELECT categoryid, MAX(datesub) AS date FROM " . $this->db->prefix('publisher_items');
        // $sql .= " WHERE status IN (" . implode(',', $status) . ")";
        // $sql .= " AND categoryid IN (" . implode(',', $catIds) . ")";
        // $sql .= " GROUP BY categoryid)mo";
        // $sql .= " JOIN " . $this->db->prefix('publisher_items') . " mi ON mi.datesub = mo.date";

        $qb = $this->db2->createXoopsQueryBuilder();
        $qb->select('mi.categoryid', 'mi.itemid', 'mi.title', 'mi.short_url', 'mi.uid', 'mi.datesub');

        $subqb = $this->db2->createXoopsQueryBuilder();
        $subqb->select('categoryid', 'MAX(datesub) AS date')
            ->fromPrefix('publisher_items', '')
            ->where($subqb->expr()->in('status', $status))
            ->andWhere($subqb->expr()->in('categoryid', $catIds))
            ->groupBy('categoryid');
        $subquery = '('.$subqb->getSQL().')';

        $qb ->from($subquery, 'mo')
            ->joinPrefix('mo', 'publisher_items', 'mi', 'mi.datesub = mo.date');

        $result = $qb->execute();
        while ($row = $result->fetch(\PDO::FETCH_ASSOC)) {
            $item = new PublisherItem();
            $item->assignVars($row);
            $ret[$row['categoryid']] = $item;
            unset($item);
        }
        return $ret;
    }

    /**
     * @param int         $parentid
     * @param array       $catsCount
     * @param string      $spaces
     * @param array       $resultCatCounts
     *
     * @return int
     */
    public function countArticlesByCat($parentid, &$catsCount, $spaces = '', $resultCatCounts = array())
    {
        $newspaces = $spaces . '--';
        $thecount = 0;
        foreach ($catsCount[$parentid] as $subCatId => $count) {
            $thecount = $thecount + $count;
            $resultCatCounts[$subCatId] = $count;
            if (isset($catsCount[$subCatId])) {
                $thecount = $thecount + $this->countArticlesByCat($subCatId, $catsCount, $newspaces, $resultCatCounts);
                $resultCatCounts[$subCatId] = $thecount;
            }
        }
        return $thecount;
    }

    /**
     * @param int     $cat_id
     * @param array   $status
     * @param bool    $inSubCat
     *
     * @return array
     */
    public function getCountsByCat($cat_id = 0, $status, $inSubCat = false)
    {
        $ret = array();
        $catsCount = array();

        $qb = $this->db2->createXoopsQueryBuilder();
        $qb ->select('c.parentid', 'i.categoryid', 'COUNT(*) AS count')
            ->fromPrefix('publisher_items', 'i')
            ->innerJoinPrefix('i', 'publisher_categories', 'c', 'i.categoryid=c.categoryid')
            ->where($qb->expr()->in('i.status', $status))
            ->groupBy('i.categoryid')
            ->orderBy('c.parentid', 'ASC')
            ->addOrderBy('i.categoryid', 'ASC');
        if ((int)($cat_id) > 0) {
            $qb ->andWhere($qb->expr()->eq('i.categoryid', ':catid'))
                ->setParameter(':catid', $cat_id, \PDO::PARAM_INT);
        }

        //$sql = 'SELECT c.parentid, i.categoryid, COUNT(*) AS count FROM ' . $this->db->prefix('publisher_items')
        //. ' AS i INNER JOIN ' . $this->db->prefix('publisher_categories') . ' AS c ON i.categoryid=c.categoryid';
        //if ((int)($cat_id) > 0) {
        //    $sql .= ' WHERE i.categoryid = ' . (int)($cat_id);
        //    $sql .= ' AND i.status IN (' . implode(',', $status) . ')';
        //} else {
        //    $sql .= ' WHERE i.status IN (' . implode(',', $status) . ')';
        //}
        //$sql .= ' GROUP BY i.categoryid ORDER BY c.parentid ASC, i.categoryid ASC';

        $result = $qb->execute();

        if (!$result) {
            return $ret;
        }
        if (!$inSubCat) {
            while ($row = $result->fetch(\PDO::FETCH_ASSOC)) {
                $catsCount[$row['categoryid']] = $row['count'];
            }
            return $catsCount;
        }
        while ($row = $result->fetch(\PDO::FETCH_ASSOC)) {
            $catsCount[$row['parentid']][$row['categoryid']] = $row['count'];
        }
        $resultCatCounts = array();
        foreach ($catsCount[0] as $subCatId => $count) {
            $resultCatCounts[$subCatId] = $count;
            if (isset($catsCount[$subCatId])) {
                $resultCatCounts[$subCatId] = $resultCatCounts[$subCatId] + $this->countArticlesByCat($subCatId, $catsCount, $spaces = '', $resultCatCounts);
            }
        }
        return $resultCatCounts;
    }
}

Push — master ( fc2c42...d0941c )

PublisherItemHandler::getAllRejected() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

XOOPS / XoopsCore

Push — master ( fc2c42...d0941c )

PublisherItemHandler::getAllRejected() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like
