XoopsCaptchaText

Complexity

Total Complexity

4

Size/Duplication

Total Lines	38
Duplicated Lines	7.89 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

82.35%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	render()	3	11	2
A	loadText()	0	13	2

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * CAPTCHA for text mode
 *
 * PHP 5.3
 *
 * @category  Xoops\Class\Captcha\Captcha
 * @package   Captcha
 * @author    Taiwen Jiang <phppp@users.sourceforge.net>
 * @copyright 2013 XOOPS Project (http://xoops.org)
 * @license   GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @version   $Id$
 * @link      http://xoops.org
 * @since     2.6.0
 */
class XoopsCaptchaText extends XoopsCaptchaMethod
{
    /**
     * XoopsCaptchaText::render()
     *
     * @return string
     */
    public function render()
    {
        $form = $this->loadText() . '&nbsp;&nbsp; <input type="text" name="' . $this->config['name']
			. '" id="' . $this->config['name'] . '" size="' . $this->config['num_chars']
			. '" maxlength="' . $this->config['num_chars'] . '" value="" />';
        $form .= '<br />' . XoopsLocale::INPUT_RESULT_FROM_EXPRESSION;
        if (!empty($this->config['maxattempts'])) {
            $form .= '<br />' . sprintf(XoopsLocale::F_MAXIMUM_ATTEMPTS, $this->config['maxattempts']);
        }
        return $form;
    }

    /**
     * XoopsCaptchaText::loadText()
     *
     * @return string
     */
    public function loadText()
    {
        $val_a = mt_rand(0, 9);
        $val_b = mt_rand(0, 9);
        if ($val_a > $val_b) {
            $expression = "{$val_a} - {$val_b} = ?";
            $this->code = $val_a - $val_b;

The property $code was declared of type string, but $val_a - $val_b is of type integer. Maybe add a type cast?

        } else {
            $expression = "{$val_a} + {$val_b} = ?";
            $this->code = $val_a + $val_b;

The property $code was declared of type string, but $val_a + $val_b is of type integer. Maybe add a type cast?

        }
        return '<span style="font-style: normal; font-weight: bold; font-size: 100%; font-color: #333; border: 1px solid #333; padding: 1px 5px;">' . $expression . '</span>';
    }
}