View GitHub Repository XoopsCore

Schedule Inspection
Subscribe
Completed
Push — master ( 33a06a...78daa0 )
by Richard
06:04
created

PublisherMainmenuPlugin::mainmenu()   A

↳ Parent: PublisherMainmenuPlugin

Complexity

Conditions 2
Paths 2

Size

Total Lines 16
Code Lines 9

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 2
eloc 9
nc 2
nop 0
dl 0
loc 16
rs 9.4285
c 0
b 0
f 0
1 
<?php
2 
/*
3 
 You may not change or alter any portion of this comment or credits
4 
 of supporting developers from this source code or any supporting source code
5 
 which is considered copyrighted (c) material of the original comment or credit authors.
6 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
 This program is distributed in the hope that it will be useful,

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
 but WITHOUT ANY WARRANTY; without even the implied warranty of

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
 */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
/**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
 * @copyright       The XOOPS Project http://sourceforge.net/projects/xoops/

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
 * @license         http://www.fsf.org/copyleft/gpl.html GNU public license

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
 * @author          trabis <[email protected]>

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
 */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
class PublisherMainmenuPlugin implements MainmenuPluginInterface

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
     * @return array

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
     */

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
    public function mainmenu()

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
        $helper = \Xoops::getModuleHelper(basename(dirname(dirname(__DIR__))));

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
        $subMenu = array();

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
        // Prevent wasting resources

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
        if ($helper->isCurrentModule()) {

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
            //Todo: Implement submenu;

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
        $ret[] = [

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Comprehensibility
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
$ret was never initialized. Although not strictly required by PHP, it is generally a good practice to add $ret = array(); before regardless.
                                                                                                                                                    

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Adding an explicit array definition is generally preferable to implicit array
definition as it guarantees a stable state of the code.


Let’s take a look at an example:


foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}





As you can see in this example, the array $myArray is initialized the first
time when the foreach loop is entered. You can also see that the value of the
bar key is only written conditionally; thus, its value might result from a
previous iteration.


This might or might not be intended. To make your intention clear, your code
more readible and to avoid accidental bugs, we recommend to add an explicit
initialization $myArray = array() either outside or inside the foreach loop.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
            'name' => $helper->getModule()->getVar('name'),

            


            
                                                        
            
                                    
            
            

                
                    33
                

                                    
                                                    
                
                
                
            'link' => $helper->url(),

            


            
                                                        
            
                                    
            
            

                
                    34
                

                                    
                                                    
                
                
                
            'subMenu' => $subMenu,

            


            
                                                        
            
                                    
            
            

                
                    35
                

                                    
                                                    
                
                
                
        ];

            


            
                                                        
            
                                    
            
            

                
                    36
                

                                    
                                                    
                
                
                
        return $ret;

            


            
                                                        
            
                                    
            
            

                
                    37
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    38
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    39