SearchMainmenuPlugin - Code Metrics - Inspection of "Merge pull request #537 from geekwright/formhidden..." - geekwright/XoopsCore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 33a06a...78daa0 )

by Richard

created 2017-03-15 00:49 UTC

SearchMainmenuPlugin A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	15
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
dl	15
loc	15
rs	10
c	0
b	0
f	0
wmc	1
lcom	0
cbo	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	mainmenu()	9	9	1

How to fix Duplicated Code

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright       The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license         http://www.fsf.org/copyleft/gpl.html GNU public license
 * @author          trabis <[email protected]>
 */
class SearchMainmenuPlugin implements MainmenuPluginInterface

{
    /**
     * @return array
     */
    public function mainmenu()
    {
        $helper = \Xoops::getModuleHelper(basename(dirname(dirname(__DIR__))));
        $ret[] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            'name' => $helper->getModule()->getVar('name'),
            'link' => $helper->url(),
        ];
        return $ret;
    }
}


1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* @copyright The XOOPS Project http://sourceforge.net/projects/xoops/
14		* @license http://www.fsf.org/copyleft/gpl.html GNU public license
15		* @author trabis <[email protected]>
16		*/
17	View Code Duplication	class SearchMainmenuPlugin implements MainmenuPluginInterface
		0 ignored issues – show Duplication introduced 2017-03-15 00:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		/**
20		* @return array
21		*/
22		public function mainmenu()
23		{
24		$helper = \Xoops::getModuleHelper(basename(dirname(dirname(__DIR__))));
25		$ret[] = [
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-15 00:54 UTC by Report Bug Copy Issue Report `$ret` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$ret = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
26		'name' => $helper->getModule()->getVar('name'),
27		'link' => $helper->url(),
28		];
29		return $ret;
30		}
31		}
32

geekwright / XoopsCore

Push — master ( 33a06a...78daa0 )

SearchMainmenuPlugin A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like