AliasCommand::execute() - Code Metrics - Inspection of "Interaction on invalid/missing args on alias cmd" - geekish/crap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c4c610...7af315 )

by Hannah

created 2016-12-18 18:22 UTC

AliasCommand::execute() B

↳ Parent: AliasCommand

Complexity

Conditions	7
Paths	6

Size

Total Lines	62
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	62
rs	7.3333
cc	7
eloc	37
nc	6
nop	2

How to fix Long Method

<?php

namespace Geekish\Crap\Command;

use Geekish\Crap\CrapException;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;

/**
 * Class AliasCommand
 * @package Geekish\Crap\Command
 */
final class AliasCommand extends BaseCommand
{
    /**
     * @inheritDoc
     */
    protected function configure()
    {
        $this->setName("alias");
        $this->setDescription("Defines an alias for a package to be used by crap.");
        $this->addArgument("alias", InputArgument::REQUIRED, "Package alias");
        $this->addArgument("package", InputArgument::REQUIRED, "Package");
    }

    /**
     * @inheritDoc
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $alias = $input->getArgument("alias");
        $package = $input->getArgument("package");

        if (!$this->helper->validateAlias($alias)) {
            throw CrapException::create(
                "The alias `%s` is invalid, it should be lowercase, and match: [a-z0-9_.-]+",
                $alias
            );
        }

        if (!$this->helper->validatePackage($package)) {
            throw CrapException::create(
                "The package `%s` is invalid, it should match: [a-z0-9_.-]+/[a-z0-9_.-]+",
                $input->getArgument("package")
            );
        }

        $override = false;

        if ($this->helper->hasAlias($alias)) {
            $current = $this->helper->getAlias($alias);

            if ($current == $package) {
                $output->writeln(sprintf(
                    "<comment>Alias `%s` to package `%s` already exists, silly.</comment>",
                    $alias,
                    $package
                ));
                return 0;
            }

            $helper = $this->getHelper("question");

            $output->writeln(sprintf(
                "<comment>Alias `%s` exists and is set to `%s`.</comment>",
                $alias,
                $current
            ));

            $ask = sprintf("Override alias `%s` with `%s`? (y/n) ", $alias, $package);
            $question = new ConfirmationQuestion($ask, false);

            if (!$helper->ask($input, $output, $question)) {
                return 0;
            }

            $override = true;
        }

        $this->helper->setAlias($alias, $package);

        $output->writeln(sprintf(
            "<success>Alias `%s` to package `%s` successfully %s.</success>",
            $alias,
            $package,
            $override ? "updated" : "added"
        ));

        return 0;
    }

    protected function interact(InputInterface $input, OutputInterface $output)
    {
        $args = array_values($input->getArguments());

        $helper = $this->getHelper("question");

        if ($args[2] == null && $this->helper->validatePackage($args[1]) === true) {
            $package = $args[1];

            $output->writeln("<comment>You provided the package but no alias!</comment>");

            $message = sprintf("<question>What do you want to use an an alias for `%s`?</question>", $package);
            $question = new Question($message . PHP_EOL, false);

            $alias = $helper->ask($input, $output, $question);

            $input->setArgument("alias", $alias);
            $input->setArgument("package", $package);
        } elseif ($args[2] == null && $this->helper->validateAlias($args[1])) {
            $alias = $args[1];

            $output->writeln("<info>You provided the alias but no package!</info>");

            $message = sprintf("<question>What package do you want to alias `%s` to?</question>", $alias);
            $question = new Question($message . PHP_EOL, false);

            $package = $helper->ask($input, $output, $question);

            $input->setArgument("package", $package);
        } elseif ($this->helper->validateAlias($args[2]) && $this->helper->validatePackage($args[1])) {
            $output->writeln("<info>It looks like you swapped the package and alias.</info>");

            $message = sprintf(
                "<question>Did you mean to alias `%s` to package `%s`?</question> (y/n) ",
                $args[2],
                $args[1]
            );

            $question = new ConfirmationQuestion($message, false);

            if ($helper->ask($input, $output, $question)) {
                $input->setArgument("alias", $args[2]);
                $input->setArgument("package", $args[1]);
            }
        }
    }
}


1			<?php
2
3			namespace Geekish\Crap\Command;
4
5			use Geekish\Crap\CrapException;
6			use Symfony\Component\Console\Input\InputArgument;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Output\OutputInterface;
9			use Symfony\Component\Console\Question\ConfirmationQuestion;
10			use Symfony\Component\Console\Question\Question;
11
12			/**
13			* Class AliasCommand
14			* @package Geekish\Crap\Command
15			*/
16			final class AliasCommand extends BaseCommand
17			{
18			/**
19			* @inheritDoc
20			*/
21			protected function configure()
22			{
23			$this->setName("alias");
24			$this->setDescription("Defines an alias for a package to be used by crap.");
25			$this->addArgument("alias", InputArgument::REQUIRED, "Package alias");
26			$this->addArgument("package", InputArgument::REQUIRED, "Package");
27			}
28
29			/**
30			* @inheritDoc
31			*/
32			protected function execute(InputInterface $input, OutputInterface $output)
33			{
34			$alias = $input->getArgument("alias");
35			$package = $input->getArgument("package");
36
37			if (!$this->helper->validateAlias($alias)) {
38			throw CrapException::create(
39			"The alias `%s` is invalid, it should be lowercase, and match: [a-z0-9_.-]+",
40			$alias
41			);
42			}
43
44			if (!$this->helper->validatePackage($package)) {
45			throw CrapException::create(
46			"The package `%s` is invalid, it should match: [a-z0-9_.-]+/[a-z0-9_.-]+",
47			$input->getArgument("package")
48			);
49			}
50
51			$override = false;
52
53			if ($this->helper->hasAlias($alias)) {
54			$current = $this->helper->getAlias($alias);
55
56			if ($current == $package) {
57			$output->writeln(sprintf(
58			"<comment>Alias `%s` to package `%s` already exists, silly.</comment>",
59			$alias,
60			$package
61			));
62			return 0;
63			}
64
65			$helper = $this->getHelper("question");
66
67			$output->writeln(sprintf(
68			"<comment>Alias `%s` exists and is set to `%s`.</comment>",
69			$alias,
70			$current
71			));
72
73			$ask = sprintf("Override alias `%s` with `%s`? (y/n) ", $alias, $package);
74			$question = new ConfirmationQuestion($ask, false);
75
76			if (!$helper->ask($input, $output, $question)) {
77			return 0;
78			}
79
80			$override = true;
81			}
82
83			$this->helper->setAlias($alias, $package);
84
85			$output->writeln(sprintf(
86			"<success>Alias `%s` to package `%s` successfully %s.</success>",
87			$alias,
88			$package,
89			$override ? "updated" : "added"
90			));
91
92			return 0;
93			}
94
95			protected function interact(InputInterface $input, OutputInterface $output)
96			{
97			$args = array_values($input->getArguments());
98
99			$helper = $this->getHelper("question");
100
101			if ($args[2] == null && $this->helper->validatePackage($args[1]) === true) {
102			$package = $args[1];
103
104			$output->writeln("<comment>You provided the package but no alias!</comment>");
105
106			$message = sprintf("<question>What do you want to use an an alias for `%s`?</question>", $package);
107			$question = new Question($message . PHP_EOL, false);
108
109			$alias = $helper->ask($input, $output, $question);
110
111			$input->setArgument("alias", $alias);
112			$input->setArgument("package", $package);
113			} elseif ($args[2] == null && $this->helper->validateAlias($args[1])) {
114			$alias = $args[1];
115
116			$output->writeln("<info>You provided the alias but no package!</info>");
117
118			$message = sprintf("<question>What package do you want to alias `%s` to?</question>", $alias);
119			$question = new Question($message . PHP_EOL, false);
120
121			$package = $helper->ask($input, $output, $question);
122
123			$input->setArgument("package", $package);
124			} elseif ($this->helper->validateAlias($args[2]) && $this->helper->validatePackage($args[1])) {
125			$output->writeln("<info>It looks like you swapped the package and alias.</info>");
126
127			$message = sprintf(
128			"<question>Did you mean to alias `%s` to package `%s`?</question> (y/n) ",
129			$args[2],
130			$args[1]
131			);
132
133			$question = new ConfirmationQuestion($message, false);
134
135			if ($helper->ask($input, $output, $question)) {
136			$input->setArgument("alias", $args[2]);
137			$input->setArgument("package", $args[1]);
138			}
139			}
140			}
141			}
142

geekish / crap

Push — master ( c4c610...7af315 )

AliasCommand::execute() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like