CalendarController::singleEventAction() - Code Metrics - Inspection of "S3 Avatars and api responses from calendar" - geekhub-php/serve-seattle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#36)

by nonanerz

created 2017-03-24 21:31 UTC

CalendarController::singleEventAction() A

↳ Parent: CalendarController

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	1

<?php

namespace AppBundle\Controller\Api;

use AppBundle\Entity\DTO\DtoEvent;
use AppBundle\Entity\Event;
use AppBundle\Exception\JsonHttpException;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\Routing\Annotation\Route;

class CalendarController extends Controller
{
    /**
     * @Route("/events")
     * @Method({"GET"})
     */
    public function userEventsAction()
    {
        $user = $this->getUser();
        $events = $user->getEvents();
        $calendar = $this->get('app.google_calendar');
        $googleEvents = [];
        foreach ($events as $event) {
            $googleEvents[] = $calendar
                ->getEventById($event->getGoogleId());
        }
        $events = [];
        foreach ($googleEvents as $event) {
            if ($event) {
                $events[] = new DtoEvent($event);
            }
        }
        return new JsonResponse(['events' => $events]);
    }

    /**
     * @Route("/events/{id}")
     * @Method("GET")
     */
    public function singleEventAction($id)
    {
        /** @var Event $event */
        $event = $this->getDoctrine()->getRepository('AppBundle:Event')
            ->findByGoogleId($id);
        $user = $event->getUsers()->first();

        if (!$user) {
            throw new JsonHttpException(404, 'User not found.');
        }
        $googleEvent = $this->get('app.google_calendar')
            ->getEventById($id);
        $event = new DtoEvent($googleEvent);
        return new JsonResponse(['event' => $event]);
    }
}


1			<?php
2
3			namespace AppBundle\Controller\Api;
4
5			use AppBundle\Entity\DTO\DtoEvent;
6			use AppBundle\Entity\Event;
7			use AppBundle\Exception\JsonHttpException;
8			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
9			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
10			use Symfony\Component\HttpFoundation\JsonResponse;
11			use Symfony\Component\Routing\Annotation\Route;
12
13			class CalendarController extends Controller
14			{
15			/**
16			* @Route("/events")
17			* @Method({"GET"})
18			*/
19			public function userEventsAction()
20			{
21			$user = $this->getUser();
22			$events = $user->getEvents();
23			$calendar = $this->get('app.google_calendar');
24			$googleEvents = [];
25			foreach ($events as $event) {
26			$googleEvents[] = $calendar
27			->getEventById($event->getGoogleId());
28			}
29			$events = [];
30			foreach ($googleEvents as $event) {
31			if ($event) {
32			$events[] = new DtoEvent($event);
33			}
34			}
35			return new JsonResponse(['events' => $events]);
36			}
37
38			/**
39			* @Route("/events/{id}")
40			* @Method("GET")
41			*/
42			public function singleEventAction($id)
43			{
44			/** @var Event $event */
45			$event = $this->getDoctrine()->getRepository('AppBundle:Event')
46			->findByGoogleId($id);
47			$user = $event->getUsers()->first();
			0 ignored issues – show Bug introduced 2017-03-24 21:34 UTC by Report Bug Copy Issue Report The method `first` cannot be called on `$event->getUsers()` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
48			if (!$user) {
49			throw new JsonHttpException(404, 'User not found.');
50			}
51			$googleEvent = $this->get('app.google_calendar')
52			->getEventById($id);
53			$event = new DtoEvent($googleEvent);
54			return new JsonResponse(['event' => $event]);
55			}
56			}
57

geekhub-php / serve-seattle

Pull Request — dev (#36)

CalendarController::singleEventAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like