AppBundle\Controller\SurveyController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	124
Duplicated Lines	22.58 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

96.61%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	surveysAction()	0	22	1
A	surveyCreateAction()	7	19	3
B	surveyAction()	7	24	5
B	surveyDeleteAction()	14	29	6

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\Survey\SurveyAnswer;
use AppBundle\Entity\Survey\SurveyType;
use AppBundle\Entity\Survey\Survey;
use AppBundle\Entity\DTO\Filter;
use AppBundle\Form\DTO\SurveyFilterType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

class SurveyController extends Controller
{
    /**
     * @Route("/surveys", name="surveys")
     * @Template("@App/surveys.html.twig")
     *
     * @return array
     */
    public function surveysAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        $filter = new Filter();
        $filterForm = $this->createForm(SurveyFilterType::class, $filter);
        $filterForm->handleRequest($request);

        $surveys = $em->getRepository(Survey::class)->selectSurveysByParams($filter);
        $types = $em->getRepository(SurveyType::class)->selectSurveyTypesByParams($filter);

        return [
            'surveys' => $this->get('knp_paginator')
                ->paginate(
                    $surveys,
                    $request->query->getInt('page', 1),
                    20
                ),
            'types' => $types,
            'filterForm' => $filterForm->createView(),
        ];
    }

    /**
     * @param Survey $survey
     * @Route("/surveys/{id}", name="survey")
     * @Template("@App/survey.html.twig")
     * @ParamConverter("survey", class="AppBundle\Entity\Survey\Survey")
     *
     * @return array
     */
    public function surveyAction(Survey $survey)
    {
        $em = $this->getDoctrine()->getManager();
        if ($survey->isReviewed() == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $survey->setReviewed(true);
            $em->persist($survey);
            $em->flush();
        }
        $answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
        if ($answers) {

This code seems to be duplicated across your project.

            foreach ($answers as $answer) {
                $questions[] = $answer->getQuestion()->getId();

$questions was never initialized. Although not strictly required by PHP, it is generally a good practice to add $questions = array(); before regardless.

                $contents[] = $answer->getContent();

$contents was never initialized. Although not strictly required by PHP, it is generally a good practice to add $contents = array(); before regardless.

            }
            $questionAnswer = array_combine($questions, $contents);

The variable $questions does not seem to be defined for all execution paths leading up to this point.

The variable $contents does not seem to be defined for all execution paths leading up to this point.

        }
        if (!$answers) {
            $questionAnswer = null;
        }

        return [
            'survey' => $survey, 'question_answers' => $questionAnswer,

The variable $questionAnswer does not seem to be defined for all execution paths leading up to this point.

        ];
    }

    /**
     * @param Request $request, SurveyType $surveyType

There is no parameter named $request,. Did you maybe mean $request?

     * @Route("/surveys/create/{survey_type}", name="survey_create")
     * @ParamConverter("surveyType", options={"mapping": {"survey_type": "name"}})
     */
    public function surveyCreateAction(Request $request, SurveyType $surveyType)
    {
        $survey = new Survey();
        $survey->setType($surveyType);
        $form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

This code seems to be duplicated across your project.

            $em = $this->getDoctrine()->getManager();
            $em->persist($survey);
            $em->flush();

            return $this->redirectToRoute('surveys');
        }

        return $this->render('@App/survey.html.twig', array(
            'form' => $form->createView(), 'survey' => $survey, 'question_answers' => null
        ));
    }

    /**
     * @param Request $request, Survey $survey

There is no parameter named $request,. Did you maybe mean $request?

     * @Route("/surveys/delete/{id}", requirements={"id": "\d+"}, name="survey_delete")
     * @ParamConverter("survey", class="AppBundle\Entity\Survey\Survey")
     */
    public function surveyDeleteAction(Request $request, Survey $survey)
    {
        $em = $this->getDoctrine()->getManager();
        $answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
        if ($answers) {

This code seems to be duplicated across your project.

            foreach ($answers as $answer) {
                $questions[] = $answer->getQuestion()->getId();

$questions was never initialized. Although not strictly required by PHP, it is generally a good practice to add $questions = array(); before regardless.

                $contents[] = $answer->getContent();

$contents was never initialized. Although not strictly required by PHP, it is generally a good practice to add $contents = array(); before regardless.

            }
            $questionAnswer = array_combine($questions, $contents);

The variable $questions does not seem to be defined for all execution paths leading up to this point.

The variable $contents does not seem to be defined for all execution paths leading up to this point.

        }
        if (!$answers) {
            $questionAnswer = null;
        }
        $form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

This code seems to be duplicated across your project.

            $em = $this->getDoctrine()->getManager();
            $em->remove($survey);
            $em->flush();

            return $this->redirectToRoute('surveys');
        }

        return $this->render('@App/survey.html.twig', array(
            'form' => $form->createView(), 'survey' => $survey, 'question_answers' => $questionAnswer,

The variable $questionAnswer does not seem to be defined for all execution paths leading up to this point.

        ));
    }
}