AppKernel::getLogDir() - Code Metrics - Inspection of "[WIP] Alpha1" - geekhub-php/serve-seattle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

unknown

created 2017-04-14 19:14 UTC

AppKernel::getLogDir() A

↳ Parent: AppKernel

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\Config\Loader\LoaderInterface;

class AppKernel extends Kernel
{
    public function registerBundles()
    {
        $bundles = [
            new Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
            new Symfony\Bundle\SecurityBundle\SecurityBundle(),
            new Symfony\Bundle\TwigBundle\TwigBundle(),
            new Symfony\Bundle\MonologBundle\MonologBundle(),
            new Symfony\Bundle\SwiftmailerBundle\SwiftmailerBundle(),
            new Doctrine\Bundle\DoctrineBundle\DoctrineBundle(),
            new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
            new Knp\DoctrineBehaviors\Bundle\DoctrineBehaviorsBundle(),
            new Knp\Bundle\PaginatorBundle\KnpPaginatorBundle(),
            new Doctrine\Bundle\MigrationsBundle\DoctrineMigrationsBundle(),
            new Mcfedr\JsonFormBundle\McfedrJsonFormBundle(),
            new Nelmio\CorsBundle\NelmioCorsBundle(),
            new FOS\JsRoutingBundle\FOSJsRoutingBundle(),
            new AppBundle\AppBundle()
        ];

        if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
            $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
            $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
            $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();
            $bundles[] = new Sensio\Bundle\GeneratorBundle\SensioGeneratorBundle();
            $bundles[] = new Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle();
            $bundles[] = new Nelmio\Alice\Bridge\Symfony\NelmioAliceBundle();
            $bundles[] = new Fidry\AliceDataFixtures\Bridge\Symfony\FidryAliceDataFixturesBundle();
            $bundles[] = new Hautelook\AliceBundle\HautelookAliceBundle();
        }

        return $bundles;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getRootDir()
    {
        return __DIR__;
    }

    public function getCacheDir()
    {
        return dirname(__DIR__).'/var/cache/'.$this->getEnvironment();
    }

    public function getLogDir()
    {
        return dirname(__DIR__).'/var/logs';
    }

    public function registerContainerConfiguration(LoaderInterface $loader)
    {
        $loader->load($this->getRootDir().'/config/config_'.$this->getEnvironment().'.yml');
    }
}


1			<?php
2
3			use Symfony\Component\HttpKernel\Kernel;
4			use Symfony\Component\Config\Loader\LoaderInterface;
5
6			class AppKernel extends Kernel
7			{
8			public function registerBundles()
9			{
10			$bundles = [
11			new Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
12			new Symfony\Bundle\SecurityBundle\SecurityBundle(),
13			new Symfony\Bundle\TwigBundle\TwigBundle(),
14			new Symfony\Bundle\MonologBundle\MonologBundle(),
15			new Symfony\Bundle\SwiftmailerBundle\SwiftmailerBundle(),
16			new Doctrine\Bundle\DoctrineBundle\DoctrineBundle(),
17			new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
18			new Knp\DoctrineBehaviors\Bundle\DoctrineBehaviorsBundle(),
19			new Knp\Bundle\PaginatorBundle\KnpPaginatorBundle(),
20			new Doctrine\Bundle\MigrationsBundle\DoctrineMigrationsBundle(),
21			new Mcfedr\JsonFormBundle\McfedrJsonFormBundle(),
22			new Nelmio\CorsBundle\NelmioCorsBundle(),
23			new FOS\JsRoutingBundle\FOSJsRoutingBundle(),
24			new AppBundle\AppBundle()
25			];
26
27			if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
28			$bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
29			$bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
30			$bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();
31			$bundles[] = new Sensio\Bundle\GeneratorBundle\SensioGeneratorBundle();
32			$bundles[] = new Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle();
33			$bundles[] = new Nelmio\Alice\Bridge\Symfony\NelmioAliceBundle();
34			$bundles[] = new Fidry\AliceDataFixtures\Bridge\Symfony\FidryAliceDataFixturesBundle();
35			$bundles[] = new Hautelook\AliceBundle\HautelookAliceBundle();
36			}
37
38			return $bundles;
			0 ignored issues – show Best Practice introduced 2017-04-13 13:18 UTC by Report Bug Copy Issue Report The expression `return $bundles;` seems to be an `array`, but some of its elements' types (`FOS\JsRoutingBundle\FOSJsRoutingBundle`) are incompatible with the return type declared by the interface `Symfony\Component\HttpKe...erface::registerBundles` of type `Symfony\Component\HttpKe...undle\BundleInterface[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
39			}
40
41			public function getRootDir()
42			{
43			return __DIR__;
44			}
45
46			public function getCacheDir()
47			{
48			return dirname(__DIR__).'/var/cache/'.$this->getEnvironment();
49			}
50
51			public function getLogDir()
52			{
53			return dirname(__DIR__).'/var/logs';
54			}
55
56			public function registerContainerConfiguration(LoaderInterface $loader)
57			{
58			$loader->load($this->getRootDir().'/config/config_'.$this->getEnvironment().'.yml');
59			}
60			}
61

geekhub-php / serve-seattle

Pull Request — master (#30)

AppKernel::getLogDir() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like