ImageSubscriber::preUpdate() - Code Metrics - Inspection of "[WIP] Alpha1" - geekhub-php/serve-seattle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by nonanerz

created 2017-03-25 18:22 UTC

ImageSubscriber::preUpdate() A

↳ Parent: ImageSubscriber

Complexity

Conditions	4
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	4
cts	8
cp	0.5
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	4
nop	1
crap	6

<?php

namespace AppBundle\Listener;

use AppBundle\Aws\S3Manager;
use AppBundle\Entity\S3\Image;
use Doctrine\Common\EventSubscriber;
use Doctrine\ORM\Event\LifecycleEventArgs;
use Doctrine\ORM\Event\PreUpdateEventArgs;

class ImageSubscriber implements EventSubscriber
{
    /**
     * @var S3Manager
     */
    private $s3;

    public function __construct(S3Manager $s3)
    {
        $this->s3 = $s3;
    }

    public function getSubscribedEvents()
    {
        return [
            'prePersist',
            'preUpdate',
            'postRemove',
        ];
    }

    /**
     * @param PreUpdateEventArgs $args
     */
    public function preUpdate(PreUpdateEventArgs $args)
    {
        $object = $args->getObject();

        if ($object instanceof Image) {
            if ($object->getFile()) {

                if ($object->getOldS3key()) {
                    $this->s3->removeImage($object->getOldS3key());
                }
                $this->s3->upload($object);
            }
        }
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function prePersist(LifecycleEventArgs $args)
    {
        $object = $args->getObject();

        if ($object instanceof Image) {
            $this->s3->upload($object);
        }
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function postRemove(LifecycleEventArgs $args)
    {
        $object = $args->getObject();

        if ($object instanceof Image) {
            $this->s3->removeImage($object->getS3key());
        }
    }
}


1		<?php
2
3		namespace AppBundle\Listener;
4
5		use AppBundle\Aws\S3Manager;
6		use AppBundle\Entity\S3\Image;
7		use Doctrine\Common\EventSubscriber;
8		use Doctrine\ORM\Event\LifecycleEventArgs;
9		use Doctrine\ORM\Event\PreUpdateEventArgs;
10
11		class ImageSubscriber implements EventSubscriber
12		{
13		/**
14		* @var S3Manager
15		*/
16		private $s3;
17
18	14	public function __construct(S3Manager $s3)
19		{
20	14	$this->s3 = $s3;
21	14	}
22
23	14	public function getSubscribedEvents()
24		{
25		return [
26	14	'prePersist',
27		'preUpdate',
28		'postRemove',
29		];
30		}
31
32		/**
33		* @param PreUpdateEventArgs $args
34		*/
35	5	public function preUpdate(PreUpdateEventArgs $args)
36		{
37	5	$object = $args->getObject();
38
39	5	if ($object instanceof Image) {
40		if ($object->getFile()) {
		0 ignored issues – show Bug introduced 2017-03-24 21:34 UTC by Report Bug Copy Issue Report The method `getFile()` does not seem to exist on `object<AppBundle\Entity\S3\Image>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41		if ($object->getOldS3key()) {
42		$this->s3->removeImage($object->getOldS3key());
43		}
44		$this->s3->upload($object);
45		}
46		}
47	5	}
48
49		/**
50		* @param LifecycleEventArgs $args
51		*/
52	2	public function prePersist(LifecycleEventArgs $args)
53		{
54	2	$object = $args->getObject();
55
56	2	if ($object instanceof Image) {
57		$this->s3->upload($object);
58		}
59	2	}
60
61		/**
62		* @param LifecycleEventArgs $args
63		*/
64		public function postRemove(LifecycleEventArgs $args)
65		{
66		$object = $args->getObject();
67
68		if ($object instanceof Image) {
69		$this->s3->removeImage($object->getS3key());
70		}
71		}
72		}
73

geekhub-php / serve-seattle

Pull Request — master (#30)

ImageSubscriber::preUpdate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like