UserController::listAction() - Code Metrics - Inspection of "Merge pull request #22 from geekhub-php/users" - geekhub-php/serve-seattle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( b5377b...755e12 )

unknown

created 2017-03-15 21:38 UTC

UserController::listAction() A

↳ Parent: UserController

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	0

<?php

namespace AppBundle\Controller\Api;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;

class UserController extends Controller
{
    /**
     * @Route("/users")
     *
     * @Method("GET")
     * @return JsonResponse
     */
    public function listAction()
    {
        $users = $this->getDoctrine()
            ->getRepository('AppBundle:User')
            ->findAll();
        if (!$users) {

            throw new NotFoundHttpException();
        }
        return $this->json(['users' => $users], 200, [], [AbstractNormalizer::GROUPS => ['Short']]);
    }
}


1			<?php
2
3			namespace AppBundle\Controller\Api;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
6			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7			use Symfony\Component\HttpFoundation\JsonResponse;
8			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
9			use Symfony\Component\Routing\Annotation\Route;
10			use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
11
12			class UserController extends Controller
13			{
14			/**
15			* @Route("/users")
16			*
17			* @Method("GET")
18			* @return JsonResponse
19			*/
20			public function listAction()
21			{
22			$users = $this->getDoctrine()
23			->getRepository('AppBundle:User')
24			->findAll();
25			if (!$users) {
			0 ignored issues – show Bug Best Practice introduced 2017-03-15 21:12 UTC by Report Bug Copy Issue Report The expression `$users` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
26			throw new NotFoundHttpException();
27			}
28			return $this->json(['users' => $users], 200, [], [AbstractNormalizer::GROUPS => ['Short']]);
29			}
30			}
31

geekhub-php / serve-seattle

Push — dev ( b5377b...755e12 )

UserController::listAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like