SurveyController - Code Metrics - Inspection of "Survey controllers" - geekhub-php/serve-seattle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#24)

unknown

created 2017-03-18 21:32 UTC

SurveyController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	101
Duplicated Lines	13.86 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	12
lcom	1
cbo	5
dl	14
loc	101
rs	10
c	1
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	surveysAction()	0	12	1
A	surveyAction()	0	17	3
A	surveyCreateAction()	7	19	3
B	surveyDeleteAction()	7	27	5

How to fix Duplicated Code

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\SurveyAnswer;
use AppBundle\Entity\Survey;
use AppBundle\Entity\SurveyType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

class SurveyController extends Controller
{
    /**
     * @Route("/surveys", name="surveys")
     * @Template("@App/surveys.html.twig")
     */
    public function surveysAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $surveys = $em->getRepository(Survey::class)->findSurveyByStatus('submited');
        $surveyTypes = $em->getRepository(SurveyType::class)->findAll();
        $paginator = $this->get('knp_paginator');
        $pagination = $paginator->paginate($surveys, $request->query->getInt('page', 1), 10);

        return [
            'surveys' => $pagination, 'survey_types' => $surveyTypes,
        ];
    }

    /**
     * @param Survey $survey
     * @Route("/surveys/{id}", name="survey")
     * @Template("@App/survey.html.twig")
     * @ParamConverter("survey", class="AppBundle:Survey")
     */
    public function surveyAction(Survey $survey)
    {
        $em = $this->getDoctrine()->getManager();
        $answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
        foreach ($answers as $answer) {
            $questions[] = $answer->getQuestion()->getId();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $contents[] = $answer->getContent();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        $questionAnswer = array_combine($questions, $contents);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        if (!$answers) {
            $questionAnswer = null;
        }

        return [
            'survey' => $survey, 'question_answers' => $questionAnswer,
        ];
    }

    /**
     * @param Request $request, SurveyType $surveyType
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @Route("/survey/create/{survey_type}", name="survey_create")
     * @ParamConverter("surveyType", options={"mapping": {"survey_type": "name"}})
     */
    public function surveyCreateAction(Request $request, SurveyType $surveyType)
    {
        $survey = new Survey();
        $survey->setType($surveyType);
        $form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

            $em = $this->getDoctrine()->getManager();
            $em->persist($survey);
            $em->flush();

            return $this->redirectToRoute('surveys');
        }

        return $this->render('@App/surveyform.html.twig', array(
            'form' => $form->createView(),
        ));
    }

    /**
     * @param Request $request, Survey $survey
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @Route("/survey/delete/{id}", name="survey_delete")
     * @ParamConverter("survey", class="AppBundle:Survey")
     */
    public function surveyDeleteAction(Request $request, Survey $survey)
    {
        $em = $this->getDoctrine()->getManager();
        $answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
        foreach ($answers as $answer) {
            $questions[] = $answer->getQuestion()->getId();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $contents[] = $answer->getContent();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        $questionAnswer = array_combine($questions, $contents);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        if (!$answers) {
            $questionAnswer = null;
        }
        $form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

            $em = $this->getDoctrine()->getManager();
            $em->remove($survey);
            $em->flush();

            return $this->redirectToRoute('surveys');
        }

        return $this->render('@App/survey.html.twig', array(
            'form' => $form->createView(), 'survey' => $survey, 'question_answers' => $questionAnswer,
        ));
    }
}


1		<?php
2
3		namespace AppBundle\Controller;
4
5		use AppBundle\Entity\SurveyAnswer;
6		use AppBundle\Entity\Survey;
7		use AppBundle\Entity\SurveyType;
8		use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
9		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
10		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
11		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
12		use Symfony\Component\HttpFoundation\Request;
13
14		class SurveyController extends Controller
15		{
16		/**
17		* @Route("/surveys", name="surveys")
18		* @Template("@App/surveys.html.twig")
19		*/
20		public function surveysAction(Request $request)
21		{
22		$em = $this->getDoctrine()->getManager();
23		$surveys = $em->getRepository(Survey::class)->findSurveyByStatus('submited');
24		$surveyTypes = $em->getRepository(SurveyType::class)->findAll();
25		$paginator = $this->get('knp_paginator');
26		$pagination = $paginator->paginate($surveys, $request->query->getInt('page', 1), 10);
27
28		return [
29		'surveys' => $pagination, 'survey_types' => $surveyTypes,
30		];
31		}
32
33		/**
34		* @param Survey $survey
35		* @Route("/surveys/{id}", name="survey")
36		* @Template("@App/survey.html.twig")
37		* @ParamConverter("survey", class="AppBundle:Survey")
38		*/
39		public function surveyAction(Survey $survey)
40		{
41		$em = $this->getDoctrine()->getManager();
42		$answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
43		foreach ($answers as $answer) {
44		$questions[] = $answer->getQuestion()->getId();
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report `$questions` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$questions = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
45		$contents[] = $answer->getContent();
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report `$contents` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$contents = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
46		}
47		$questionAnswer = array_combine($questions, $contents);
		0 ignored issues – show Bug introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report The variable `$questions` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report The variable `$contents` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
48		if (!$answers) {
49		$questionAnswer = null;
50		}
51
52		return [
53		'survey' => $survey, 'question_answers' => $questionAnswer,
54		];
55		}
56
57		/**
58		* @param Request $request, SurveyType $surveyType
		0 ignored issues – show Documentation introduced 2017-03-05 12:28 UTC by Report Bug Copy Issue Report There is no parameter named `$request,`. Did you maybe mean `$request`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
59		* @Route("/survey/create/{survey_type}", name="survey_create")
60		* @ParamConverter("surveyType", options={"mapping": {"survey_type": "name"}})
61		*/
62		public function surveyCreateAction(Request $request, SurveyType $surveyType)
63		{
64		$survey = new Survey();
65		$survey->setType($surveyType);
66		$form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
67		$form->handleRequest($request);
68
69	View Code Duplication	if ($form->isSubmitted() && $form->isValid()) {
		0 ignored issues – show Duplication introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		$em = $this->getDoctrine()->getManager();
71		$em->persist($survey);
72		$em->flush();
73
74		return $this->redirectToRoute('surveys');
75		}
76
77		return $this->render('@App/surveyform.html.twig', array(
78		'form' => $form->createView(),
79		));
80		}
81
82		/**
83		* @param Request $request, Survey $survey
		0 ignored issues – show Documentation introduced 2017-03-05 12:28 UTC by Report Bug Copy Issue Report There is no parameter named `$request,`. Did you maybe mean `$request`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
84		* @Route("/survey/delete/{id}", name="survey_delete")
85		* @ParamConverter("survey", class="AppBundle:Survey")
86		*/
87		public function surveyDeleteAction(Request $request, Survey $survey)
88		{
89		$em = $this->getDoctrine()->getManager();
90		$answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
91		foreach ($answers as $answer) {
92		$questions[] = $answer->getQuestion()->getId();
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report `$questions` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$questions = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
93		$contents[] = $answer->getContent();
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report `$contents` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$contents = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
94		}
95		$questionAnswer = array_combine($questions, $contents);
		0 ignored issues – show Bug introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report The variable `$questions` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report The variable `$contents` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
96		if (!$answers) {
97		$questionAnswer = null;
98		}
99		$form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
100		$form->handleRequest($request);
101
102	View Code Duplication	if ($form->isSubmitted() && $form->isValid()) {
		0 ignored issues – show Duplication introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		$em = $this->getDoctrine()->getManager();
104		$em->remove($survey);
105		$em->flush();
106
107		return $this->redirectToRoute('surveys');
108		}
109
110		return $this->render('@App/survey.html.twig', array(
111		'form' => $form->createView(), 'survey' => $survey, 'question_answers' => $questionAnswer,
112		));
113		}
114		}
115

geekhub-php / serve-seattle

Pull Request — dev (#24)

SurveyController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like