DefaultControllerTest::testUpdatePassword() - Code Metrics - Inspection of "[WIP] Alpha1" - geekhub-php/serve-seattle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by nonanerz

created 2017-04-25 11:17 UTC

DefaultControllerTest::testUpdatePassword() A

↳ Parent: DefaultControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	1
eloc	10
nc	1
nop	0

<?php

namespace Tests\AppBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;

class DefaultControllerTest extends WebTestCase
{
    public function testIndex()
    {
        exec('./bin/console d:d:c --env=test');
        exec('./bin/console d:s:c --env=test');
        exec('./bin/console h:f:l -n --env=test');

        $client = static::createClient();

        $crawler = $client->request('GET', '/login');

        $this->assertEquals(200, $client->getResponse()->getStatusCode());

        $this->assertCount(3, $crawler->filter('input'));
    }

    public function testUpdatePassword()
    {
        $client = static::createClient();
        $crawler = $client->request('GET', '/password_update/2');
        $this->assertEquals('200', $client->getResponse()->getStatusCode());

        $form = $crawler->selectButton('Submit')->form();
        $form['reset_password[plainPassword][first]'] = 'new';
        $form['reset_password[plainPassword][second]'] = 'new';
        $client->submit($form);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals(200, $client->getResponse()->getStatusCode());

        exec('./bin/console d:d:d --force --env=test');
    }
}


1			<?php
2
3			namespace Tests\AppBundle\Controller;
4
5			use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
6
7			class DefaultControllerTest extends WebTestCase
8			{
9			public function testIndex()
10			{
11			exec('./bin/console d:d:c --env=test');
12			exec('./bin/console d:s:c --env=test');
13			exec('./bin/console h:f:l -n --env=test');
14
15			$client = static::createClient();
16
17			$crawler = $client->request('GET', '/login');
18
19			$this->assertEquals(200, $client->getResponse()->getStatusCode());
20
21			$this->assertCount(3, $crawler->filter('input'));
22			}
23
24			public function testUpdatePassword()
25			{
26			$client = static::createClient();
27			$crawler = $client->request('GET', '/password_update/2');
28			$this->assertEquals('200', $client->getResponse()->getStatusCode());
29
30			$form = $crawler->selectButton('Submit')->form();
31			$form['reset_password[plainPassword][first]'] = 'new';
32			$form['reset_password[plainPassword][second]'] = 'new';
33			$client->submit($form);
			0 ignored issues – show Documentation introduced 2017-04-01 19:20 UTC by Report Bug Copy Issue Report `$form` is of type `array<string,string,{"re...rd][second]":"string"}>`, but the function expects a `object<Symfony\Component\DomCrawler\Form>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34			$this->assertEquals(200, $client->getResponse()->getStatusCode());
35
36			exec('./bin/console d:d:d --force --env=test');
37			}
38			}
39

geekhub-php / serve-seattle

Pull Request — master (#30)

DefaultControllerTest::testUpdatePassword() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like