AppBundle\Controller\UserController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	2
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	usersListAction()	0	18	2
A	userActivateAction()	0	8	2
A	createActivateUserForm()	0	8	1
A	userAddAction()	0	17	2
A	userEditAction()	0	17	2

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\User;
use AppBundle\Form\User\EditType;
use AppBundle\Form\User\RegistrationType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;

class UserController extends Controller
{
    /**
     * @Route("/users", name="users_list")
     * @Template("@App/users.html.twig")
     *
     * @param Request $request
     * @return array
     */
    public function usersListAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $paginator = $this->get('knp_paginator');
        $users = $paginator->paginate(
            $em->getRepository(User::class)->selectUsersByParams($request->query),
            $request->query->getInt('page', 1),
            10
        );
        $activateForm = [];
        foreach ($users as $user) {
            $activateForm[$user->getId()] = $this->createActivateUserForm($user)->createView();
        }
        return [
            "users" => $users,
            'activateForm' => $activateForm
        ];
    }

    /**
     * @Route("/user/activate/{id}", name="activate_user")
     * @Template("@App/add.html.twig")
     *
     * @Method("PUT")
     * @param  User $user
     * @return RedirectResponse
     */
    public function userActivateAction(User $user)
    {
        $em = $this->getDoctrine()->getManager();
        $user->setStatus($user->isEnabled() ? false : true);
        $em->persist($user);
        $em->flush();
        return $this->redirect($this->generateUrl("users_list"));
    }

    /**
     * Creates a form to activate|deactivate User profile.
     * @param User $user
     * @return \Symfony\Component\Form\Form The form
     */
    private function createActivateUserForm(User $user)
    {
        return $this->createFormBuilder()

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Form\FormConfigBuilder as the method add() does only exist in the following sub-classes of Symfony\Component\Form\FormConfigBuilder: Symfony\Component\Form\FormBuilder. Maybe you want to instanceof check for one of these explicitly?

            ->setAction($this->generateUrl('activate_user', array('id' => $user->getId())))
            ->setMethod('PUT')
            ->add('submit', SubmitType::class)
            ->getForm();
    }

    /**
     * @Route("/user/add", name="add_user")
     * @Template("@App/add.html.twig")
     *
     * @param Request $request
     * @return array|RedirectResponse
     */
    public function userAddAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $user = new User();
        $form = $this->createForm(RegistrationType::class, $user, [
            'action' => $this->generateUrl('add_user'),
            'validation_groups' => array('registration'),
        ]);
        $form->handleRequest($request);
        if ($form->isValid()) {
            $em->persist($user);
            $em->flush();

            return $this->redirect($this->generateUrl("users_list"));
        }
        return ['form' => $form->createView()];
    }

    /**
     * @Route("/user/edit/{id}", name="edit_user")
     * @Template("@App/add.html.twig")
     *
     * @param Request $request
     * @param User $user
     * @return array|RedirectResponse
     */
    public function userEditAction(Request $request, User $user)
    {
        $em = $this->getDoctrine()->getManager();
        $form = $this->createForm(EditType::class, $user, [
            'action' => $this->generateUrl('edit_user', array('id' => $user->getId())),
            'method' => 'POST',
            'validation_groups' => array('edit'),
        ]);
        $form->handleRequest($request);
        if ($form->isValid()) {
            $em->persist($user);
            $em->flush();

            return $this->redirect($this->generateUrl("users_list"));
        }
        return ['form' => $form->createView()];
    }
}