SurveyController - Code Metrics - Inspection of "Survey controllers" - geekhub-php/serve-seattle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#24)

unknown

created 2017-03-11 15:47 UTC

SurveyController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	85
Duplicated Lines	44.71 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	8
c	1
b	0
f	0
lcom	1
cbo	8
dl	38
loc	85
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	surveysAction()	0	12	1
A	surveyAction()	0	9	1
A	surveyCreateAction()	19	19	3
A	surveyDeleteAction()	19	19	3

How to fix Duplicated Code

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\SurveyAnswer;
use AppBundle\Entity\Survey;
use AppBundle\Entity\SurveyType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

class SurveyController extends Controller
{
    /**
     * @Route("/surveys", name="surveys")
     * @Template("@App/surveys.html.twig")
     */
    public function surveysAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $surveys = $em->getRepository(Survey::class)->findSurveyByStatus('submited');
        $surveyTypes = $em->getRepository(SurveyType::class)->findAll();
        $paginator = $this->get('knp_paginator');
        $pagination = $paginator->paginate($surveys, $request->query->getInt('page', 1), 10);

        return [
            'surveys' => $pagination, 'survey_types' => $surveyTypes,
        ];
    }

    /**
     * @param Survey $survey
     * @Route("/survey/{id}", name="survey_get")
     * @Template("@App/survey.html.twig")
     * @ParamConverter("survey", class="AppBundle:Survey")
     */
    public function surveyAction(Survey $survey)
    {
        $em = $this->getDoctrine()->getManager();
        $fields = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);

        return [
            'survey' => $survey, 'fields' => $fields,
        ];
    }

    /**
     * @param Request $request, SurveyType $surveyType
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @Route("/survey/create/{survey_type}", name="survey_create")
     * @ParamConverter("surveyType", options={"mapping": {"survey_type": "name"}})
     */
    public function surveyCreateAction(Request $request, SurveyType $surveyType)

    {
        $survey = new Survey();
        $survey->setType($surveyType);
        $form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->persist($survey);
            $em->flush();

            return $this->redirectToRoute('homepage');
        }

        return $this->render('@App/surveyform.html.twig', array(
            'form' => $form->createView(), 'type' => $surveyType,
        ));
    }

    /**
     * @param Request $request, Survey $survey
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @Route("/survey/delete/{id}", name="survey_delete")
     * @ParamConverter("survey", class="AppBundle:Survey")
     */
    public function surveyDeleteAction(Request $request, Survey $survey)

    {
        $surveyType = $survey->getType();

        $form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->remove($survey);
            $em->flush();

            return $this->redirectToRoute('homepage');
        }

        return $this->render('@App/surveyform.html.twig', array(
            'form' => $form->createView(), 'type' => $surveyType,
        ));
    }
}


1		<?php
2
3		namespace AppBundle\Controller;
4
5		use AppBundle\Entity\SurveyAnswer;
6		use AppBundle\Entity\Survey;
7		use AppBundle\Entity\SurveyType;
8		use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
9		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
10		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
11		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
12		use Symfony\Component\HttpFoundation\Request;
13
14		class SurveyController extends Controller
15		{
16		/**
17		* @Route("/surveys", name="surveys")
18		* @Template("@App/surveys.html.twig")
19		*/
20		public function surveysAction(Request $request)
21		{
22		$em = $this->getDoctrine()->getManager();
23		$surveys = $em->getRepository(Survey::class)->findSurveyByStatus('submited');
24		$surveyTypes = $em->getRepository(SurveyType::class)->findAll();
25		$paginator = $this->get('knp_paginator');
26		$pagination = $paginator->paginate($surveys, $request->query->getInt('page', 1), 10);
27
28		return [
29		'surveys' => $pagination, 'survey_types' => $surveyTypes,
30		];
31		}
32
33		/**
34		* @param Survey $survey
35		* @Route("/survey/{id}", name="survey_get")
36		* @Template("@App/survey.html.twig")
37		* @ParamConverter("survey", class="AppBundle:Survey")
38		*/
39		public function surveyAction(Survey $survey)
40		{
41		$em = $this->getDoctrine()->getManager();
42		$fields = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
43
44		return [
45		'survey' => $survey, 'fields' => $fields,
46		];
47		}
48
49		/**
50		* @param Request $request, SurveyType $surveyType
		0 ignored issues – show Documentation introduced 2017-03-05 12:28 UTC by Report Bug Copy Issue Report There is no parameter named `$request,`. Did you maybe mean `$request`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
51		* @Route("/survey/create/{survey_type}", name="survey_create")
52		* @ParamConverter("surveyType", options={"mapping": {"survey_type": "name"}})
53		*/
54	View Code Duplication	public function surveyCreateAction(Request $request, SurveyType $surveyType)
		0 ignored issues – show Duplication introduced 2017-03-05 12:28 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		$survey = new Survey();
57		$survey->setType($surveyType);
58		$form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
59		$form->handleRequest($request);
60
61		if ($form->isSubmitted() && $form->isValid()) {
62		$em = $this->getDoctrine()->getManager();
63		$em->persist($survey);
64		$em->flush();
65
66		return $this->redirectToRoute('homepage');
67		}
68
69		return $this->render('@App/surveyform.html.twig', array(
70		'form' => $form->createView(), 'type' => $surveyType,
71		));
72		}
73
74		/**
75		* @param Request $request, Survey $survey
		0 ignored issues – show Documentation introduced 2017-03-05 12:28 UTC by Report Bug Copy Issue Report There is no parameter named `$request,`. Did you maybe mean `$request`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
76		* @Route("/survey/delete/{id}", name="survey_delete")
77		* @ParamConverter("survey", class="AppBundle:Survey")
78		*/
79	View Code Duplication	public function surveyDeleteAction(Request $request, Survey $survey)
		0 ignored issues – show Duplication introduced 2017-03-05 12:28 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		{
81		$surveyType = $survey->getType();
82
83		$form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
84		$form->handleRequest($request);
85
86		if ($form->isSubmitted() && $form->isValid()) {
87		$em = $this->getDoctrine()->getManager();
88		$em->remove($survey);
89		$em->flush();
90
91		return $this->redirectToRoute('homepage');
92		}
93
94		return $this->render('@App/surveyform.html.twig', array(
95		'form' => $form->createView(), 'type' => $surveyType,
96		));
97		}
98		}
99

geekhub-php / serve-seattle

Pull Request — dev (#24)

SurveyController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like