SurveyController::surveysAction() - Code Metrics - Inspection of "[WIP] Alpha1" - geekhub-php/serve-seattle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by nonanerz

created 2017-04-04 13:50 UTC

SurveyController::surveysAction() C

↳ Parent: SurveyController

Complexity

Conditions	8
Paths	18

Size

Total Lines	41
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	8

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	41
rs	5.3846
c	1
b	0
f	0
ccs	24
cts	24
cp	1
cc	8
eloc	29
nc	18
nop	1
crap	8

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\Survey\SurveyAnswer;
use AppBundle\Entity\Survey\SurveyType;
use AppBundle\Entity\Survey\Survey;
use AppBundle\Entity\DTO\SurveyFilter;
use AppBundle\Form\SurveyFilterType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

class SurveyController extends Controller
{
    /**
     * @Route("/surveys", name="surveys")
     * @Template("@App/surveys.html.twig")
     *
     * @return array
     */
    public function surveysAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $surveyTypes = $em->getRepository(SurveyType::class)->findAll();
        $paginator = $this->get('knp_paginator');
        $surveys = $em->getRepository(Survey::class)->findSurveyByStatus('submited');
        $filter = new SurveyFilter();
        $filter->setStart($surveys[count($surveys) - 1]->getUpdatedAt());
        $filter->setEnd($surveys[0]->getUpdatedAt());
        $form = $this->createForm(SurveyFilterType::class, $filter);
        $form->handleRequest($request);
        if ($form->isSubmitted() && $form->isValid()) {
            $surveys = $em->getRepository(Survey::class)->findSurveyByParams($filter);
            $pagination = $paginator->paginate($surveys, $request->query->getInt('page', 1), 10);

            return [
                'surveys' => $pagination, 'survey_types' => $surveyTypes,
                'form' => $form->createView(), 'filter_type' => $filter->getType(),
            ];
        }
        $pagination = $paginator->paginate($surveys, $request->query->getInt('page', 1), 10);
        $types = array_fill_keys(['int', 'sp', 'ex', 'sr'], false);
        foreach ($pagination as $item) {
            if ($item->getType()->getName() == 'internship') {
                $types['int'] = true;
            }
            if ($item->getType()->getName() == 'speaker') {
                $types['sp'] = true;
            }
            if ($item->getType()->getName() == 'exit') {
                $types['ex'] = true;
            }
            if ($item->getType()->getName() == 'supervisor') {
                $types['sr'] = true;
            }
        }

        return [
            'surveys' => $pagination, 'survey_types' => $surveyTypes, 'types' => $types, 'form' => $form->createView(),
        ];
    }

    /**
     * @param Survey $survey
     * @Route("/surveys/{id}", name="survey")
     * @Template("@App/survey.html.twig")
     * @ParamConverter("survey", class="AppBundle\Entity\Survey\Survey")
     *
     * @return array
     */
    public function surveyAction(Survey $survey)
    {
        $em = $this->getDoctrine()->getManager();
        if ($survey->isReviewed() == false) {

            $survey->setReviewed(true);
            $em->persist($survey);
            $em->flush();
        }
        $answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
        if ($answers) {

            foreach ($answers as $answer) {
                $questions[] = $answer->getQuestion()->getId();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $contents[] = $answer->getContent();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
            $questionAnswer = array_combine($questions, $contents);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
        if (!$answers) {
            $questionAnswer = null;
        }

        return [
            'survey' => $survey, 'question_answers' => $questionAnswer,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        ];
    }

    /**
     * @param Request $request, SurveyType $surveyType
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @Route("/surveys/create/{survey_type}", name="survey_create")
     * @ParamConverter("surveyType", options={"mapping": {"survey_type": "name"}})
     */
    public function surveyCreateAction(Request $request, SurveyType $surveyType)
    {
        $survey = new Survey();
        $survey->setType($surveyType);
        $form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

            $em = $this->getDoctrine()->getManager();
            $em->persist($survey);
            $em->flush();

            return $this->redirectToRoute('surveys');
        }

        return $this->render('@App/surveyform.html.twig', array(
            'form' => $form->createView(),
        ));
    }

    /**
     * @param Request $request, Survey $survey
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @Route("/surveys/delete/{id}", requirements={"id": "\d+"}, name="survey_delete")
     * @ParamConverter("survey", class="AppBundle\Entity\Survey\Survey")
     */
    public function surveyDeleteAction(Request $request, Survey $survey)
    {
        $em = $this->getDoctrine()->getManager();
        $answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
        if ($answers) {

            foreach ($answers as $answer) {
                $questions[] = $answer->getQuestion()->getId();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $contents[] = $answer->getContent();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
            $questionAnswer = array_combine($questions, $contents);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
        if (!$answers) {
            $questionAnswer = null;
        }
        $form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

            $em = $this->getDoctrine()->getManager();
            $em->remove($survey);
            $em->flush();

            return $this->redirectToRoute('surveys');
        }

        return $this->render('@App/survey.html.twig', array(
            'form' => $form->createView(), 'survey' => $survey, 'question_answers' => $questionAnswer,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        ));
    }
}


1			<?php
2
3			namespace AppBundle\Controller;
4
5			use AppBundle\Entity\Survey\SurveyAnswer;
6			use AppBundle\Entity\Survey\SurveyType;
7			use AppBundle\Entity\Survey\Survey;
8			use AppBundle\Entity\DTO\SurveyFilter;
9			use AppBundle\Form\SurveyFilterType;
10			use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
11			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
12			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
13			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
14			use Symfony\Component\HttpFoundation\Request;
15
16			class SurveyController extends Controller
17			{
18			/**
19			* @Route("/surveys", name="surveys")
20			* @Template("@App/surveys.html.twig")
21			*
22			* @return array
23			*/
24	1		public function surveysAction(Request $request)
25			{
26	1		$em = $this->getDoctrine()->getManager();
27	1		$surveyTypes = $em->getRepository(SurveyType::class)->findAll();
28	1		$paginator = $this->get('knp_paginator');
29	1		$surveys = $em->getRepository(Survey::class)->findSurveyByStatus('submited');
30	1		$filter = new SurveyFilter();
31	1		$filter->setStart($surveys[count($surveys) - 1]->getUpdatedAt());
32	1		$filter->setEnd($surveys[0]->getUpdatedAt());
33	1		$form = $this->createForm(SurveyFilterType::class, $filter);
34	1		$form->handleRequest($request);
35	1		if ($form->isSubmitted() && $form->isValid()) {
36	1		$surveys = $em->getRepository(Survey::class)->findSurveyByParams($filter);
37	1		$pagination = $paginator->paginate($surveys, $request->query->getInt('page', 1), 10);
38
39			return [
40	1		'surveys' => $pagination, 'survey_types' => $surveyTypes,
41	1		'form' => $form->createView(), 'filter_type' => $filter->getType(),
42			];
43			}
44	1		$pagination = $paginator->paginate($surveys, $request->query->getInt('page', 1), 10);
45	1		$types = array_fill_keys(['int', 'sp', 'ex', 'sr'], false);
46	1		foreach ($pagination as $item) {
47	1		if ($item->getType()->getName() == 'internship') {
48	1		$types['int'] = true;
49			}
50	1		if ($item->getType()->getName() == 'speaker') {
51			$types['sp'] = true;
52			}
53	1		if ($item->getType()->getName() == 'exit') {
54			$types['ex'] = true;
55			}
56	1		if ($item->getType()->getName() == 'supervisor') {
57			$types['sr'] = true;
58			}
59			}
60
61			return [
62	1		'surveys' => $pagination, 'survey_types' => $surveyTypes, 'types' => $types, 'form' => $form->createView(),
63			];
64			}
65
66			/**
67			* @param Survey $survey
68			* @Route("/surveys/{id}", name="survey")
69			* @Template("@App/survey.html.twig")
70			* @ParamConverter("survey", class="AppBundle\Entity\Survey\Survey")
71			*
72			* @return array
73			*/
74	1		public function surveyAction(Survey $survey)
75			{
76	1		$em = $this->getDoctrine()->getManager();
77	1		if ($survey->isReviewed() == false) {
			0 ignored issues – show Coding Style Best Practice introduced 2017-04-04 13:34 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
78	1		$survey->setReviewed(true);
79	1		$em->persist($survey);
80	1		$em->flush();
81			}
82	1		$answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
83	1	View Code Duplication	if ($answers) {
			0 ignored issues – show Duplication introduced 2017-03-19 12:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84	1		foreach ($answers as $answer) {
85	1		$questions[] = $answer->getQuestion()->getId();
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report `$questions` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$questions = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
86	1		$contents[] = $answer->getContent();
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report `$contents` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$contents = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
87			}
88	1		$questionAnswer = array_combine($questions, $contents);
			0 ignored issues – show Bug introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report The variable `$questions` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report The variable `$contents` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
89			}
90	1		if (!$answers) {
91			$questionAnswer = null;
92			}
93
94			return [
95	1		'survey' => $survey, 'question_answers' => $questionAnswer,
			0 ignored issues – show Bug introduced 2017-03-19 12:45 UTC by Report Bug Copy Issue Report The variable `$questionAnswer` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
96			];
97			}
98
99			/**
100			* @param Request $request, SurveyType $surveyType
			0 ignored issues – show Documentation introduced 2017-03-05 12:28 UTC by Report Bug Copy Issue Report There is no parameter named `$request,`. Did you maybe mean `$request`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
101			* @Route("/surveys/create/{survey_type}", name="survey_create")
102			* @ParamConverter("surveyType", options={"mapping": {"survey_type": "name"}})
103			*/
104	1		public function surveyCreateAction(Request $request, SurveyType $surveyType)
105			{
106	1		$survey = new Survey();
107	1		$survey->setType($surveyType);
108	1		$form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
109	1		$form->handleRequest($request);
110
111	1	View Code Duplication	if ($form->isSubmitted() && $form->isValid()) {
			0 ignored issues – show Duplication introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112			$em = $this->getDoctrine()->getManager();
113			$em->persist($survey);
114			$em->flush();
115
116			return $this->redirectToRoute('surveys');
117			}
118
119	1		return $this->render('@App/surveyform.html.twig', array(
120	1		'form' => $form->createView(),
121			));
122			}
123
124			/**
125			* @param Request $request, Survey $survey
			0 ignored issues – show Documentation introduced 2017-03-05 12:28 UTC by Report Bug Copy Issue Report There is no parameter named `$request,`. Did you maybe mean `$request`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
126			* @Route("/surveys/delete/{id}", requirements={"id": "\d+"}, name="survey_delete")
127			* @ParamConverter("survey", class="AppBundle\Entity\Survey\Survey")
128			*/
129	1		public function surveyDeleteAction(Request $request, Survey $survey)
130			{
131	1		$em = $this->getDoctrine()->getManager();
132	1		$answers = $em->getRepository(SurveyAnswer::class)->findAnswersBySurvey($survey);
133	1	View Code Duplication	if ($answers) {
			0 ignored issues – show Duplication introduced 2017-03-19 12:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
134	1		foreach ($answers as $answer) {
135	1		$questions[] = $answer->getQuestion()->getId();
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report `$questions` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$questions = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
136	1		$contents[] = $answer->getContent();
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report `$contents` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$contents = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
137			}
138	1		$questionAnswer = array_combine($questions, $contents);
			0 ignored issues – show Bug introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report The variable `$questions` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report The variable `$contents` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
139			}
140	1		if (!$answers) {
141			$questionAnswer = null;
142			}
143	1		$form = $this->createForm(\AppBundle\Form\SurveyType::class, $survey);
144	1		$form->handleRequest($request);
145
146	1	View Code Duplication	if ($form->isSubmitted() && $form->isValid()) {
			0 ignored issues – show Duplication introduced 2017-03-18 21:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147			$em = $this->getDoctrine()->getManager();
148			$em->remove($survey);
149			$em->flush();
150
151			return $this->redirectToRoute('surveys');
152			}
153
154	1		return $this->render('@App/survey.html.twig', array(
155	1		'form' => $form->createView(), 'survey' => $survey, 'question_answers' => $questionAnswer,
			0 ignored issues – show Bug introduced 2017-03-19 12:45 UTC by Report Bug Copy Issue Report The variable `$questionAnswer` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
156			));
157			}
158			}
159

geekhub-php / serve-seattle

Pull Request — master (#30)

SurveyController::surveysAction() C

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like