CustomerController::customerLoginAction() - Code Metrics - Inspection of "add security, oauth, resurs custumers/login" - geekhub-php/CheTheatre - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#137)

unknown

created 2017-03-22 11:58 UTC

CustomerController::customerLoginAction() B

↳ Parent: CustomerController

Complexity

Conditions	6
Paths	6

Size

Total Lines	56
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	47
nc	6
nop	1
dl	0
loc	56
rs	8.7592
c	0
b	0
f	0

How to fix Long Method

<?php

namespace AppBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use AppBundle\Entity\Customer;
use Symfony\Component\HttpFoundation\JsonResponse;

class CustomerController extends Controller
{
    public function customerLoginAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $apiKeyHead = $request->headers->get('API-Key-Token');
        $facebookToken = $request->request->get('social_token');
        $apiKey = uniqid('token_');
        $firstNameHead = $request->request->get('first_name');
        $lastNameHead = $request->request->get('last_name');
        $emailHead = $request->request->get('email');

        $ValidatorResult = $this->get('service_customers_login_validator')
            ->resultOptions($this->getUser(), $apiKeyHead, $facebookToken, $firstNameHead, $lastNameHead, $emailHead);

        switch ($ValidatorResult) {
            case 'social token true':
                $UserFacebook = $this->get('service_facebook_sdk')
                    ->getUserFacebook($facebookToken);
                $userFindApiKey = $em->getRepository('AppBundle:Customer')
                    ->findUsernameByApiKey($apiKeyHead);
                $userFindApiKey->setEmail($UserFacebook->getEmail());
                $userFindApiKey->setFacebookID($UserFacebook->getId());
                $userFindApiKey->setFirstname($UserFacebook->getFirstName());
                $userFindApiKey->setLastname($UserFacebook->getLastName());
                $userFindApiKey->setApiKey($apiKey);
                $em->flush();

                return new JsonResponse('costumer');

            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'Invalid email/first_name/last_name':
                return new JsonResponse('401');
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'customer input of the form':
                $userFindApiKey = $em->getRepository('AppBundle:Customer')
                    ->findUsernameByApiKey($apiKeyHead);
                $userFindApiKey->setFirstname($firstNameHead);
                $userFindApiKey->setLastname($lastNameHead);
                $userFindApiKey->setEmail($emailHead);
                $em->flush();

                return new JsonResponse('customer');
             break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'not valid apiKey':
                return new JsonResponse('403');
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'new costomer':
                $costumer = new Customer();
                $costumer->setUsername('customer');
                $costumer->setApiKey($apiKey);
                $em->persist($costumer);
                $em->flush();

                return new JsonResponse('customer');
             break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }
}


1			<?php
2
3			namespace AppBundle\Controller;
4
5			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
6			use Symfony\Component\HttpFoundation\Request;
7			use AppBundle\Entity\Customer;
8			use Symfony\Component\HttpFoundation\JsonResponse;
9
10			class CustomerController extends Controller
11			{
12			public function customerLoginAction(Request $request)
13			{
14			$em = $this->getDoctrine()->getManager();
15			$apiKeyHead = $request->headers->get('API-Key-Token');
16			$facebookToken = $request->request->get('social_token');
17			$apiKey = uniqid('token_');
18			$firstNameHead = $request->request->get('first_name');
19			$lastNameHead = $request->request->get('last_name');
20			$emailHead = $request->request->get('email');
21
22			$ValidatorResult = $this->get('service_customers_login_validator')
23			->resultOptions($this->getUser(), $apiKeyHead, $facebookToken, $firstNameHead, $lastNameHead, $emailHead);
24
25			switch ($ValidatorResult) {
26			case 'social token true':
27			$UserFacebook = $this->get('service_facebook_sdk')
28			->getUserFacebook($facebookToken);
29			$userFindApiKey = $em->getRepository('AppBundle:Customer')
30			->findUsernameByApiKey($apiKeyHead);
31			$userFindApiKey->setEmail($UserFacebook->getEmail());
32			$userFindApiKey->setFacebookID($UserFacebook->getId());
33			$userFindApiKey->setFirstname($UserFacebook->getFirstName());
34			$userFindApiKey->setLastname($UserFacebook->getLastName());
35			$userFindApiKey->setApiKey($apiKey);
36			$em->flush();
37
38			return new JsonResponse('costumer');
39
40			break;
			0 ignored issues – show Unused Code introduced 2017-03-22 12:13 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
41			case 'Invalid email/first_name/last_name':
42			return new JsonResponse('401');
43			break;
			0 ignored issues – show Unused Code introduced 2017-03-22 12:13 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
44			case 'customer input of the form':
45			$userFindApiKey = $em->getRepository('AppBundle:Customer')
46			->findUsernameByApiKey($apiKeyHead);
47			$userFindApiKey->setFirstname($firstNameHead);
48			$userFindApiKey->setLastname($lastNameHead);
49			$userFindApiKey->setEmail($emailHead);
50			$em->flush();
51
52			return new JsonResponse('customer');
53			break;
			0 ignored issues – show Unused Code introduced 2017-03-22 12:13 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
54			case 'not valid apiKey':
55			return new JsonResponse('403');
56			break;
			0 ignored issues – show Unused Code introduced 2017-03-22 12:13 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
57			case 'new costomer':
58			$costumer = new Customer();
59			$costumer->setUsername('customer');
60			$costumer->setApiKey($apiKey);
61			$em->persist($costumer);
62			$em->flush();
63
64			return new JsonResponse('customer');
65			break;
			0 ignored issues – show Unused Code introduced 2017-03-22 12:13 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
66			}
67			}
68			}
69

geekhub-php / CheTheatre

Pull Request — master (#137)

CustomerController::customerLoginAction() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like