AppBundle\Repository\PerformanceEventRepository

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	1	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	findByDateRangeAndSlug()	0	25	3

<?php

namespace AppBundle\Repository;

class PerformanceEventRepository extends AbstractRepository
{
    /**
     * @param \DateTime $fromDate
     * @param \DateTime $toDate
     * @param string $limit
     * @param null $performanceSlug
     * @return mixed
     */
    public function findByDateRangeAndSlug(
        \DateTime $fromDate,
        \DateTime $toDate,
        $limit = null,
        $performanceSlug = null
    ) {
        $qb = $this->createQueryBuilder('u')
            ->where('u.dateTime BETWEEN :from AND :to')
            ->setParameter('from', $fromDate->format('Y-m-d H:i'))
            ->setParameter('to', $toDate->format('Y-m-d H:i'))
            ->orderBy('u.dateTime', 'ASC')
        ;

        if ($limit) {

The expression $limit of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $qb->setMaxResults($limit);
        }

        if ($performanceSlug) {
            $qb->join('u.performance', 'p')->andWhere('p.slug = :slug')->setParameter('slug', $performanceSlug);
        }

        $query = $qb->getQuery();

        return $query->execute();
    }
}