Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
18 | class UserController extends Controller |
||
19 | { |
||
20 | /** |
||
21 | * @param Request $request |
||
22 | * |
||
23 | * @Post("/users/register") |
||
24 | * |
||
25 | * @return View |
||
26 | */ |
||
27 | public function registerAction(Request $request): View |
||
46 | |||
47 | /** |
||
48 | * @param Request $request |
||
49 | * |
||
50 | * @Post("/users/login/update") |
||
51 | * |
||
52 | * @return View |
||
53 | */ |
||
54 | View Code Duplication | public function loginUpdateAction(Request $request): View |
|
66 | |||
67 | /** |
||
68 | * @param Request $request |
||
69 | * |
||
70 | * @Post("/users/login/social") |
||
71 | * |
||
72 | * @return View |
||
73 | */ |
||
74 | View Code Duplication | public function loginSocialAction(Request $request): View |
|
86 | |||
87 | /** |
||
88 | * @param Request $request |
||
89 | * |
||
90 | * @Post("/users/logout") |
||
91 | * |
||
92 | * @return View |
||
93 | */ |
||
94 | public function logoutAction(Request $request): View |
||
107 | |||
108 | /** |
||
109 | * @param Request $request |
||
110 | * |
||
111 | * @Get("/users/me") |
||
112 | * |
||
113 | * @return View |
||
114 | */ |
||
115 | View Code Duplication | public function meAction(Request $request): View |
|
124 | } |
||
125 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.