PerformanceEventRepository::getById() - Code Metrics - Inspection of "Merge pull request #151 from geekhub-php/ticket_ge..." - geekhub-php/CheTheatre - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5bb9e4...33b9a4 )

by Serhii

created 2017-05-18 08:40 UTC

PerformanceEventRepository::getById() A

↳ Parent: PerformanceEventRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	5
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	10
rs	9.4285
ccs	0
cts	0
cp	0
crap	6

<?php

namespace AppBundle\Repository;

use AppBundle\Entity\PerformanceEvent;
use AppBundle\Exception\NotFoundException;

class PerformanceEventRepository extends AbstractRepository
{
    /**
     * @param \DateTime $fromDate
     * @param \DateTime $toDate
     * @param string $limit
     * @param null $performanceSlug
     * @return mixed
     */
    public function findByDateRangeAndSlug(
        \DateTime $fromDate,
        \DateTime $toDate,
        $limit = null,
        $performanceSlug = null
    ) {
        $qb = $this->createQueryBuilder('u')
            ->where('u.dateTime BETWEEN :from AND :to')
            ->setParameter('from', $fromDate->format('Y-m-d H:i'))
            ->setParameter('to', $toDate->format('Y-m-d H:i'))
            ->orderBy('u.dateTime', 'ASC')
        ;

        if ($limit) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $qb->setMaxResults($limit);
        }

        if ($performanceSlug) {
            $qb->join('u.performance', 'p')->andWhere('p.slug = :slug')->setParameter('slug', $performanceSlug);
        }

        $query = $qb->getQuery();

        return $query->execute();
    }

    /**
     * Get PerformanceEvent by ID
     *
     * @param int $id
     *
     * @return PerformanceEvent
     * @throws NotFoundException
     */
    public function getById(int $id): PerformanceEvent
    {
        /** @var PerformanceEvent $performanceEvent */
        $performanceEvent = $this->find($id);
        if (!$performanceEvent) {
            throw new NotFoundException('Performance Event not found by ID: '.$id);
        }

        return $performanceEvent;
    }
}


1		<?php
2
3		namespace AppBundle\Repository;
4
5		use AppBundle\Entity\PerformanceEvent;
6		use AppBundle\Exception\NotFoundException;
7	2
8		class PerformanceEventRepository extends AbstractRepository
9	2	{
10	2	/**
11	2	* @param \DateTime $fromDate
12	2	* @param \DateTime $toDate
13	2	* @param string $limit
14		* @param null $performanceSlug
15		* @return mixed
16	2	*/
17		public function findByDateRangeAndSlug(
18		\DateTime $fromDate,
19		\DateTime $toDate,
20	2	$limit = null,
21		$performanceSlug = null
22	2	) {
23		$qb = $this->createQueryBuilder('u')
24		->where('u.dateTime BETWEEN :from AND :to')
25		->setParameter('from', $fromDate->format('Y-m-d H:i'))
26		->setParameter('to', $toDate->format('Y-m-d H:i'))
27		->orderBy('u.dateTime', 'ASC')
28		;
29
30		if ($limit) {
		0 ignored issues – show Bug Best Practice introduced 2017-04-18 06:47 UTC by Report Bug Copy Issue Report The expression `$limit` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
31		$qb->setMaxResults($limit);
32		}
33
34		if ($performanceSlug) {
35		$qb->join('u.performance', 'p')->andWhere('p.slug = :slug')->setParameter('slug', $performanceSlug);
36		}
37
38		$query = $qb->getQuery();
39
40		return $query->execute();
41		}
42
43		/**
44		* Get PerformanceEvent by ID
45		*
46		* @param int $id
47		*
48		* @return PerformanceEvent
49		* @throws NotFoundException
50		*/
51		public function getById(int $id): PerformanceEvent
52		{
53		/** @var PerformanceEvent $performanceEvent */
54		$performanceEvent = $this->find($id);
55		if (!$performanceEvent) {
56		throw new NotFoundException('Performance Event not found by ID: '.$id);
57		}
58
59		return $performanceEvent;
60		}
61		}
62

geekhub-php / CheTheatre

Push — master ( 5bb9e4...33b9a4 )

PerformanceEventRepository::getById() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like