PerformanceEventsController::cgetAction() - Code Metrics - Inspection of "Update tests" - geekhub-php/CheTheatre - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#162)

unknown

created 2017-05-18 20:01 UTC

PerformanceEventsController::cgetAction() B

↳ Parent: PerformanceEventsController

Complexity

Conditions	6
Paths	10

Size

Total Lines	54
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	29
CRAP Score	6.0012

Importance

Changes

Metric	Value
cc	6
eloc	30
nc	10
nop	1
dl	0
loc	54
ccs	29
cts	30
cp	0.9667
crap	6.0012
rs	8.7449
c	0
b	0
f	0

How to fix Long Method

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\PerformanceEvent;
use AppBundle\Entity\Ticket;
use FOS\RestBundle\Controller\Annotations\Get;
use FOS\RestBundle\Request\ParamFetcher;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use FOS\RestBundle\Controller\Annotations\View as RestView;
use FOS\RestBundle\Controller\Annotations\RouteResource;
use FOS\RestBundle\Controller\Annotations\QueryParam;
use AppBundle\Model\PerformanceEventsResponse;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

/**
 * @RouteResource("PerformanceEvent")
 */
class PerformanceEventsController extends Controller
{
    const MAX_DAYS_PER_GET = 367;

    /**
     * @Get("/performanceevents")
     * @QueryParam(
     *     name="fromDate",
     *     default="today",
     *     requirements="\d{2}-\d{2}-\d{4}|today" ,
     *     description="Find entries from this date, fromat=dd-mm-yyyy"
     * )
     * @QueryParam(
     *     name="toDate",
     *     default="+1 Year",
     *     requirements="\d{2}-\d{2}-\d{4}|\+1 Year",
     *     description="Find entries to this date, fromat=dd-mm-yyyy"
     * )
     * @QueryParam(name="limit", description="Count of entities in collection")
     * @QueryParam(name="performance", description="Performance slug")
     * @QueryParam(
     *     name="locale",
     *     requirements="uk|en",
     *     default="uk",
     *     description="Selects language of data you want to receive"
     * )
     *
     * @RestView
     */
    public function cgetAction(ParamFetcher $paramFetcher)
    {
        $em = $this->getDoctrine()->getManager();

        $dateDiff = strtotime($paramFetcher->get('toDate')) - strtotime($paramFetcher->get('fromDate'));

        if (self::MAX_DAYS_PER_GET < abs(floor($dateDiff/(60*60*24)))) {
            throw new BadRequestHttpException(sprintf('You can\'t get more than "%s" days', self::MAX_DAYS_PER_GET));
        }

        $performanceEvents = $em->getRepository('AppBundle:PerformanceEvent')
            ->findByDateRangeAndSlug(
                new \DateTime($paramFetcher->get('fromDate')),
                new \DateTime($paramFetcher->get('toDate')),
                $paramFetcher->get('limit'),
                $paramFetcher->get('performance')
            )
        ;

        $performanceEventsTranslated = [];

        foreach ($performanceEvents as $performanceEvent) {

            /** @var PerformanceEvent $performanceEvent */
            $performanceEvent->setLocale($paramFetcher->get('locale'));
            $em->refresh($performanceEvent);

            $performanceEvent->getPerformance()->setLocale($paramFetcher->get('locale'));
            $em->refresh($performanceEvent->getPerformance());

            $performanceEvent->getVenue()->setLocale($paramFetcher->get('locale'));
            $em->refresh($performanceEvent->getVenue());

            if ($performanceEvent->getTranslations()) {
                $performanceEvent->unsetTranslations();
            }

            if ($performanceEvent->getPerformance()->getTranslations()) {
                $performanceEvent->getPerformance()->unsetTranslations();
            }

            if ($performanceEvent->getVenue()->getTranslations()) {
                $performanceEvent->getVenue()->unsetTranslations();
            }
            $performanceEventsTranslated[] = $performanceEvent;
        }

        $performanceEvents = $performanceEventsTranslated;

        $performanceEventsResponse = new PerformanceEventsResponse();
        $performanceEventsResponse->setPerformanceEvents($performanceEvents);

        return $performanceEventsResponse;
    }

    /**
     * @Get("/performanceevents/{id}", requirements={"id" = "\d+"})
     * @ParamConverter("performanceEvent", class="AppBundle:PerformanceEvent")
     * @QueryParam(
     *     name="locale",
     *     requirements="uk|en",
     *     default="uk",
     *     description="Selects language of data you want to receive"
     * )
     * @QueryParam(
     *     name="id",
     *     requirements="\d+",
     *     description="PerformanceEvent ID"
     * )
     * @RestView
     */
    public function getAction(ParamFetcher $paramFetcher, PerformanceEvent $performanceEvent)
    {
        $em = $this->getDoctrine()->getManager();

        $performanceEvent->setLocale($paramFetcher->get('locale'));
        $em->refresh($performanceEvent);

        $performanceEvent->getPerformance()->setLocale($paramFetcher->get('locale'));
        $em->refresh($performanceEvent->getPerformance());

        $performanceEvent->getVenue()->setLocale($paramFetcher->get('locale'));
        $em->refresh($performanceEvent->getVenue());

        if ($performanceEvent->getTranslations()) {
            $performanceEvent->unsetTranslations();
        }

        if ($performanceEvent->getPerformance()->getTranslations()) {
            $performanceEvent->getPerformance()->unsetTranslations();
        }

        if ($performanceEvent->getVenue()->getTranslations()) {
            $performanceEvent->getVenue()->unsetTranslations();
        }

        return $performanceEvent;
    }

    /**
     * @Get("/performanceevents/{id}/tickets", requirements={"id" = "\d+"})
     * @RestView(serializerGroups={"get_ticket"})
     * @ParamConverter("performanceEvent", class="AppBundle:PerformanceEvent")
     */
    public function cgetTicketsAction(PerformanceEvent $performanceEvent)
    {
        $em = $this->getDoctrine()->getManager();
        $tickets = $em
            ->getRepository(Ticket::class)
            ->findBy(['performanceEvent' => $performanceEvent]);

        return $tickets;
    }


    /**
     * @Get("/performanceevents/{id}/pricecategories", requirements={"id" = "\d+"})
     * @RestView
     * @ParamConverter("performanceEvent", class="AppBundle:PerformanceEvent")
     * @QueryParam(
     *     name="locale",
     *     requirements="uk|en",
     *     default="uk",
     *     description="Selects language of data you want to receive"
     * )
     * @QueryParam(
     *     name="id",
     *     requirements="\d+",
     *     description="PerformanceEvent ID"
     * )
     */
    public function getPriceCategoriesAction(ParamFetcher $paramFetcher, PerformanceEvent $performanceEvent)
    {
        $priceCategory = $performanceEvent->getPriceCategories();

        $em = $this->getDoctrine()->getManager();

        foreach ($priceCategory as $category) {
            $category->getVenueSector()->setLocale($paramFetcher->get('locale'));
            $em->refresh($category->getVenueSector());

            if ($category->getVenueSector()->getTranslations()) {
                $category->getVenueSector()->unsetTranslations();
            }
        }
        return $priceCategory;
    }
}


1		<?php
2
3		namespace AppBundle\Controller;
4
5		use AppBundle\Entity\PerformanceEvent;
6		use AppBundle\Entity\Ticket;
7		use FOS\RestBundle\Controller\Annotations\Get;
8		use FOS\RestBundle\Request\ParamFetcher;
9		use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
10		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
11		use FOS\RestBundle\Controller\Annotations\View as RestView;
12		use FOS\RestBundle\Controller\Annotations\RouteResource;
13		use FOS\RestBundle\Controller\Annotations\QueryParam;
14		use AppBundle\Model\PerformanceEventsResponse;
15		use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
16
17		/**
18		* @RouteResource("PerformanceEvent")
19		*/
20		class PerformanceEventsController extends Controller
21		{
22		const MAX_DAYS_PER_GET = 367;
23
24		/**
25		* @Get("/performanceevents")
26		* @QueryParam(
27		* name="fromDate",
28		* default="today",
29		* requirements="\d{2}-\d{2}-\d{4}\|today" ,
30		* description="Find entries from this date, fromat=dd-mm-yyyy"
31		* )
32		* @QueryParam(
33		* name="toDate",
34		* default="+1 Year",
35		* requirements="\d{2}-\d{2}-\d{4}\|\+1 Year",
36		* description="Find entries to this date, fromat=dd-mm-yyyy"
37		* )
38		* @QueryParam(name="limit", description="Count of entities in collection")
39		* @QueryParam(name="performance", description="Performance slug")
40		* @QueryParam(
41		* name="locale",
42		* requirements="uk\|en",
43		* default="uk",
44		* description="Selects language of data you want to receive"
45		* )
46		*
47		* @RestView
48		*/
49	5	public function cgetAction(ParamFetcher $paramFetcher)
50		{
51	5	$em = $this->getDoctrine()->getManager();
52
53	5	$dateDiff = strtotime($paramFetcher->get('toDate')) - strtotime($paramFetcher->get('fromDate'));
54
55	5	if (self::MAX_DAYS_PER_GET < abs(floor($dateDiff/(606024)))) {
56		throw new BadRequestHttpException(sprintf('You can\'t get more than "%s" days', self::MAX_DAYS_PER_GET));
57		}
58
59	5	$performanceEvents = $em->getRepository('AppBundle:PerformanceEvent')
60	5	->findByDateRangeAndSlug(
61	5	new \DateTime($paramFetcher->get('fromDate')),
62	5	new \DateTime($paramFetcher->get('toDate')),
63	5	$paramFetcher->get('limit'),
64	5	$paramFetcher->get('performance')
65		)
66		;
67
68	5	$performanceEventsTranslated = [];
69
70	5	foreach ($performanceEvents as $performanceEvent) {
71
72		/** @var PerformanceEvent $performanceEvent */
73	5	$performanceEvent->setLocale($paramFetcher->get('locale'));
74	5	$em->refresh($performanceEvent);
75
76	5	$performanceEvent->getPerformance()->setLocale($paramFetcher->get('locale'));
77	5	$em->refresh($performanceEvent->getPerformance());
78
79	5	$performanceEvent->getVenue()->setLocale($paramFetcher->get('locale'));
80	5	$em->refresh($performanceEvent->getVenue());
81
82	5	if ($performanceEvent->getTranslations()) {
83	5	$performanceEvent->unsetTranslations();
84		}
85
86	5	if ($performanceEvent->getPerformance()->getTranslations()) {
87	5	$performanceEvent->getPerformance()->unsetTranslations();
88		}
89
90	5	if ($performanceEvent->getVenue()->getTranslations()) {
91	5	$performanceEvent->getVenue()->unsetTranslations();
92		}
93	5	$performanceEventsTranslated[] = $performanceEvent;
94		}
95
96	5	$performanceEvents = $performanceEventsTranslated;
97
98	5	$performanceEventsResponse = new PerformanceEventsResponse();
99	5	$performanceEventsResponse->setPerformanceEvents($performanceEvents);
100
101	5	return $performanceEventsResponse;
102		}
103
104		/**
105		* @Get("/performanceevents/{id}", requirements={"id" = "\d+"})
106		* @ParamConverter("performanceEvent", class="AppBundle:PerformanceEvent")
107		* @QueryParam(
108		* name="locale",
109		* requirements="uk\|en",
110		* default="uk",
111		* description="Selects language of data you want to receive"
112		* )
113		* @QueryParam(
114		* name="id",
115		* requirements="\d+",
116		* description="PerformanceEvent ID"
117		* )
118		* @RestView
119		*/
120	1	public function getAction(ParamFetcher $paramFetcher, PerformanceEvent $performanceEvent)
121		{
122	1	$em = $this->getDoctrine()->getManager();
123
124	1	$performanceEvent->setLocale($paramFetcher->get('locale'));
125	1	$em->refresh($performanceEvent);
126
127	1	$performanceEvent->getPerformance()->setLocale($paramFetcher->get('locale'));
128	1	$em->refresh($performanceEvent->getPerformance());
129
130	1	$performanceEvent->getVenue()->setLocale($paramFetcher->get('locale'));
131	1	$em->refresh($performanceEvent->getVenue());
132
133	1	if ($performanceEvent->getTranslations()) {
134	1	$performanceEvent->unsetTranslations();
135		}
136
137	1	if ($performanceEvent->getPerformance()->getTranslations()) {
138	1	$performanceEvent->getPerformance()->unsetTranslations();
139		}
140
141	1	if ($performanceEvent->getVenue()->getTranslations()) {
142	1	$performanceEvent->getVenue()->unsetTranslations();
143		}
144
145	1	return $performanceEvent;
146		}
147
148		/**
149		* @Get("/performanceevents/{id}/tickets", requirements={"id" = "\d+"})
150		* @RestView(serializerGroups={"get_ticket"})
151		* @ParamConverter("performanceEvent", class="AppBundle:PerformanceEvent")
152		*/
153	1	public function cgetTicketsAction(PerformanceEvent $performanceEvent)
154		{
155	1	$em = $this->getDoctrine()->getManager();
156		$tickets = $em
157	1	->getRepository(Ticket::class)
158	1	->findBy(['performanceEvent' => $performanceEvent]);
159
160	1	return $tickets;
161		}
162
163
164		/**
165		* @Get("/performanceevents/{id}/pricecategories", requirements={"id" = "\d+"})
166		* @RestView
167		* @ParamConverter("performanceEvent", class="AppBundle:PerformanceEvent")
168		* @QueryParam(
169		* name="locale",
170		* requirements="uk\|en",
171		* default="uk",
172		* description="Selects language of data you want to receive"
173		* )
174		* @QueryParam(
175		* name="id",
176		* requirements="\d+",
177		* description="PerformanceEvent ID"
178		* )
179		*/
180	1	public function getPriceCategoriesAction(ParamFetcher $paramFetcher, PerformanceEvent $performanceEvent)
181		{
182	1	$priceCategory = $performanceEvent->getPriceCategories();
183
184	1	$em = $this->getDoctrine()->getManager();
185
186	1	foreach ($priceCategory as $category) {
187	1	$category->getVenueSector()->setLocale($paramFetcher->get('locale'));
188	1	$em->refresh($category->getVenueSector());
189
190	1	if ($category->getVenueSector()->getTranslations()) {
191	1	$category->getVenueSector()->unsetTranslations();
192		}
193		}
194	1	return $priceCategory;
195		}
196		}
197

geekhub-php / CheTheatre

Pull Request — master (#162)

PerformanceEventsController::cgetAction() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like