geekhub-php /
CheTheatre
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like PerformanceEventAdmin often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PerformanceEventAdmin, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 19 | class PerformanceEventAdmin extends Admin |
||
| 20 | { |
||
| 21 | protected $baseRouteName = 'AppBundle\Entity\PerformanceEvent'; |
||
| 22 | protected $baseRoutePattern = 'PerformanceEvent'; |
||
| 23 | protected $datagridValues = [ |
||
| 24 | 1 | '_sort_order' => 'DESC', |
|
| 25 | '_sort_by' => 'dateTime', |
||
| 26 | ]; |
||
| 27 | 1 | protected $seatPrice = []; |
|
| 28 | 1 | ||
| 29 | 1 | /** |
|
| 30 | 1 | * @var EntityManager |
|
| 31 | */ |
||
| 32 | 1 | protected $em; |
|
| 33 | |||
| 34 | /** |
||
| 35 | * @param RouteCollection $collection |
||
| 36 | */ |
||
| 37 | protected function configureRoutes(RouteCollection $collection) |
||
| 38 | 1 | { |
|
| 39 | $collection |
||
| 40 | 1 | ->add('getVenue') |
|
| 41 | ->add('deletePriceCategories') |
||
| 42 | ; |
||
| 43 | } |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @param FormMapper $formMapper |
||
| 47 | 2 | * |
|
| 48 | * @return void |
||
| 49 | */ |
||
| 50 | 2 | protected function configureFormFields(FormMapper $formMapper) |
|
| 51 | 2 | { |
|
| 52 | 2 | $queryRowsForSale = $this->getEm()->getRepository('AppBundle:RowsForSale') |
|
| 53 | 2 | ->findVenueSectorsByPerformanceEventQueryBuilder($this->getSubject()); |
|
| 54 | |||
| 55 | $formMapper |
||
| 56 | ->with('PerformanceEvents', ['class'=>'col-lg-12']) |
||
| 57 | 2 | ->add('performance', 'sonata_type_model') |
|
| 58 | ->add( |
||
| 59 | 'dateTime', |
||
| 60 | 2 | 'sonata_type_datetime_picker', |
|
| 61 | [ |
||
| 62 | 'dp_side_by_side' => true, |
||
| 63 | 'dp_use_current' => false, |
||
| 64 | 'dp_use_seconds' => false, |
||
| 65 | 'format' => "dd/MM/yyyy HH:mm", |
||
| 66 | ] |
||
| 67 | 2 | ) |
|
| 68 | ->add('venue') |
||
| 69 | ->end() |
||
| 70 | 2 | ->with('PriceCategory', ['class'=>'col-lg-12']) |
|
| 71 | 2 | ->add('priceCategories', 'sonata_type_collection', [ |
|
| 72 | 'by_reference' => true, |
||
| 73 | 2 | 'required' => false, |
|
| 74 | 'cascade_validation' => true, |
||
| 75 | 'type_options' => [ |
||
| 76 | 'delete' => true, |
||
| 77 | ], |
||
| 78 | 'label' => false, |
||
| 79 | ], [ |
||
| 80 | 'inline' => 'table', |
||
| 81 | 'edit' => 'inline', |
||
| 82 | 'sortable' => 'position', |
||
| 83 | 'link_parameters' => [ |
||
| 84 | 'performanceEvent_id' => $this->getSubject()->getId(), |
||
| 85 | ], |
||
| 86 | ]) |
||
| 87 | ->end() |
||
| 88 | ->with('EnableSale', ['class'=>'col-lg-12']) |
||
| 89 | ->add('seriesDate', 'sonata_type_datetime_picker', [ |
||
| 90 | 'dp_side_by_side' => true, |
||
| 91 | 'dp_use_current' => true, |
||
| 92 | 'dp_use_seconds' => false, |
||
| 93 | 'format' => "dd/MM/yyyy HH:mm", |
||
| 94 | 'required' => false, |
||
| 95 | ]) |
||
| 96 | ->add('rowsForSale', 'sonata_type_model', [ |
||
| 97 | 'class' => RowsForSale::class, |
||
| 98 | 'required' => false, |
||
| 99 | 'multiple' => true, |
||
| 100 | 'query' => $queryRowsForSale, |
||
| 101 | ]) |
||
| 102 | ; |
||
| 103 | if ($this->getSubject()->isEnableSale() !== true) { |
||
| 104 | $formMapper |
||
| 105 | ->add('seriesNumber', null, [ |
||
| 106 | 'required' => false, |
||
| 107 | ]) |
||
| 108 | ->add('sale', 'checkbox', [ |
||
| 109 | 'required' => false, |
||
| 110 | 'label' => 'Enable Sale', |
||
| 111 | ]) |
||
| 112 | ->end() |
||
| 113 | ; |
||
| 114 | } |
||
| 115 | if ($this->getSubject()->isEnableSale() === true) { |
||
| 116 | $formMapper |
||
| 117 | ->add('seriesNumber', null, [ |
||
| 118 | 'required' => false, |
||
| 119 | 'attr' => ['class' => 'hidden'], |
||
| 120 | 'label' => false, |
||
| 121 | ]) |
||
| 122 | ->add('enableSale', TextType::class, [ |
||
| 123 | 'required' => false, |
||
| 124 | 'attr' => ['class' => 'hidden'], |
||
| 125 | 'label' => false, |
||
| 126 | ]) |
||
| 127 | ->end() |
||
| 128 | ; |
||
| 129 | } |
||
| 130 | } |
||
| 131 | |||
| 132 | /** |
||
| 133 | * @param ListMapper $listMapper |
||
| 134 | * |
||
| 135 | * @return void |
||
| 136 | */ |
||
| 137 | View Code Duplication | protected function configureListFields(ListMapper $listMapper) |
|
|
|
|||
| 138 | { |
||
| 139 | $listMapper |
||
| 140 | ->add('performance') |
||
| 141 | ->add('dateTime') |
||
| 142 | ->add('venue') |
||
| 143 | ->add('_action', 'actions', [ |
||
| 144 | 'actions' => [ |
||
| 145 | 'edit' => [], |
||
| 146 | 'delete' => [], |
||
| 147 | ], |
||
| 148 | ]); |
||
| 149 | } |
||
| 150 | |||
| 151 | public function preUpdate($object) |
||
| 173 | |||
| 174 | public function postUpdate($object) |
||
| 188 | |||
| 189 | public function getEm() |
||
| 190 | { |
||
| 191 | if (!$this->em) { |
||
| 192 | $this->em = $this->getConfigurationPool()->getContainer()->get('Doctrine')->getManager(); |
||
| 193 | } |
||
| 194 | return $this->em; |
||
| 195 | } |
||
| 196 | |||
| 197 | /** |
||
| 198 | * Inspect PriceCategory. Search errors |
||
| 199 | * |
||
| 200 | * @param PerformanceEvent $performanceEvent |
||
| 201 | * @return bool |
||
| 202 | */ |
||
| 203 | public function inspectPriceCategories(PerformanceEvent $performanceEvent) |
||
| 217 | |||
| 218 | /** |
||
| 219 | * Parse string rows in PriceCategory |
||
| 220 | * |
||
| 221 | * @param Venue $venue |
||
| 222 | * @param $strRows |
||
| 223 | * @param VenueSector $venueSector |
||
| 224 | * @param $strPlaces |
||
| 225 | * @return bool|null |
||
| 226 | */ |
||
| 227 | public function getRows(Venue $venue, $strRows, VenueSector $venueSector, $strPlaces = null) |
||
| 243 | |||
| 244 | /** |
||
| 245 | * Parse string places in PriceCategory |
||
| 246 | * |
||
| 247 | * @param Venue $venue |
||
| 248 | * @param $row |
||
| 249 | * @param VenueSector $venueSector |
||
| 250 | * @param $strPlaces |
||
| 251 | */ |
||
| 252 | public function getPlaces(Venue $venue, $row, VenueSector $venueSector, $strPlaces = null) |
||
| 271 | |||
| 272 | /** |
||
| 273 | * Research existing Seat with row-place - $row-$place |
||
| 274 | * |
||
| 275 | * @param Venue $venue |
||
| 276 | * @param $row |
||
| 277 | * @param VenueSector $venueSector |
||
| 278 | * @param null $place |
||
| 279 | * @throws ModelManagerException |
||
| 280 | */ |
||
| 281 | public function getSeat(Venue $venue, $row, VenueSector $venueSector, $place = null) |
||
| 325 | |||
| 326 | /** |
||
| 327 | * Search Seat with more than one price |
||
| 328 | * |
||
| 329 | * @param $row |
||
| 330 | * @param $place |
||
| 331 | * @param VenueSector $venueSector |
||
| 332 | * @throws ModelManagerException |
||
| 333 | */ |
||
| 334 | public function inspectSeatMoreThanOnePrice($row, $place, VenueSector $venueSector) |
||
| 354 | |||
| 355 | /** |
||
| 356 | * Search Seat without price |
||
| 357 | * |
||
| 358 | * @param Venue $venue |
||
| 359 | * @return bool |
||
| 360 | * @throws ModelManagerException |
||
| 361 | */ |
||
| 362 | public function inspectSeatWithoutPrice(Venue $venue) |
||
| 379 | |||
| 380 | /** |
||
| 381 | * SeriesNumber can not be blank! |
||
| 382 | * |
||
| 383 | * @param PerformanceEvent $performanceEvent |
||
| 384 | * @return bool |
||
| 385 | * @throws ModelManagerException |
||
| 386 | */ |
||
| 387 | public function inspectSeriesNumber(PerformanceEvent $performanceEvent) |
||
| 403 | } |
||
| 404 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.