App\Repository\PostRepository

Complexity

Total Complexity

5

Size/Duplication

Total Lines	62
Duplicated Lines	14.52 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

96%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	findAllOrByTag()	0	15	1
A	getCount()	9	9	1
A	getTaggedPostsQuery()	0	13	2

<?php

namespace App\Repository;

use App\Entity\Post;
use Doctrine\Common\Persistence\ManagerRegistry;

class PostRepository extends AbstractRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, Post::class);
    }

    /**
     * @param int $limit
     * @param int $page
     * @param string $tagSlug
     * @return Post[]
     */
    public function findAllOrByTag($limit, $page, $tagSlug = null)
    {
        $taggedPosts = $this->getTaggedPostsQuery($tagSlug)
            ->setMaxResults($limit)
            ->setFirstResult($page)
            ->orderBy('u.createdAt', 'DESC')
            ->getQuery()
            ->enableResultCache(60*60*24)
            ->execute()
        ;

        $pinnedPosts = $this->getTaggedPostsQuery($tagSlug, true)->getQuery()->execute();

        return array_merge($pinnedPosts, $taggedPosts);
    }

    /**
     * @param string $tagSlug
     * @return int
     */
    public function getCount($tagSlug = null)

This method seems to be duplicated in your project.

    {
        $qb = $this->getTaggedPostsQuery($tagSlug);
        $qb->select($qb->expr()->count('u'));

        $query = $qb->getQuery()->enableResultCache(60*60*24);

        return $query->getSingleScalarResult();
    }

    /**
     * @param string $tagSlug
     * @param bool $pinned
     * @return \Doctrine\ORM\QueryBuilder
     */
    protected function getTaggedPostsQuery($tagSlug = null, $pinned = false)
    {
        $qb = $this->createQueryBuilder('u')
            ->andWhere('u.pinned = :pinned')
            ->setParameter('pinned', $pinned)
        ;

        if ($tagSlug) {

The expression $tagSlug of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $qb->join('u.tags', 't')->andWhere('t.slug = :slug')->setParameter('slug', $tagSlug);
        }

        return $qb;
    }
}