FacebookUserProvider::getUser() - Code Metrics - Inspection of "add security, oauth, resurs custumers/login" - geekhub-php/CheTheatre - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#137)

unknown

created 2017-04-05 01:27 UTC

FacebookUserProvider::getUser() B

↳ Parent: FacebookUserProvider

Complexity

Conditions	3
Paths	7

Size

Total Lines	27
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	3
eloc	18
nc	7
nop	1
dl	0
loc	27
rs	8.8571
c	2
b	0
f	0

<?php

namespace AppBundle\Services;

use AppBundle\Model\FacebookResponse;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\TransferException;
use JMS\Serializer\Serializer;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\Validator\Validator\RecursiveValidator;

class FacebookUserProvider
{
    /**
     * @var Serializer
     */
    protected $serializer;

    /**
     * @var RecursiveValidator
     */
    protected $validator;

    /**
     * @param Serializer         $serializer
     * @param RecursiveValidator $validator
     */
    public function __construct(Serializer $serializer, RecursiveValidator $validator)
    {
        $this->serializer = $serializer;
        $this->validator = $validator;
    }

    /**
     * @param string $accessToken
     *
     * @return FacebookResponse
     */
    public function getUser($accessToken)
    {
        try {
            $client = new Client();
            $result = $client->get(
                'https://graph.facebook.com/v2.8/me',
                ['query' => [
                    'access_token' => $accessToken,
                    'fields' => 'id, email, first_name, last_name', ],
                ]
            );
            $userFacebook = $this->serializer->deserialize(
                $result->getBody(),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                FacebookResponse::class,
                'json'
            );
            $errors = $this->validator->validate($userFacebook);

            if (count($errors) > 0) {
                throw new HttpException(400, 'Social response validation error');
            }

            return $userFacebook;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        } catch (TransferException $e) {
            throw new HttpException(400, 'Social login error');
        }
    }
}

1			<?php
2
3			namespace AppBundle\Services;
4
5			use AppBundle\Model\FacebookResponse;
6			use GuzzleHttp\Client;
7			use GuzzleHttp\Exception\TransferException;
8			use JMS\Serializer\Serializer;
9			use Symfony\Component\HttpKernel\Exception\HttpException;
10			use Symfony\Component\Validator\Validator\RecursiveValidator;
11
12			class FacebookUserProvider
13			{
14			/**
15			* @var Serializer
16			*/
17			protected $serializer;
18
19			/**
20			* @var RecursiveValidator
21			*/
22			protected $validator;
23
24			/**
25			* @param Serializer $serializer
26			* @param RecursiveValidator $validator
27			*/
28			public function __construct(Serializer $serializer, RecursiveValidator $validator)
29			{
30			$this->serializer = $serializer;
31			$this->validator = $validator;
32			}
33
34			/**
35			* @param string $accessToken
36			*
37			* @return FacebookResponse
38			*/
39			public function getUser($accessToken)
40			{
41			try {
42			$client = new Client();
43			$result = $client->get(
44			'https://graph.facebook.com/v2.8/me',
45			['query' => [
46			'access_token' => $accessToken,
47			'fields' => 'id, email, first_name, last_name', ],
48			]
49			);
50			$userFacebook = $this->serializer->deserialize(
51			$result->getBody(),
			0 ignored issues – show Documentation introduced 2017-04-04 20:00 UTC by Report Bug Copy Issue Report `$result->getBody()` is of type `object<GuzzleHttp\Stream\StreamInterface>\|null`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52			FacebookResponse::class,
53			'json'
54			);
55			$errors = $this->validator->validate($userFacebook);
56
57			if (count($errors) > 0) {
58			throw new HttpException(400, 'Social response validation error');
59			}
60
61			return $userFacebook;
			0 ignored issues – show Bug Best Practice introduced 2017-04-04 21:40 UTC by Report Bug Copy Issue Report The return type of `return $userFacebook;` (`object\|array\|integer\|double\|string\|boolean`) is incompatible with the return type documented by `AppBundle\Services\FacebookUserProvider::getUser` of type `AppBundle\Model\FacebookResponse`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
62			} catch (TransferException $e) {
63			throw new HttpException(400, 'Social login error');
64			}
65			}
66			}

geekhub-php / CheTheatre

Pull Request — master (#137)

FacebookUserProvider::getUser() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like