Version20210425203036::getDescription() - Code Metrics - Inspection of "Theatre 52: Data migration" - geekhub-php/CheTheatre - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#187)

by Serhii

created 2021-04-25 21:11 UTC

Version20210425203036::getDescription() A

↳ Parent: Version20210425203036

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace DoctrineMigrations;

use Doctrine\DBAL\Schema\Schema;
use Doctrine\Migrations\AbstractMigration;

final class Version20210425203036 extends AbstractMigration
{
    private const DATA = __DIR__.'/data/performances_duration_producers_age_limits.csv';

    public function getDescription() : string
    {
        return 'Added: performance age limit data, performance producer field with data, performance len with data';
    }

    public function up(Schema $schema) : void
    {
        $this->addSql('ALTER TABLE performances ADD producer_id INT DEFAULT NULL, ADD durationInMin INT NOT NULL, ADD extProducer VARCHAR(255) DEFAULT NULL');
        $this->addSql('ALTER TABLE performances ADD CONSTRAINT FK_8133AB2B89B658FE FOREIGN KEY (producer_id) REFERENCES employees (id)');
        $this->addSql('CREATE INDEX IDX_8133AB2B89B658FE ON performances (producer_id)');
        $this->insertData();
    }

    public function down(Schema $schema) : void
    {
    }

    public function insertData()
    {
        $performances = array_map('str_getcsv', file(self::DATA));
        array_shift($performances); // remove headers

        foreach ($performances as $performance) {
            $slug = array_shift($performance);
            $title = array_shift($performance);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $link = array_shift($performance);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $ageLimit = array_shift($performance);
            $producer = array_shift($performance);
            $len = array_shift($performance);

            $this->addSql(
                'UPDATE performances SET durationInMin=:len, ageLimit=:ageLimit, extProducer=:producer WHERE slug=:slug',
                ['len' => (int) $len, 'ageLimit' => (int) $ageLimit, 'producer' => $producer, 'slug' => $slug]
            );
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace DoctrineMigrations;
6
7			use Doctrine\DBAL\Schema\Schema;
8			use Doctrine\Migrations\AbstractMigration;
9
10			final class Version20210425203036 extends AbstractMigration
11			{
12			private const DATA = __DIR__.'/data/performances_duration_producers_age_limits.csv';
13
14			public function getDescription() : string
15			{
16			return 'Added: performance age limit data, performance producer field with data, performance len with data';
17			}
18
19			public function up(Schema $schema) : void
20			{
21			$this->addSql('ALTER TABLE performances ADD producer_id INT DEFAULT NULL, ADD durationInMin INT NOT NULL, ADD extProducer VARCHAR(255) DEFAULT NULL');
22			$this->addSql('ALTER TABLE performances ADD CONSTRAINT FK_8133AB2B89B658FE FOREIGN KEY (producer_id) REFERENCES employees (id)');
23			$this->addSql('CREATE INDEX IDX_8133AB2B89B658FE ON performances (producer_id)');
24			$this->insertData();
25			}
26
27			public function down(Schema $schema) : void
28			{
29			}
30
31			public function insertData()
32			{
33			$performances = array_map('str_getcsv', file(self::DATA));
34			array_shift($performances); // remove headers
35
36			foreach ($performances as $performance) {
37			$slug = array_shift($performance);
38			$title = array_shift($performance);
			0 ignored issues – show Unused Code introduced 2021-04-25 21:13 UTC by Report Bug Copy Issue Report `$title` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
39			$link = array_shift($performance);
			0 ignored issues – show Unused Code introduced 2021-04-25 21:13 UTC by Report Bug Copy Issue Report `$link` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
40			$ageLimit = array_shift($performance);
41			$producer = array_shift($performance);
42			$len = array_shift($performance);
43
44			$this->addSql(
45			'UPDATE performances SET durationInMin=:len, ageLimit=:ageLimit, extProducer=:producer WHERE slug=:slug',
46			['len' => (int) $len, 'ageLimit' => (int) $ageLimit, 'producer' => $producer, 'slug' => $slug]
47			);
48			}
49			}
50			}
51

geekhub-php / CheTheatre

Pull Request — develop (#187)

Version20210425203036::getDescription() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like