Issues in page_handler.php (master) - Issues in master - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2473)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

engine/handlers/page_handler.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Pages handler.
 *
 * This file dispatches pages.  It is called via a URL rewrite in .htaccess
 * from http://site/handler/page1/page2.  The first element after site/ is
 * the page handler name as registered by {@link elgg_register_page_handler()}.
 * The rest of the string is sent to {@link page_handler()}.
 *
 * Note that the following handler names are reserved by elgg and should not be
 * registered by any plugins:
 *  * action
 *  * cache
 *  * services
 *  * export
 *  * js
 *  * css
 *  * rewrite.php
 *  * tag (deprecated, reserved for backwards compatibility)
 *  * pg (deprecated, reserved for backwards compatibility)
 *
 * These additionally are reserved for the xml-rpc plugin
 *  * mt
 *  * xml-rpc.php
 *
 * {@link page_handler()} explodes the pages string by / and sends it to
 * the page handler function as registered by {@link elgg_register_page_handler()}.
 * If a valid page handler isn't found, plugins have a chance to provide a 404.
 *
 * @package Elgg.Core
 * @subpackage PageHandler
 */

require_once(dirname(dirname(__FILE__)) . "/start.php");

register_error("Update your .htaccess file to remove the page handler");

$router = _elgg_services()->router;
$request = _elgg_services()->request;

if (!$router->route($request)) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
	forward('', '404');
}


1			<?php
2			/**
3			* Pages handler.
4			*
5			* This file dispatches pages. It is called via a URL rewrite in .htaccess
6			* from http://site/handler/page1/page2. The first element after site/ is
7			* the page handler name as registered by {@link elgg_register_page_handler()}.
8			* The rest of the string is sent to {@link page_handler()}.
9			*
10			* Note that the following handler names are reserved by elgg and should not be
11			* registered by any plugins:
12			* * action
13			* * cache
14			* * services
15			* * export
16			* * js
17			* * css
18			* * rewrite.php
19			* * tag (deprecated, reserved for backwards compatibility)
20			* * pg (deprecated, reserved for backwards compatibility)
21			*
22			* These additionally are reserved for the xml-rpc plugin
23			* * mt
24			* * xml-rpc.php
25			*
26			* {@link page_handler()} explodes the pages string by / and sends it to
27			* the page handler function as registered by {@link elgg_register_page_handler()}.
28			* If a valid page handler isn't found, plugins have a chance to provide a 404.
29			*
30			* @package Elgg.Core
31			* @subpackage PageHandler
32			*/
33
34			require_once(dirname(dirname(__FILE__)) . "/start.php");
35
36			register_error("Update your .htaccess file to remove the page handler");
37
38			$router = _elgg_services()->router;
39			$request = _elgg_services()->request;
40
41			if (!$router->route($request)) {
			0 ignored issues – show Bug Best Practice introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$router->route($request)` of type `null\|boolean` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
42			forward('', '404');
43			}
44

gctools-outilsgc / gcconnex

Issues (2473)

Security Analysis no vulnerabilities found

engine/handlers/page_handler.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like