Issues in edit.php (master) - Issues in master - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2473)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

actions/profile/edit.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Elgg profile edit action
 *
 */

elgg_make_sticky_form('profile:edit');

$guid = get_input('guid');
$owner = get_entity($guid);

if (!$owner || !($owner instanceof ElggUser) || !$owner->canEdit()) {
	register_error(elgg_echo('profile:noaccess'));
	forward(REFERER);
}

// grab the defined profile field names and their load the values from POST.
// each field can have its own access, so sort that too.
$input = array();
$accesslevel = get_input('accesslevel');

if (!is_array($accesslevel)) {
	$accesslevel = array();
}

/**
 * wrapper for recursive array walk decoding
 */
function profile_array_decoder(&$v) {
	$v = _elgg_html_decode($v);
}

$profile_fields = elgg_get_config('profile_fields');
foreach ($profile_fields as $shortname => $valuetype) {
	// the decoding is a stop gap to prevent &amp;&amp; showing up in profile fields
	// because it is escaped on both input (get_input()) and output (view:output/text). see #561 and #1405.
	// must decode in utf8 or string corruption occurs. see #1567.
	$value = get_input($shortname);
	if (is_array($value)) {
		array_walk_recursive($value, 'profile_array_decoder');
	} else {
		$value = _elgg_html_decode($value);
	}

	// limit to reasonable sizes
	// @todo - throwing away changes due to this is dumb!
	// ^^ This is a sticky form so changes aren't lost...?
	if (!is_array($value) && $valuetype != 'longtext' && elgg_strlen($value) > 250) {
		$error = elgg_echo('profile:field_too_long', array(elgg_echo("profile:{$shortname}")));
		register_error($error);
		forward(REFERER);
	}

	if ($value && $valuetype == 'url' && !preg_match('~^https?\://~i', $value)) {
		$value = "http://$value";
	}

	if ($valuetype == 'tags') {
		$value = string_to_tag_array($value);
	}

	if ($valuetype == 'email' && !empty($value) && !is_email_address($value)) {
		register_error(elgg_echo('profile:invalid_email', array(
			elgg_echo("profile:{$shortname}")
		)));
		forward(REFERER);
	}
	
	$input[$shortname] = $value;
}

// display name is handled separately
$name = strip_tags(get_input('name'));
if ($name) {
	if (elgg_strlen($name) > 50) {
		register_error(elgg_echo('user:name:fail'));
	} elseif ($owner->name != $name) {
		$owner->name = $name;
		$owner->save();
	}
}

// go through custom fields
if (sizeof($input) > 0) {
	
	// fetch default access level for the user for use in fallback cases
	$user_default_access = get_default_access($owner);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	
	foreach ($input as $shortname => $value) {
		$options = array(
			'guid' => $owner->guid,
			'metadata_name' => $shortname,
			'limit' => false
		);
		elgg_delete_metadata($options);
		
		if (!is_null($value) && ($value !== '')) {
			// only create metadata for non empty values (0 is allowed) to prevent metadata records
			// with empty string values #4858
			
			if (isset($accesslevel[$shortname])) {
				$access_id = (int) $accesslevel[$shortname];
			} else {
				// this should never be executed since the access level should always be set
				$access_id = $user_default_access;
			}
			if (is_array($value)) {
				$i = 0;
				foreach ($value as $interval) {
					$i++;
					$multiple = ($i > 1) ? TRUE : FALSE;
					create_metadata($owner->guid, $shortname, $interval, 'text', $owner->guid, $access_id, $multiple);
				}
			} else {
				create_metadata($owner->getGUID(), $shortname, $value, 'text', $owner->getGUID(), $access_id);
			}
		}
	}

	$owner->save();

	// Notify of profile update
	elgg_trigger_event('profileupdate', $owner->type, $owner);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

	elgg_clear_sticky_form('profile:edit');
	system_message(elgg_echo("profile:saved"));
}

forward($owner->getUrl());


1		<?php
2		/**
3		* Elgg profile edit action
4		*
5		*/
6
7		elgg_make_sticky_form('profile:edit');
8
9		$guid = get_input('guid');
10		$owner = get_entity($guid);
11
12		if (!$owner \|\| !($owner instanceof ElggUser) \|\| !$owner->canEdit()) {
13		register_error(elgg_echo('profile:noaccess'));
14		forward(REFERER);
15		}
16
17		// grab the defined profile field names and their load the values from POST.
18		// each field can have its own access, so sort that too.
19		$input = array();
20		$accesslevel = get_input('accesslevel');
21
22		if (!is_array($accesslevel)) {
23		$accesslevel = array();
24		}
25
26		/**
27		* wrapper for recursive array walk decoding
28		*/
29		function profile_array_decoder(&$v) {
30		$v = _elgg_html_decode($v);
31		}
32
33		$profile_fields = elgg_get_config('profile_fields');
34		foreach ($profile_fields as $shortname => $valuetype) {
35		// the decoding is a stop gap to prevent && showing up in profile fields
36		// because it is escaped on both input (get_input()) and output (view:output/text). see #561 and #1405.
37		// must decode in utf8 or string corruption occurs. see #1567.
38		$value = get_input($shortname);
39		if (is_array($value)) {
40		array_walk_recursive($value, 'profile_array_decoder');
41		} else {
42		$value = _elgg_html_decode($value);
43		}
44
45		// limit to reasonable sizes
46		// @todo - throwing away changes due to this is dumb!
47		// ^^ This is a sticky form so changes aren't lost...?
48		if (!is_array($value) && $valuetype != 'longtext' && elgg_strlen($value) > 250) {
49		$error = elgg_echo('profile:field_too_long', array(elgg_echo("profile:{$shortname}")));
50		register_error($error);
51		forward(REFERER);
52		}
53
54		if ($value && $valuetype == 'url' && !preg_match('~^https?\://~i', $value)) {
55		$value = "http://$value";
56		}
57
58		if ($valuetype == 'tags') {
59		$value = string_to_tag_array($value);
60		}
61
62		if ($valuetype == 'email' && !empty($value) && !is_email_address($value)) {
63		register_error(elgg_echo('profile:invalid_email', array(
64		elgg_echo("profile:{$shortname}")
65		)));
66		forward(REFERER);
67		}
68
69		$input[$shortname] = $value;
70		}
71
72		// display name is handled separately
73		$name = strip_tags(get_input('name'));
74	View Code Duplication	if ($name) {
75		if (elgg_strlen($name) > 50) {
76		register_error(elgg_echo('user:name:fail'));
77		} elseif ($owner->name != $name) {
78		$owner->name = $name;
79		$owner->save();
80		}
81		}
82
83		// go through custom fields
84		if (sizeof($input) > 0) {
85
86		// fetch default access level for the user for use in fallback cases
87		$user_default_access = get_default_access($owner);
		0 ignored issues – show Documentation introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$owner` is of type `object<ElggEntity>`, but the function expects a `null\|object<ElggUser>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
88
89		foreach ($input as $shortname => $value) {
90		$options = array(
91		'guid' => $owner->guid,
92		'metadata_name' => $shortname,
93		'limit' => false
94		);
95		elgg_delete_metadata($options);
96
97		if (!is_null($value) && ($value !== '')) {
98		// only create metadata for non empty values (0 is allowed) to prevent metadata records
99		// with empty string values #4858
100
101		if (isset($accesslevel[$shortname])) {
102		$access_id = (int) $accesslevel[$shortname];
103		} else {
104		// this should never be executed since the access level should always be set
105		$access_id = $user_default_access;
106		}
107		if (is_array($value)) {
108		$i = 0;
109		foreach ($value as $interval) {
110		$i++;
111		$multiple = ($i > 1) ? TRUE : FALSE;
112		create_metadata($owner->guid, $shortname, $interval, 'text', $owner->guid, $access_id, $multiple);
113		}
114		} else {
115		create_metadata($owner->getGUID(), $shortname, $value, 'text', $owner->getGUID(), $access_id);
116		}
117		}
118		}
119
120		$owner->save();
121
122		// Notify of profile update
123		elgg_trigger_event('profileupdate', $owner->type, $owner);
		0 ignored issues – show Documentation introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$owner` is of type `object<ElggEntity>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
124
125		elgg_clear_sticky_form('profile:edit');
126		system_message(elgg_echo("profile:saved"));
127		}
128
129		forward($owner->getUrl());
130

gctools-outilsgc / gcconnex

Issues (2473)

Security Analysis no vulnerabilities found

actions/profile/edit.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like