Completed
Pull Request — gcconnex (#1464)
by Ilia
26:45
created
engine/lib/access.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
  * @param string $type
553 553
  * @param bool $value
554 554
  * @param array $params
555
- * @return true|null
555
+ * @return boolean|null
556 556
  * @access private
557 557
  */
558 558
 function elgg_override_permissions($hook, $type, $value, $params) {
@@ -589,7 +589,7 @@  discard block
 block discarded – undo
589 589
  * @param string $type
590 590
  * @param array $value
591 591
  * @param array $params
592
- * @return array
592
+ * @return string[]
593 593
  *
594 594
  * @access private
595 595
  */
Please login to merge, or discard this patch.
engine/lib/actions.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
  *
140 140
  * @param string $action The action being performed 
141 141
  *
142
- * @return mixed True if valid or redirects.
142
+ * @return boolean|null True if valid or redirects.
143 143
  * @access private
144 144
  */
145 145
 function action_gatekeeper($action) {
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
  *
176 176
  * Note: Old secrets were hex encoded.
177 177
  *
178
- * @return mixed The site secret hash or false
178
+ * @return string|false The site secret hash or false
179 179
  * @access private
180 180
  * @todo Move to better file.
181 181
  */
Please login to merge, or discard this patch.
engine/lib/admin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -806,7 +806,7 @@
 block discarded – undo
806 806
  * @param string $type
807 807
  * @param \ElggUser $user
808 808
  *
809
- * @return null|true
809
+ * @return boolean|null
810 810
  * @access private
811 811
  */
812 812
 function _elgg_add_admin_widgets($event, $type, $user) {
Please login to merge, or discard this patch.
engine/lib/annotations.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
  *
32 32
  * @param int $id The id of the annotation object being retrieved.
33 33
  *
34
- * @return \ElggAnnotation|false
34
+ * @return ElggExtender
35 35
  */
36 36
 function elgg_get_annotation_from_id($id) {
37 37
 	return _elgg_services()->annotations->get($id);
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
  * @param int    $owner_guid  Owner of annotation (default is logged in user)
58 58
  * @param int    $access_id   Access level of annotation
59 59
  *
60
- * @return int|bool id on success or false on failure
60
+ * @return integer id on success or false on failure
61 61
  */
62 62
 function create_annotation($entity_guid, $name, $value, $value_type = '',
63 63
 		$owner_guid = 0, $access_id = ACCESS_PRIVATE) {
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
  * @param string $hook
330 330
  * @param string $type
331 331
  * @param array  $tests
332
- * @return array
332
+ * @return string[]
333 333
  * @access private
334 334
  */
335 335
 function _elgg_annotations_test($hook, $type, $tests) {
Please login to merge, or discard this patch.
engine/lib/cache.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -214,7 +214,7 @@
 block discarded – undo
214 214
  * Deletes all cached views in the simplecache and sets the lastcache and
215 215
  * lastupdate time to 0 for every valid viewtype.
216 216
  *
217
- * @return bool
217
+ * @return boolean|null
218 218
  * @since 1.7.4
219 219
  */
220 220
 function elgg_invalidate_simplecache() {
Please login to merge, or discard this patch.
engine/lib/comments.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
  * Page handler for generic comments manipulation.
33 33
  *
34 34
  * @param array $page
35
- * @return bool
35
+ * @return boolean|null
36 36
  * @access private
37 37
  */
38 38
 function _elgg_comments_page_handler($page) {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
  * @param \ElggMenuItem[] $return Array of \ElggMenuItem objects
159 159
  * @param array          $params Array of view vars
160 160
  *
161
- * @return array
161
+ * @return ElggMenuItem[]
162 162
  * @access private
163 163
  */
164 164
 function _elgg_comment_setup_entity_menu($hook, $type, $return, $params) {
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
  * @param boolean $return Can the current user write to this container?
225 225
  * @param array   $params Array of parameters (container, user, subtype)
226 226
  *
227
- * @return array
227
+ * @return boolean
228 228
  * @access private
229 229
  * @todo this doesn't seem to make a difference if a user can comment or not
230 230
  */
Please login to merge, or discard this patch.
engine/lib/deprecated-1.7.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -683,7 +683,7 @@  discard block
 block discarded – undo
683 683
  * @param string $order_by            Optional ordering.
684 684
  * @param int    $site_guid           Site GUID. 0 for current, -1 for any.
685 685
  * @param bool   $count               Return a count instead of entities
686
- * @param bool   $meta_array_operator Operator for metadata values
686
+ * @param string|boolean   $meta_array_operator Operator for metadata values
687 687
  *
688 688
  * @return int|array A list of entities, or a count if $count is set to true
689 689
  */
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
  * @param mixed  $returnvalue Previous return value
820 820
  * @param mixed  $tag         Search term
821 821
  *
822
- * @return array
822
+ * @return string|null
823 823
  */
824 824
 function search_list_objects_by_name($hook, $user, $returnvalue, $tag) {
825 825
 	elgg_deprecated_notice('search_list_objects_by_name was deprecated by new search plugin.', 1.7);
@@ -1043,7 +1043,7 @@  discard block
 block discarded – undo
1043 1043
  * @param mixed  $returnvalue Previous hook's return value
1044 1044
  * @param mixed  $tag         Tag to search against
1045 1045
  *
1046
- * @return void
1046
+ * @return string|null
1047 1047
  */
1048 1048
 function search_list_users_by_name($hook, $user, $returnvalue, $tag) {
1049 1049
 	elgg_deprecated_notice('search_list_users_by_name() was deprecated by new search', 1.7);
@@ -1106,7 +1106,7 @@  discard block
 block discarded – undo
1106 1106
  * Constructs and returns a register object.
1107 1107
  *
1108 1108
  * @param string $register_name  The name of the register
1109
- * @param mixed  $register_value The value of the register
1109
+ * @param string  $register_value The value of the register
1110 1110
  * @param array  $children_array Optionally, an array of children
1111 1111
  *
1112 1112
  * @return false|\stdClass Depending on success
Please login to merge, or discard this patch.
engine/lib/deprecated-1.8.php 1 patch
Doc Comments   +53 added lines, -62 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
  * @param mixed  $subregister_value The value of the subregister
276 276
  * @param array  $children_array    Optionally, an array of children
277 277
  *
278
- * @return true|false Depending on success
278
+ * @return boolean Depending on success
279 279
  */
280 280
 function add_to_register($register_name, $subregister_name, $subregister_value, $children_array = array()) {
281 281
 	elgg_deprecated_notice("add_to_register() has been deprecated", 1.8);
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
  * @param string $register_name    The name of the top-level register
316 316
  * @param string $subregister_name The name of the subregister
317 317
  *
318
- * @return true|false Depending on success
318
+ * @return boolean Depending on success
319 319
  * @since 1.7.0
320 320
  */
321 321
 function remove_from_register($register_name, $subregister_name) {
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
  * @param boolean $call        Set to true to call the event rather than add to it (default false)
393 393
  * @param mixed   $object      Optionally, the object the event is being performed on (eg a user)
394 394
  *
395
- * @return true|false Depending on success
395
+ * @return boolean Depending on success
396 396
  */
397 397
 function events($event = "", $object_type = "", $function = "", $priority = 500, $call = false, $object = null) {
398 398
 
@@ -413,8 +413,7 @@  discard block
 block discarded – undo
413 413
  * 
414 414
  * @param string $event The event type
415 415
  * @param string $object_type The object type
416
- * @param string $function The function name
417
- * @return true|false Depending on success
416
+ * @return boolean Depending on success
418 417
  */
419 418
 function register_elgg_event_handler($event, $object_type, $callback, $priority = 500) {
420 419
 	elgg_deprecated_notice("register_elgg_event_handler() was deprecated by elgg_register_event_handler()", 1.8);
@@ -428,7 +427,6 @@  discard block
 block discarded – undo
428 427
  *
429 428
  * @param string $event The event type
430 429
  * @param string $object_type The object type
431
- * @param string $function The function name
432 430
  * @since 1.7.0
433 431
  */
434 432
 function unregister_elgg_event_handler($event, $object_type, $callback) {
@@ -443,8 +441,7 @@  discard block
 block discarded – undo
443 441
  * 
444 442
  * @param string $event The event type
445 443
  * @param string $object_type The object type
446
- * @param string $function The function name
447
- * @return true|false Depending on success
444
+ * @return boolean Depending on success
448 445
  */
449 446
 function trigger_elgg_event($event, $object_type, $object = null) {
450 447
 	elgg_deprecated_notice('trigger_elgg_event() was deprecated by elgg_trigger_event()', 1.8);
@@ -471,10 +468,8 @@  discard block
 block discarded – undo
471 468
  * $params is an array containing a set of parameters (or nothing).
472 469
  *
473 470
  * @param string $hook The name of the hook
474
- * @param string $entity_type The name of the type of entity (eg "user", "object" etc)
475
- * @param string $function The name of a valid function to be run
476
- * @param string $priority The priority - 0 is first, 1000 last, default is 500
477
- * @return true|false Depending on success
471
+ * @param integer $priority The priority - 0 is first, 1000 last, default is 500
472
+ * @return boolean Depending on success
478 473
  */
479 474
 function register_plugin_hook($hook, $type, $callback, $priority = 500) {
480 475
 	elgg_deprecated_notice("register_plugin_hook() was deprecated by elgg_register_plugin_hook_handler()", 1.8);
@@ -488,7 +483,6 @@  discard block
 block discarded – undo
488 483
  * 
489 484
  * @param string $hook The name of the hook
490 485
  * @param string $entity_type The name of the type of entity (eg "user", "object" etc)
491
- * @param string $function The name of a valid function to be run
492 486
  * @since 1.7.0
493 487
  */
494 488
 function unregister_plugin_hook($hook, $entity_type, $callback) {
@@ -507,7 +501,6 @@  discard block
 block discarded – undo
507 501
  *
508 502
  * @see register_plugin_hook
509 503
  * @param string $hook The name of the hook to trigger
510
- * @param string $entity_type The name of the entity type to trigger it for (or "all", or "none")
511 504
  * @param array $params Any parameters. It's good practice to name the keys, i.e. by using array('name' => 'value', 'name2' => 'value2')
512 505
  * @param mixed $returnvalue An initial return value
513 506
  * @return mixed|null The cumulative return value for the plugin hook functions
@@ -617,7 +610,7 @@  discard block
 block discarded – undo
617 610
  *                                called by something on $path, if false the whole call stack is
618 611
  *                                searched.
619 612
  *
620
- * @return void
613
+ * @return boolean
621 614
  *
622 615
  * @deprecated 1.8 A neat but pointless function
623 616
  */
@@ -1215,8 +1208,8 @@  discard block
 block discarded – undo
1215 1208
  *
1216 1209
  * @deprecated 1.8 Use elgg_list_entities_from_metadata
1217 1210
  *
1218
- * @param mixed  $meta_name      Metadata name to search on
1219
- * @param mixed  $meta_value     The value to match, optionally
1211
+ * @param string  $meta_name      Metadata name to search on
1212
+ * @param string  $meta_value     The value to match, optionally
1220 1213
  * @param string $entity_type    The type of entity to look for, eg 'site' or 'object'
1221 1214
  * @param string $entity_subtype The subtype of the entity
1222 1215
  * @param int    $owner_guid     Owner GUID
@@ -1341,7 +1334,7 @@  discard block
 block discarded – undo
1341 1334
  *
1342 1335
  * @param string $label The item label
1343 1336
  * @param string $group The submenu group (default "a")
1344
- * @return bool whether the item was removed or not
1337
+ * @return ElggMenuItem|null whether the item was removed or not
1345 1338
  * @since 1.7.8
1346 1339
  */
1347 1340
 function remove_submenu_item($label, $group = 'a') {
@@ -1375,7 +1368,7 @@  discard block
 block discarded – undo
1375 1368
  * @param array  $menu_children Optionally, an array of submenu items (not used)
1376 1369
  * @param string $context       (not used)
1377 1370
  *
1378
- * @return true|false Depending on success
1371
+ * @return boolean Depending on success
1379 1372
  * @deprecated 1.8 use elgg_register_menu_item() for the menu 'site'
1380 1373
  */
1381 1374
 function add_menu($menu_name, $menu_url, $menu_children = array(), $context = "") {
@@ -1390,7 +1383,7 @@  discard block
 block discarded – undo
1390 1383
  *
1391 1384
  * @param string $menu_name The name of the menu item
1392 1385
  *
1393
- * @return true|false Depending on success
1386
+ * @return ElggMenuItem|null Depending on success
1394 1387
  * @deprecated 1.8 Use the new menu system
1395 1388
  */
1396 1389
 function remove_menu($menu_name) {
@@ -1469,7 +1462,7 @@  discard block
 block discarded – undo
1469 1462
  *
1470 1463
  * @param string $input A word
1471 1464
  *
1472
- * @return true|false
1465
+ * @return string|boolean
1473 1466
  */
1474 1467
 function remove_blacklist($input) {
1475 1468
 	elgg_deprecated_notice('remove_blacklist() was deprecated!', 1.8);
@@ -1542,7 +1535,7 @@  discard block
 block discarded – undo
1542 1535
  *
1543 1536
  * @param string $context The context of the page
1544 1537
  *
1545
- * @return mixed Either the context string, or false on failure
1538
+ * @return false|string Either the context string, or false on failure
1546 1539
  */
1547 1540
 function set_context($context) {
1548 1541
 	elgg_deprecated_notice('set_context() was deprecated by elgg_set_context().', 1.8);
@@ -1606,7 +1599,7 @@  discard block
 block discarded – undo
1606 1599
  *
1607 1600
  * @param array $pluginorder Optionally, a list of existing plugins and their orders
1608 1601
  *
1609
- * @return array The new list of plugins and their orders
1602
+ * @return boolean The new list of plugins and their orders
1610 1603
  */
1611 1604
 function regenerate_plugin_list($pluginorder = FALSE) {
1612 1605
 	$msg = 'regenerate_plugin_list() is (sorta) deprecated by elgg_generate_plugin_entities() and'
@@ -1772,7 +1765,7 @@  discard block
 block discarded – undo
1772 1765
  * @param string $plugin    The plugin name.
1773 1766
  * @param int    $site_guid The site id, if not specified then this is detected.
1774 1767
  *
1775
- * @return array
1768
+ * @return boolean
1776 1769
  * @throws InvalidClassException
1777 1770
  */
1778 1771
 function enable_plugin($plugin, $site_guid = null) {
@@ -1935,7 +1928,7 @@  discard block
 block discarded – undo
1935 1928
  * Get entities based on their private data by multiple keys.
1936 1929
  *
1937 1930
  * @param string $name           The name of the setting
1938
- * @param mixed  $type           Entity type
1931
+ * @param string  $type           Entity type
1939 1932
  * @param string $subtype        Entity subtype
1940 1933
  * @param int    $owner_guid     The GUID of the owning user
1941 1934
  * @param string $order_by       The field to order by; by default, time_created desc
@@ -2029,9 +2022,9 @@  discard block
 block discarded – undo
2029 2022
  * @param int $owner_guid The owner (default: all)
2030 2023
  * @param int $limit The number of entities to display on a page
2031 2024
  * @param true|false $fullview Whether or not to display the full view (default: true)
2032
- * @param true|false $viewtypetoggle Whether or not to allow gallery view
2025
+ * @param true|false $listtypetoggle Whether or not to allow gallery view
2033 2026
  * @param true|false $pagination Whether to display pagination (default: true)
2034
- * @param bool $order_by SQL order by clause
2027
+ * @param string|boolean $order_by SQL order by clause
2035 2028
  * @return string The viewable list of entities
2036 2029
  */
2037 2030
 function list_entities_from_relationship($relationship, $relationship_guid,
@@ -2237,8 +2230,8 @@  discard block
 block discarded – undo
2237 2230
 /**
2238 2231
  * Retrieves items from the river. All parameters are optional.
2239 2232
  *
2240
- * @param int|array $subject_guid         Acting entity to restrict to. Default: all
2241
- * @param int|array $object_guid          Entity being acted on to restrict to. Default: all
2233
+ * @param integer $subject_guid         Acting entity to restrict to. Default: all
2234
+ * @param integer $object_guid          Entity being acted on to restrict to. Default: all
2242 2235
  * @param string    $subject_relationship If set to a relationship type, this will use
2243 2236
  * 	                                      $subject_guid as the starting point and set the
2244 2237
  *                                        subjects to be all users this
@@ -2305,8 +2298,8 @@  discard block
 block discarded – undo
2305 2298
 /**
2306 2299
  * Returns a human-readable version of the river.
2307 2300
  *
2308
- * @param int|array $subject_guid         Acting entity to restrict to. Default: all
2309
- * @param int|array $object_guid          Entity being acted on to restrict to. Default: all
2301
+ * @param integer $subject_guid         Acting entity to restrict to. Default: all
2302
+ * @param integer $object_guid          Entity being acted on to restrict to. Default: all
2310 2303
  * @param string    $subject_relationship If set to a relationship type, this will use
2311 2304
  * 	                                      $subject_guid as the starting point and set
2312 2305
  *                                        the subjects to be all users this entity has this
@@ -2598,7 +2591,7 @@  discard block
 block discarded – undo
2598 2591
  * @param int $site_guid       Site GUID
2599 2592
  * @param int $collection_guid Collection GUID
2600 2593
  *
2601
- * @return mixed
2594
+ * @return boolean
2602 2595
  * @deprecated 1.8 Don't use this.
2603 2596
  */
2604 2597
 function remove_site_collection($site_guid, $collection_guid) {
@@ -2903,7 +2896,7 @@  discard block
 block discarded – undo
2903 2896
  * @param string $view              The view to extend, by default this is 'usersettings/main'.
2904 2897
  * @param int    $priority          Optional priority to govern the appearance in the list.
2905 2898
  *
2906
- * @return bool
2899
+ * @return boolean|null
2907 2900
  * @deprecated 1.8 Extend one of the views in core/settings
2908 2901
  */
2909 2902
 function extend_elgg_settings_page($new_settings_view, $view = 'usersettings/main',
@@ -3151,12 +3144,12 @@  discard block
 block discarded – undo
3151 3144
  * Set a setting for a plugin.
3152 3145
  *
3153 3146
  * @param string $name      The name - note, can't be "title".
3154
- * @param mixed  $value     The value.
3147
+ * @param string  $value     The value.
3155 3148
  * @param string $plugin_id Optional plugin name, if not specified
3156 3149
  *                          then it is detected from where you are calling from.
3157 3150
  *
3158 3151
  * @deprecated 1.8 Use elgg_set_plugin_setting() or \ElggPlugin->setSetting()
3159
- * @return int|false
3152
+ * @return boolean
3160 3153
  */
3161 3154
 function set_plugin_setting($name, $value, $plugin_id = null) {
3162 3155
 	elgg_deprecated_notice('set_plugin_setting() is deprecated by elgg_set_plugin_setting()', 1.8);
@@ -3212,12 +3205,12 @@  discard block
 block discarded – undo
3212 3205
 /**
3213 3206
  * Get a list of annotations for a given object/user/annotation type.
3214 3207
  *
3215
- * @param int|array $entity_guid       GUID to return annotations of (falsey for any)
3208
+ * @param integer $entity_guid       GUID to return annotations of (falsey for any)
3216 3209
  * @param string    $entity_type       Type of entity
3217 3210
  * @param string    $entity_subtype    Subtype of entity
3218 3211
  * @param string    $name              Name of annotation
3219 3212
  * @param mixed     $value             Value of annotation
3220
- * @param int|array $owner_guid        Owner(s) of annotation
3213
+ * @param integer $owner_guid        Owner(s) of annotation
3221 3214
  * @param int       $limit             Limit
3222 3215
  * @param int       $offset            Offset
3223 3216
  * @param string    $order_by          Order annotations by SQL
@@ -3314,15 +3307,15 @@  discard block
 block discarded – undo
3314 3307
 /**
3315 3308
  * Helper function to deprecate annotation calculation functions. Don't use.
3316 3309
  *
3317
- * @param unknown_type $entity_guid
3310
+ * @param integer $entity_guid
3318 3311
  * @param unknown_type $entity_type
3319 3312
  * @param unknown_type $entity_subtype
3320 3313
  * @param unknown_type $name
3321 3314
  * @param unknown_type $value
3322 3315
  * @param unknown_type $value_type
3323
- * @param unknown_type $owner_guid
3324
- * @param unknown_type $timelower
3325
- * @param unknown_type $timeupper
3316
+ * @param integer $owner_guid
3317
+ * @param integer $timelower
3318
+ * @param integer $timeupper
3326 3319
  * @param unknown_type $calculation
3327 3320
  * @internal Don't use this at all.
3328 3321
  * @deprecated 1.8 Use elgg_get_annotations()
@@ -3603,7 +3596,7 @@  discard block
 block discarded – undo
3603 3596
  * @param string $function_name The function to register
3604 3597
  * @param string $entity_type The entity type
3605 3598
  * @param string $entity_subtype The entity subtype
3606
- * @return true|false Depending on success
3599
+ * @return boolean Depending on success
3607 3600
  *
3608 3601
  * @deprecated 1.8 Use elgg_register_entity_url_handler()
3609 3602
  */
@@ -3724,7 +3717,7 @@  discard block
 block discarded – undo
3724 3717
  *
3725 3718
  * @param int $id The id of the metadata being retrieved.
3726 3719
  *
3727
- * @return mixed False on failure or \ElggMetadata
3720
+ * @return ElggExtender False on failure or \ElggMetadata
3728 3721
  * @deprecated 1.8 Use elgg_get_metadata_from_id()
3729 3722
  */
3730 3723
 function get_metadata($id) {
@@ -3737,7 +3730,7 @@  discard block
 block discarded – undo
3737 3730
  *
3738 3731
  * @param int $guid Entity GUID
3739 3732
  *
3740
- * @return bool
3733
+ * @return boolean|null
3741 3734
  * @deprecated 1.8 Use elgg_delete_metadata()
3742 3735
  */
3743 3736
 function clear_metadata($guid) {
@@ -3753,7 +3746,7 @@  discard block
 block discarded – undo
3753 3746
  *
3754 3747
  * @param int $owner_guid The owner
3755 3748
  *
3756
- * @return bool
3749
+ * @return boolean|null
3757 3750
  * @deprecated 1.8 Use elgg_delete_metadata()
3758 3751
  */
3759 3752
 function clear_metadata_by_owner($owner_guid) {
@@ -3769,7 +3762,7 @@  discard block
 block discarded – undo
3769 3762
  *
3770 3763
  * @param int $id The id of metadata to delete.
3771 3764
  *
3772
- * @return bool
3765
+ * @return boolean|null
3773 3766
  * @deprecated 1.8 Use elgg_delete_metadata()
3774 3767
  */
3775 3768
 function delete_metadata($id) {
@@ -3787,7 +3780,7 @@  discard block
 block discarded – undo
3787 3780
  * @param string $name  The name of the metadata
3788 3781
  * @param string $value The value of the metadata (useful to remove a single item of a set)
3789 3782
  *
3790
- * @return bool Depending on success
3783
+ * @return boolean|null Depending on success
3791 3784
  * @deprecated 1.8 Use elgg_delete_metadata()
3792 3785
  */
3793 3786
 function remove_metadata($guid, $name, $value = "") {
@@ -3829,7 +3822,7 @@  discard block
 block discarded – undo
3829 3822
  *
3830 3823
  * @param int $id The annotation id
3831 3824
  *
3832
- * @return bool
3825
+ * @return boolean|null
3833 3826
  * @deprecated 1.8 Use elgg_delete_annotations()
3834 3827
  */
3835 3828
 function delete_annotation($id) {
@@ -3846,7 +3839,7 @@  discard block
 block discarded – undo
3846 3839
  * @param int    $guid The entity guid
3847 3840
  * @param string $name The name of the annotation to delete.
3848 3841
  *
3849
- * @return int Number of annotations deleted or false if an error
3842
+ * @return boolean|null Number of annotations deleted or false if an error
3850 3843
  * @deprecated 1.8 Use elgg_delete_annotations()
3851 3844
  */
3852 3845
 function clear_annotations($guid, $name = "") {
@@ -3873,7 +3866,7 @@  discard block
 block discarded – undo
3873 3866
  *
3874 3867
  * @param int $owner_guid The owner
3875 3868
  *
3876
- * @return int Number of annotations deleted
3869
+ * @return boolean|null Number of annotations deleted
3877 3870
  * @deprecated 1.8 Use elgg_delete_annotations()
3878 3871
  */
3879 3872
 function clear_annotations_by_owner($owner_guid) {
@@ -3911,7 +3904,7 @@  discard block
 block discarded – undo
3911 3904
  *
3912 3905
  * @param string $handler The page type to handle
3913 3906
  * @param string $function Your function name
3914
- * @return true|false Depending on success
3907
+ * @return boolean Depending on success
3915 3908
  *
3916 3909
  * @deprecated 1.8 Use {@link elgg_register_page_handler()}
3917 3910
  */
@@ -3938,7 +3931,7 @@  discard block
 block discarded – undo
3938 3931
 /**
3939 3932
  * Register an annotation url handler.
3940 3933
  *
3941
- * @param string $function_name The function.
3934
+ * @param string $function The function.
3942 3935
  * @param string $extender_name The name, default 'all'.
3943 3936
  *
3944 3937
  * @deprecated 1.8 Use {@link elgg_register_annotation_url_handler()}
@@ -3953,10 +3946,8 @@  discard block
 block discarded – undo
3953 3946
  * It is recommended that you do not call this directly, instead use one of the wrapper functions in the
3954 3947
  * subtype files.
3955 3948
  *
3956
- * @param string $function_name The function to register
3957
- * @param string $extender_type Extender type
3958
- * @param string $extender_name The name of the extender
3959
- * @return true|false Depending on success
3949
+ * @param string $function The function to register
3950
+ * @return boolean Depending on success
3960 3951
  *
3961 3952
  * @deprecated 1.8 Use {@link elgg_register_extender_url_handler()}
3962 3953
  */
@@ -3972,7 +3963,7 @@  discard block
 block discarded – undo
3972 3963
  *
3973 3964
  * @param string $type The type of entity (object, site, user, group)
3974 3965
  * @param string $subtype The subtype to register (may be blank)
3975
- * @return true|false Depending on success
3966
+ * @return boolean Depending on success
3976 3967
  * 
3977 3968
  * @deprecated 1.8 Use {@link elgg_register_entity_type()}
3978 3969
  */
@@ -3984,7 +3975,7 @@  discard block
 block discarded – undo
3984 3975
 /**
3985 3976
  * Register a metadata url handler.
3986 3977
  *
3987
- * @param string $function_name The function.
3978
+ * @param string $function The function.
3988 3979
  * @param string $extender_name The name, default 'all'.
3989 3980
  * 
3990 3981
  * @deprecated 1.8 Use {@link elgg_register_metadata_url_handler()}
@@ -3998,7 +3989,7 @@  discard block
 block discarded – undo
3998 3989
  *
3999 3990
  * @param string $function_name The function to register
4000 3991
  * @param string $relationship_type The relationship type.
4001
- * @return true|false Depending on success
3992
+ * @return boolean Depending on success
4002 3993
  * 
4003 3994
  * @deprecated 1.8 Use {@link elgg_register_relationship_url_handler()}
4004 3995
  */
@@ -4310,7 +4301,7 @@  discard block
 block discarded – undo
4310 4301
  *
4311 4302
  * @param string $handler The identifier for the widget handler
4312 4303
  *
4313
- * @return void
4304
+ * @return boolean
4314 4305
  * @since 1.7.1
4315 4306
  * @deprecated 1.8 Use elgg_unregister_widget_type
4316 4307
  */
@@ -4409,7 +4400,7 @@  discard block
 block discarded – undo
4409 4400
  * @param string $context      Profile or dashboard
4410 4401
  * @param int    $owner        Owner guid
4411 4402
  *
4412
- * @return void
4403
+ * @return boolean
4413 4404
  * @deprecated 1.8 Don't use.
4414 4405
  */
4415 4406
 function reorder_widgets_from_panel($panelstring1, $panelstring2, $panelstring3, $context, $owner) {
@@ -4654,7 +4645,7 @@  discard block
 block discarded – undo
4654 4645
  * @param array  $page    The page URL elements
4655 4646
  * @param string $handler The base handler
4656 4647
  *
4657
- * @return true|false Depending on success
4648
+ * @return boolean Depending on success
4658 4649
  * @deprecated 1.8
4659 4650
  */
4660 4651
 function default_page_handler($page, $handler) {
Please login to merge, or discard this patch.
engine/lib/deprecated-1.9.php 1 patch
Doc Comments   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
  *
213 213
  * @param int $id Annotation id
214 214
  *
215
- * @return string|bool False on failure
215
+ * @return string|false False on failure
216 216
  * @deprecated 1.9 Use method getURL() on annotation object
217 217
  */
218 218
 function get_annotation_url($id) {
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
  * @param string $extender_name The name, default 'all'.
246 246
  * @param string $function_name The function.
247 247
  *
248
- * @return string
248
+ * @return boolean
249 249
  * @deprecated 1.9 Use the plugin hook in \ElggExtender::getURL()
250 250
  */
251 251
 function elgg_register_annotation_url_handler($extender_name = "all", $function_name) {
@@ -2007,7 +2007,7 @@  discard block
 block discarded – undo
2007 2007
  * @param string $type    The type of entity (object, site, user, group)
2008 2008
  * @param string $subtype The subtype to register (may be blank)
2009 2009
  *
2010
- * @return true|false Depending on success
2010
+ * @return boolean Depending on success
2011 2011
  * @deprecated 1.9 Use {@link elgg_unregister_entity_type()}
2012 2012
  */
2013 2013
 function unregister_entity_type($type, $subtype) {
@@ -2086,7 +2086,7 @@  discard block
 block discarded – undo
2086 2086
  * @param int $guid_one This is the target object
2087 2087
  * @param int $guid_two This is the object trying to attach to $guid_one
2088 2088
  *
2089
- * @return true|void
2089
+ * @return boolean|null
2090 2090
  * @access private
2091 2091
  * @deprecated 1.9 Use add_entity_relationship()
2092 2092
  */
@@ -2343,7 +2343,7 @@  discard block
 block discarded – undo
2343 2343
  *
2344 2344
  * @param string $handler  Web services type
2345 2345
  * @param string $function Your function name
2346
- * @return bool Depending on success
2346
+ * @return boolean|null Depending on success
2347 2347
  * @deprecated 1.9 Enable the web services plugin and use elgg_ws_register_service_handler().
2348 2348
  */
2349 2349
 function register_service_handler($handler, $function) {
@@ -2621,7 +2621,7 @@  discard block
 block discarded – undo
2621 2621
  *
2622 2622
  * @param XmlElement $element The element(s)
2623 2623
  *
2624
- * @return mixed An ODD object if the element can be handled, or false.
2624
+ * @return ODD An ODD object if the element can be handled, or false.
2625 2625
  * @access private
2626 2626
  * @deprecated 1.9
2627 2627
  */
@@ -3354,7 +3354,7 @@  discard block
 block discarded – undo
3354 3354
  * @param array  $params  An associated array of other parameters for this handler
3355 3355
  *                        defining some properties eg. supported msg length or rich text support.
3356 3356
  *
3357
- * @return bool
3357
+ * @return boolean|null
3358 3358
  * @deprecated 1.9 Use elgg_register_notification_method()
3359 3359
  */
3360 3360
 function register_notification_handler($method, $handler, $params = NULL) {
@@ -3389,7 +3389,7 @@  discard block
 block discarded – undo
3389 3389
  * @param mixed  $returnvalue Value from previous hook
3390 3390
  * @param mixed  $params      Array of params
3391 3391
  *
3392
- * @return mixed
3392
+ * @return ElggEntity|null
3393 3393
  * @elgg_plugin_hook_handler import all
3394 3394
  * @todo document
3395 3395
  * @access private
@@ -3565,7 +3565,7 @@  discard block
 block discarded – undo
3565 3565
  * @param string $returnvalue Return value from previous hook
3566 3566
  * @param array  $params      The parameters
3567 3567
  *
3568
- * @return null
3568
+ * @return boolean|null
3569 3569
  * @elgg_plugin_hook_handler volatile metadata
3570 3570
  * @todo investigate more.
3571 3571
  * @throws ImportException
@@ -3724,7 +3724,7 @@  discard block
 block discarded – undo
3724 3724
  * @param mixed  $returnvalue Value from previous hook
3725 3725
  * @param mixed  $params      Array of params
3726 3726
  *
3727
- * @return mixed
3727
+ * @return ElggRelationship|null
3728 3728
  * @access private
3729 3729
  * @deprecated 1.9
3730 3730
  */
Please login to merge, or discard this patch.