Import::generateUniqueUsername() - Code Metrics - Inspection of "Replace newer files" - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — pleio-replacement ( 9f67f7...58f6a1 )

unknown

created 2018-03-15 17:17 UTC

Import::generateUniqueUsername() A

↳ Parent: Import

Complexity

Conditions	3
Paths	2

Size

Total Lines	23
Code Lines	14

Duplication

Lines	11
Ratio	47.83 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	14
nc	2
nop	1
dl	11
loc	23
rs	9.0856
c	0
b	0
f	0
ccs	0
cts	17
cp	0
crap	12

<?php
namespace ModPleio;

class Import {
    public function extractData($columns, $data) {
        $result = [];
        foreach ($columns as $id => $metadata_name) {
            if (!$metadata_name) {
                continue;
            }

            $result[$metadata_name] = $data[$id];
        }

        return $result;
    }

    public function registerUser($data) {
        if (!$data["name"] || !$data["email"]) {
            return false;
        }

        $user = false;

        try {
            $username = Import::generateUniqueUsername($data);
            $password = generate_random_cleartext_password();
            $guid = register_user($username, $password, $data["name"], $data["email"]);
            elgg_set_user_validation_status($guid, true, "email");
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $user = get_entity($guid);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        } catch (Exception $e) {

            elgg_log("Could not register user " . $e->getMessage(), "ERROR");
        }

        return $user;
    }

    public function generateUniqueUsername($data) {
        $email = $data["email"];
        list($name, $email) = explode("@", $email);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        $name = trim($name);

        $hidden = access_show_hidden_entities(true);

        if (get_user_by_username($name)) {
            $i = 1;

            while (get_user_by_username($name . $i)) {
                $i++;
            }
            
            $result = $name . $i;
        } else {
            $result = $name;
        }

        access_show_hidden_entities($hidden);

        return $result;
    }

    public function getUserByAttributes($data) {
        $user = false;

        if ($data["guid"]) {
            $user = get_entity($data["guid"]);
        } elseif ($data["username"]) {
            $user = get_user_by_username($data["username"]);
        } elseif ($data["email"]) {
            $users = get_user_by_email($data["email"]);
            $user = $users[0];
        }

        return $user;
    }
}

1		<?php
2		namespace ModPleio;
3
4		class Import {
5		public function extractData($columns, $data) {
6		$result = [];
7		foreach ($columns as $id => $metadata_name) {
8		if (!$metadata_name) {
9		continue;
10		}
11
12		$result[$metadata_name] = $data[$id];
13		}
14
15		return $result;
16		}
17
18		public function registerUser($data) {
19		if (!$data["name"] \|\| !$data["email"]) {
20		return false;
21		}
22
23		$user = false;
24
25		try {
26		$username = Import::generateUniqueUsername($data);
27		$password = generate_random_cleartext_password();
28		$guid = register_user($username, $password, $data["name"], $data["email"]);
29		elgg_set_user_validation_status($guid, true, "email");
		0 ignored issues – show Bug introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report It seems like `$guid` defined by `register_user($username,...name'], $data['email'])` on line `28` can also be of type `false` or `null`; however, `elgg_set_user_validation_status()` does only seem to accept `integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
30		$user = get_entity($guid);
		0 ignored issues – show Bug introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report It seems like `$guid` defined by `register_user($username,...name'], $data['email'])` on line `28` can also be of type `false` or `null`; however, `get_entity()` does only seem to accept `integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
31		} catch (Exception $e) {
		0 ignored issues – show Bug introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report The class `ModPleio\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
32		elgg_log("Could not register user " . $e->getMessage(), "ERROR");
33		}
34
35		return $user;
36		}
37
38		public function generateUniqueUsername($data) {
39		$email = $data["email"];
40		list($name, $email) = explode("@", $email);
		0 ignored issues – show Unused Code introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report The assignment to `$email` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
41		$name = trim($name);
42
43		$hidden = access_show_hidden_entities(true);
44
45	View Code Duplication	if (get_user_by_username($name)) {
46		$i = 1;
47
48		while (get_user_by_username($name . $i)) {
49		$i++;
50		}
51
52		$result = $name . $i;
53		} else {
54		$result = $name;
55		}
56
57		access_show_hidden_entities($hidden);
58
59		return $result;
60		}
61
62		public function getUserByAttributes($data) {
63		$user = false;
64
65		if ($data["guid"]) {
66		$user = get_entity($data["guid"]);
67		} elseif ($data["username"]) {
68		$user = get_user_by_username($data["username"]);
69		} elseif ($data["email"]) {
70		$users = get_user_by_email($data["email"]);
71		$user = $users[0];
72		}
73
74		return $user;
75		}
76		}

gctools-outilsgc / gcconnex

Push — pleio-replacement ( 9f67f7...58f6a1 )

Import::generateUniqueUsername() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like