start.php ➔ updateorg_collab_page_handler() - Code Metrics - Inspection of "Gccollab User Type Banner" - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2220)

unknown

created 2020-01-06 20:58 UTC

start.php ➔ updateorg_collab_page_handler() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/**
 * GCcollab onboarding
 *
 * Welcome Module
 * Profile Module
 * Groups Module
 *
 * Provides more info on the wire via popup
 *
 * @version 1.0
 */


elgg_register_event_handler('init', 'system', 'onboard_ME_collab');

function onboard_ME_collab() {
    elgg_register_library('elgg:onboarding', elgg_get_plugins_path() . 'gc_onboard_collab/lib/functions.php');

    elgg_register_action("onboard/update-profile", elgg_get_plugins_path() . "/gc_onboard_collab/actions/update-profile.php");

    elgg_register_page_handler('profileonboard', 'profileonboard_collab_page_handler');
    elgg_register_page_handler('groupsonboard', 'groupsonboard_collab_page_handler');
    elgg_register_page_handler('tutorials', 'tutorials_page_handler');
    elgg_register_page_handler('updateorg','updateorg_collab_page_handler');

    //views for intro profile onboarding
    elgg_register_ajax_view('welcome-steps/stepOne');
    elgg_register_ajax_view('welcome-steps/stepTwo');
    elgg_register_ajax_view('welcome-steps/stepThree');
    elgg_register_ajax_view('welcome-steps/stepFour');
    elgg_register_ajax_view('welcome-steps/stepFive');
    elgg_register_ajax_view('welcome-steps/stepSix');

    elgg_extend_view('contactform/form', 'onboard/module_links');
    elgg_extend_view('page/elements/navbar', 'page/elements/update_banner');

}

function profileonboard_collab_page_handler(){
    @include (dirname ( __FILE__ ) . "/pages/onboard-profile.php");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    return true;
}

function groupsonboard_collab_page_handler(){
    @include (dirname ( __FILE__ ) . "/pages/onboard-groups.php");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    return true;
}

function tutorials_page_handler(){
    @include (dirname ( __FILE__ ) . "/pages/tutorials.php");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    return true;
}

function updateorg_collab_page_handler(){
    @include (dirname (__FILE__). "/pages/update-org.php");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    return true;
}

/*
 * get_my_profile_strength_collab
 *
 * Gets the profile strength of the logged in user as an INT value.
 *
 * @author Ethan Wallace
 * @return [INT] [<Profile strength percent>]

 */
function get_my_profile_strength_collab(){

    $userEnt = elgg_get_logged_in_user_entity();

    //avatar
    if($userEnt->getIconURL() !=  elgg_get_site_url() . '_graphics/icons/user/defaultmedium.gif'){
        $avIcon = '<i class="fa fa-check text-primary"></i>';
        $avTotal = 100;
    }else{
        $avIcon = '<i class="fa fa-exclamation-triangle text-danger"></i>';
        $avTotal = 0;
    }

    //About me
    if($userEnt->description){
        $aboutIcon = '<i class="fa fa-check text-primary"></i>';
        $aboutTotal = 100;
    }else{
        $aboutIcon = '<i class="fa fa-exclamation-triangle text-danger"></i>';
        $aboutTotal = 0;
    }

    //basic profile
    $basicCount = 0;

    if($userEnt->university || $userEnt->college || $userEnt->highschool || $userEnt->federal || $userEnt->ministry || $userEnt->municipal || $userEnt->international || $userEnt->ngo || $userEnt->community || $userEnt->business || $userEnt->media || $userEnt->retired || $userEnt->other){
        $basicCount += 20;
    }
    if($userEnt->job){
        $basicCount += 20;
    }
    if($userEnt->location || $userEnt->addressString || $userEnt->addressStringFr){
        $basicCount += 20;
    }
    if($userEnt->email){
        $basicCount += 20;
    }
    if($userEnt->phone || $userEnt->mobile){
        $basicCount += 20;
    }

    //education
    if(count($userEnt->education) >= 1){
        $eduCount = 100;
    } else {
        $eduCount = 0;
    }

    //work experience
    if(count($userEnt->work) >= 1){
        $workCount = 100;
    } else {
        $workCount = 0;
    }

    //skills
    if(count($userEnt->gc_skills) >= 3){
        $skillCount = 100;
    } else {
        $skillCount = round(count($userEnt->gc_skills)/3*100);
    }

    //overall total
    $complete = round(($skillCount + $workCount + $eduCount + $basicCount + $aboutTotal + $avTotal)/6);

    //set up profile strength metadata
    $userEnt->profilestrength = $complete;

    return $userEnt->profilestrength;
}


1		<?php
2		/**
3		* GCcollab onboarding
4		*
5		* Welcome Module
6		* Profile Module
7		* Groups Module
8		*
9		* Provides more info on the wire via popup
10		*
11		* @version 1.0
12		*/
13
14
15		elgg_register_event_handler('init', 'system', 'onboard_ME_collab');
16
17		function onboard_ME_collab() {
18		elgg_register_library('elgg:onboarding', elgg_get_plugins_path() . 'gc_onboard_collab/lib/functions.php');
19
20		elgg_register_action("onboard/update-profile", elgg_get_plugins_path() . "/gc_onboard_collab/actions/update-profile.php");
21
22		elgg_register_page_handler('profileonboard', 'profileonboard_collab_page_handler');
23		elgg_register_page_handler('groupsonboard', 'groupsonboard_collab_page_handler');
24		elgg_register_page_handler('tutorials', 'tutorials_page_handler');
25		elgg_register_page_handler('updateorg','updateorg_collab_page_handler');
26
27		//views for intro profile onboarding
28		elgg_register_ajax_view('welcome-steps/stepOne');
29		elgg_register_ajax_view('welcome-steps/stepTwo');
30		elgg_register_ajax_view('welcome-steps/stepThree');
31		elgg_register_ajax_view('welcome-steps/stepFour');
32		elgg_register_ajax_view('welcome-steps/stepFive');
33		elgg_register_ajax_view('welcome-steps/stepSix');
34
35		elgg_extend_view('contactform/form', 'onboard/module_links');
36		elgg_extend_view('page/elements/navbar', 'page/elements/update_banner');
37
38		}
39
40		function profileonboard_collab_page_handler(){
41		@include (dirname ( __FILE__ ) . "/pages/onboard-profile.php");
		0 ignored issues – show Security Best Practice introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
42		return true;
43		}
44
45		function groupsonboard_collab_page_handler(){
46		@include (dirname ( __FILE__ ) . "/pages/onboard-groups.php");
		0 ignored issues – show Security Best Practice introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
47		return true;
48		}
49
50		function tutorials_page_handler(){
51		@include (dirname ( __FILE__ ) . "/pages/tutorials.php");
		0 ignored issues – show Security Best Practice introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
52		return true;
53		}
54
55		function updateorg_collab_page_handler(){
56		@include (dirname (__FILE__). "/pages/update-org.php");
		0 ignored issues – show Security Best Practice introduced 2020-01-02 16:26 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
57		return true;
58		}
59
60		/*
61		* get_my_profile_strength_collab
62		*
63		* Gets the profile strength of the logged in user as an INT value.
64		*
65		* @author Ethan Wallace
66		* @return [INT] [<Profile strength percent>]
		0 ignored issues – show Documentation introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report The doc-type `[INT]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
67		*/
68		function get_my_profile_strength_collab(){
69
70		$userEnt = elgg_get_logged_in_user_entity();
71
72		//avatar
73	View Code Duplication	if($userEnt->getIconURL() != elgg_get_site_url() . '_graphics/icons/user/defaultmedium.gif'){
74		$avIcon = '<i class="fa fa-check text-primary"></i>';
75		$avTotal = 100;
76		}else{
77		$avIcon = '<i class="fa fa-exclamation-triangle text-danger"></i>';
78		$avTotal = 0;
79		}
80
81		//About me
82	View Code Duplication	if($userEnt->description){
83		$aboutIcon = '<i class="fa fa-check text-primary"></i>';
84		$aboutTotal = 100;
85		}else{
86		$aboutIcon = '<i class="fa fa-exclamation-triangle text-danger"></i>';
87		$aboutTotal = 0;
88		}
89
90		//basic profile
91		$basicCount = 0;
92
93	View Code Duplication	if($userEnt->university \|\| $userEnt->college \|\| $userEnt->highschool \|\| $userEnt->federal \|\| $userEnt->ministry \|\| $userEnt->municipal \|\| $userEnt->international \|\| $userEnt->ngo \|\| $userEnt->community \|\| $userEnt->business \|\| $userEnt->media \|\| $userEnt->retired \|\| $userEnt->other){
94		$basicCount += 20;
95		}
96		if($userEnt->job){
97		$basicCount += 20;
98		}
99		if($userEnt->location \|\| $userEnt->addressString \|\| $userEnt->addressStringFr){
100		$basicCount += 20;
101		}
102		if($userEnt->email){
103		$basicCount += 20;
104		}
105		if($userEnt->phone \|\| $userEnt->mobile){
106		$basicCount += 20;
107		}
108
109		//education
110		if(count($userEnt->education) >= 1){
111		$eduCount = 100;
112		} else {
113		$eduCount = 0;
114		}
115
116		//work experience
117		if(count($userEnt->work) >= 1){
118		$workCount = 100;
119		} else {
120		$workCount = 0;
121		}
122
123		//skills
124	View Code Duplication	if(count($userEnt->gc_skills) >= 3){
125		$skillCount = 100;
126		} else {
127		$skillCount = round(count($userEnt->gc_skills)/3*100);
128		}
129
130		//overall total
131		$complete = round(($skillCount + $workCount + $eduCount + $basicCount + $aboutTotal + $avTotal)/6);
132
133		//set up profile strength metadata
134		$userEnt->profilestrength = $complete;
135
136		return $userEnt->profilestrength;
137		}
138

gctools-outilsgc / gcconnex

Pull Request — master (#2220)

start.php ➔ updateorg_collab_page_handler() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like