start.php ➔ global_url_handler() - Code Metrics - Inspection of "Merge remote-tracking branch 'refs/remotes/origin/..." - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Api_opt ( 47a261...24829b )

unknown

created 2018-03-13 13:43 UTC

start.php ➔ global_url_handler() C

↳ Parent: Project

Complexity

Conditions	11
Paths	8

Size

Total Lines	30
Code Lines	16

Duplication

Lines	8
Ratio	26.67 %

Importance

Changes

Metric	Value
cc	11
eloc	16
nc	8
nop	4
dl	8
loc	30
rs	5.2653
c	0
b	0
f	0

How to fix Complexity

<?php


elgg_register_event_handler('init', 'system', 'gc_lang_url_handler_init');
elgg_register_plugin_hook_handler('route', 'all', 'global_url_handler', 10);

function gc_lang_url_handler_init($param1, $param2, $param3) {
	// empty ...
}

/**
 * Handles incoming HTTP Request from the GSA, this acts as the security layer for the GSA only
 * @param $hook
 * @param $type
 * @param $returnvalue
 * @param $params
 * @return False to stop processing the response, True will let elgg handle the response
 */
function global_url_handler($hook, $type, $returnvalue, $params) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

	// checks to make sure that the url does not affect the ajax calls
	if (strpos($_SERVER['PHP_SELF'], 'ajax') !== false) return;
	
	if (strpos($_SERVER['PHP_SELF'], '/view') !== false || strpos($_SERVER['PHP_SELF'], '/profile') !== false) {

		if ($_GET["language"] == 'fr') { 
			if ($_COOKIE['connex_lang'] != 'fr') {
				setcookie('connex_lang', 'fr', 0, '/');
				Header('Location: '.$_SERVER['PHP_SELF']);
			}
		} elseif ($_GET["language"] == 'en') {
			if ($_COOKIE['connex_lang'] != 'en') {
				setcookie('connex_lang', 'en', 0, '/');
				Header('Location: '.$_SERVER['PHP_SELF']);
			}
		} else {
			if ($_GET["language"] == '' || $_GET["language"] != 'en' || $_GET["language"] != 'fr'  )  {
				
				forward("?language=" . get_current_language());
			}
		}

	} else {

		return;
	}
	
}




1		<?php
2
3
4		elgg_register_event_handler('init', 'system', 'gc_lang_url_handler_init');
5		elgg_register_plugin_hook_handler('route', 'all', 'global_url_handler', 10);
6
7		function gc_lang_url_handler_init($param1, $param2, $param3) {
8		// empty ...
9		}
10
11		/**
12		* Handles incoming HTTP Request from the GSA, this acts as the security layer for the GSA only
13		* @param $hook
14		* @param $type
15		* @param $returnvalue
16		* @param $params
17		* @return False to stop processing the response, True will let elgg handle the response
18		*/
19		function global_url_handler($hook, $type, $returnvalue, $params) {
		0 ignored issues – show Coding Style introduced 2018-02-05 16:13 UTC by Report Bug Copy Issue Report `global_url_handler` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2018-02-05 16:13 UTC by Report Bug Copy Issue Report `global_url_handler` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2018-02-05 16:13 UTC by Report Bug Copy Issue Report `global_url_handler` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
20
21		// checks to make sure that the url does not affect the ajax calls
22		if (strpos($_SERVER['PHP_SELF'], 'ajax') !== false) return;
23
24		if (strpos($_SERVER['PHP_SELF'], '/view') !== false \|\| strpos($_SERVER['PHP_SELF'], '/profile') !== false) {
25
26		if ($_GET["language"] == 'fr') {
27	View Code Duplication	if ($_COOKIE['connex_lang'] != 'fr') {
28		setcookie('connex_lang', 'fr', 0, '/');
29		Header('Location: '.$_SERVER['PHP_SELF']);
30		}
31		} elseif ($_GET["language"] == 'en') {
32	View Code Duplication	if ($_COOKIE['connex_lang'] != 'en') {
33		setcookie('connex_lang', 'en', 0, '/');
34		Header('Location: '.$_SERVER['PHP_SELF']);
35		}
36		} else {
37		if ($_GET["language"] == '' \|\| $_GET["language"] != 'en' \|\| $_GET["language"] != 'fr' ) {
38
39		forward("?language=" . get_current_language());
40		}
41		}
42
43		} else {
44
45		return;
46		}
47
48		}
49
50
51

gctools-outilsgc / gcconnex

Push — Api_opt ( 47a261...24829b )

start.php ➔ global_url_handler() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like