FGContactForm::Validate() - Code Metrics - Inspection of "Update .travis.yml" - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed
Branch — gcconnex (718fe4)

by Ilia
created 2017-09-27 15:56 UTC
FGContactForm::Validate() F

↳ Parent: FGContactForm
Complexity

Conditions	19
Paths	7776
Size

Total Lines	137
Code Lines	80
Duplication

Lines	137
Ratio	100 %
Importance

Changes
Metric	Value
cc	19
eloc	80
nc	7776
nop	0
dl	137
loc	137
rs	2
c	0
b	0
f	0
How to fix Long Method Complexity

<?PHP
/*
    Contact Form from HTML Form Guide

    This program is free software published under the
    terms of the GNU Lesser General Public License.

This program is distributed in the hope that it will
be useful - WITHOUT ANY WARRANTY; without even the
implied warranty of MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

@copyright html-form-guide.com 2010
*/
require_once( elgg_get_plugins_path() ."phpmailer/vendors/class.phpmailer.php");

/*
Interface to Captcha handler
*/
class FG_CaptchaHandler
{
    function Validate() { return false;}

    function GetError(){ return '';}

}
/*
FGContactForm is a general purpose contact form class
It supports Captcha, HTML Emails, sending emails
conditionally, File atachments and more.
*/
class FGContactForm

{
    var $receipients;
    var $errors;
    var $error_message;
    var $name;
    var $email;
    var $message;
    var $from_address;
    var $form_random_key;
    var $conditional_field;
    var $arr_conditional_receipients;
    var $fileupload_fields;
    var $captcha_handler;
    var $mailer;

    function FGContactForm()

    {
        $this->receipients = array();
        $this->errors = array();
        $this->form_random_key = 'HTgsjhartag';
        $this->conditional_field='';
        $this->arr_conditional_receipients=array();
        $this->fileupload_fields=array();
        $this->mailer = new PHPMailer();
        $this->mailer->CharSet = 'utf-8';
        $this->mailer->IsSMTP();
        $this->mailer->Host = elgg_get_plugin_setting('phpmailer_host', 'phpmailer'); // SMTP server
        $this->mailer->Port = elgg_get_plugin_setting('ep_phpmailer_port', 'phpmailer'); // SMTP server port
        $this->mailer->SMTPSecure = 'tls';
        $this->mailer->SMTPAuth = 'true';
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->mailer->Username = elgg_get_plugin_setting('phpmailer_username', 'phpmailer');
        $this->mailer->Password = elgg_get_plugin_setting('phpmailer_password', 'phpmailer');
    }

    function EnableCaptcha($captcha_handler)

    {
        $this->captcha_handler = $captcha_handler;
        session_start();
    }

    function AddRecipient($email,$name="")

    {
        $this->mailer->AddAddress($email,$name);
    }

    function SetFromAddress($from)

    {
        $this->from_address = $from;
    }
    function SetFormRandomKey($key)

    {
        $this->form_random_key = $key;
    }
    function GetSpamTrapInputName()

    {
        return 'sp'.md5('KHGdnbvsgst'.$this->GetKey());
    }
    function SafeDisplay($value_name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if(empty($_POST[$value_name]))
        {
            return'';
        }
        return htmlentities($_POST[$value_name]);
    }
    function GetFormIDInputName()

    {
        $rand = md5('TygshRt'.$this->GetKey());

        $rand = substr($rand,0,20);
        return 'id'.$rand;
    }


    function GetFormIDInputValue()

    {
        return md5('jhgahTsajhg'.$this->GetKey());
    }

    function SetConditionalField($field)

    {
        $this->conditional_field = $field;
    }
    function AddConditionalReceipent($value,$email)

    {
        $this->arr_conditional_receipients[$value] =  $email;
    }

    function AddFileUploadField($file_field_name,$accepted_types,$max_size)

    {

        $this->fileupload_fields[] =
            array("name"=>$file_field_name,
            "file_types"=>$accepted_types,
            "maxsize"=>$max_size);
    }

    function ProcessForm()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if(!isset($_POST['submitted']))
        {
           return false;
        }
        if(!$this->Validate())
        {
           // $this->error_message = implode('<br/><br/><br/>',$this->errors);
            return false;
        }
        $this->CollectData();

        $ret = $this->SendFormSubmission();

        return $ret;
    }

    function RedirectToURL($url)

    {
        header("Location: $url");
        exit;

    }

    function GetErrorMessage()

    {
        return $this->error_message;
    }
    function GetSelfScript()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return htmlentities($_SERVER['PHP_SELF']);
    }

    function GetName()

    {
        return $this->name;
    }
    function GetEmail()

    {
        return $this->email;
    }
    function GetMessage()

    {
        return htmlentities($this->message,ENT_QUOTES,"UTF-8");
    }

/*--------  Private (Internal) Functions -------- */


    function SendFormSubmission()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
              $reason = $_POST['reason'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $option = explode("$", $_POST['reason']);
                    $categoryfr = $option[0];
                    $categoryen = $option[1]; 

        $depart = $_POST['depart'];
        $reason = $_POST['reason'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $option = explode("$", $_POST['reason']);
                    $french = $option[0];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    $english = $option[1]; 
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
         if(empty($_POST['subject']))
           {
           $subject = $categoryen." - ".$depart. " - $this->name  / ".$categoryfr." - ".$depart. " - $this->name";
           }else{
            $subject = "GCconnex - ".$depart. " - $this->name  / GCconnex - ".$depart. " - $this->name";
           }
        
        $this->CollectConditionalReceipients();
        $this->mailer->CharSet = 'utf-8';
        $this->mailer->Subject = $subject;
        $this->mailer->From = elgg_get_plugin_setting('phpmailer_from_email', 'phpmailer');
        $this->mailer->FromName = elgg_get_plugin_setting('phpmailer_from_name', 'phpmailer');
        $this->mailer->AddCC($this->email);
        $message = $this->ComposeFormtoEmail();
        $this->mailer->ConfirmReadingTo = $this->email;
        $textMsg = trim(strip_tags(preg_replace('/<(head|title|style|script)[^>]*>.*?<\/\\1>/s','',$message)));
        $this->mailer->AltBody = @html_entity_decode($textMsg,ENT_QUOTES,"UTF-8");
        $this->mailer->MsgHTML($message);
        $this->AttachFiles();

        if(!$this->mailer->Send())
        {
            $this->add_error("Failed sending email!");
            return false;
        }

        return true;
    }

    function CollectConditionalReceipients()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if(count($this->arr_conditional_receipients)>0 &&
          !empty($this->conditional_field) &&
          !empty($_POST[$this->conditional_field]))
        {
            foreach($this->arr_conditional_receipients as $condn => $rec)
            {
                if(strcasecmp($condn,$_POST[$this->conditional_field])==0 &&
                !empty($rec))
                {
                    $this->AddRecipient($rec);
                }
            }
        }
    }

    /*
    Internal variables, that you donot want to appear in the email
    Add those variables in this array.
    */
    function IsInternalVariable($varname)

    {
        $arr_interanl_vars = array('scaptcha',
                            'submitted',
                            $this->GetSpamTrapInputName(),
                            $this->GetFormIDInputName()
                            );
        if(in_array($varname,$arr_interanl_vars))
        {
            return true;
        }
        return false;
    }

    function FormSubmissionToMail()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ret_str='';
        
                $name = $_POST['name'];
                $email = $_POST['email'];
                $reason = $_POST['reason'];
                $option = explode("$", $_POST['reason']);
                    $french = $option[0];
                    $english = $option[1]; 
                if(empty($_POST['subject']))
                {
                    $subject = "$this->name has contacted you about ". $english." / $this->name vous a envoyé un message à propos de ".$french;
                }else{
                    $subject = $_POST['subject'];
                }
        
                $message = $_POST['message'];
        
        $name=htmlentities($name, ENT_QUOTES, "UTF-8");
        $email=htmlentities($email, ENT_QUOTES, "UTF-8");
        $reason=htmlentities($reason, ENT_QUOTES, "UTF-8");
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $subject=htmlentities($subject, ENT_QUOTES, "UTF-8");
        $message=htmlentities($message, ENT_QUOTES, "UTF-8");
      
                $value = htmlentities($value,ENT_QUOTES,"UTF-8");
function someFunction() {
    $x = 5;
    echo $x;
}
                $value = nl2br($value);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $key = ucfirst($key);
function someFunction() {
    $x = 5;
    echo $x;
}
                $ret_str .= '

<!-- beginning of email template -->
  <div width="100%" bgcolor="#fcfcfc">
    <div>
      <div>

        <!-- email header -->
            <div align="center" width="100%" style="background-color:#f5f5f5; padding:20px 30px 15px 30px; font-family: sans-serif; font-size: 12px; color: #055959">
              Thank you for contacting the GCconnex Help desk. This is a copy of your request.<br/><br/> Merci d\'avoir communiqué avec le bureau de soutien de GCconnex. Ceci est une copie de votre requête.
            </div>
        

            <!-- GCconnex banner -->
            <div width="100%" style="padding: 0 0 0 10px; color:#ffffff; font-family: sans-serif; font-size: 35px; line-height:38px; font-weight: bold; background-color:#047177;">
            <span style="padding: 0 0 0 3px; font-size: 20px; color: #ffffff; font-family: sans-serif;">GCconnex</span>
            </div>

            <!-- email divider -->
            <div style="height:1px; background:#bdbdbd; border-bottom:1px solid #ffffff"></div>

<!-- english -->

            <!-- main content of the notification (ENGLISH) -->
            <!-- *optional* email message (DO NOT REPLY) -->
            <div width="100%" style="padding:30px 30px 10px 30px; font-size:12px; line-height:22px; font-family:sans-serif;">

            <!-- The French Follows... -->
            <span style="font-size:12px; font-weight: normal;"><i>(Le fran&ccedil;ais suit)</i></span><br/>  
            </div>

            <div width="100%" style="padding:30px 30px 30px 30px; color:#153643; font-family:sans-serif; font-size:16px; line-height:22px; ">
            <!-- TITLE OF CONTENT -->
            <h2 style="padding: 0px 0px 15px 0px">
            <strong> GCconnex Contact Us Form </strong>
            </h2>

            <!-- BODY OF CONTENT -->
            <b>Name:</b> '.$name.'<br/>
            <b>Email:</b> '.$email.'<br/>
            <b>Reason:</b> '.$english.' <br/>
            <b>Subject:</b> '.$subject.'<br/>
            <b>Message:</b>'.$message .'<br/>
            </div>
                
            <div style="margin-top:15px; padding: 5px; color: #6d6d6d; border-bottom: 1px solid #ddd;"></div>
                
<!-- french -->

            <!-- main content of the notification (FRENCH) -->
            <!-- *optional* email message (DO NOT REPLY) -->
            <div id="gcc_fr_suit" name="gcc_fr_suit" width="100%" style="padding:30px 30px 10px 30px; font-size:12px; line-height:22px; font-family:sans-serif;"></div>

            <div width="100%" style="padding:30px 30px 30px 30px; color:#153643; font-family:sans-serif; font-size:16px; line-height:22px;">
            <!-- TITLE OF CONTENT -->
            <h2 style="padding: 0px 0px 15px 0px">
            <strong> Formulaire contactez-nous de GCconnex</strong>
            </h2>

            <!-- BODY OF CONTENT -->
            <b>Nom :</b> '.$name.'<br/> 
            <b>Courriel :</b> '.$email.'<br/>
            <b>Raison :</b> '.$french.'<br/>
            <b>Sujet :</b> '.$subject.'<br/>
            <b>Message :</b>'.$message.'<br/>
            </div>
            <div style="margin-top:15px; padding: 5px; color: #6d6d6d;"></div>

            <!-- email divider -->
            <div style="height:1px; background:#bdbdbd; border-bottom:1px solid #ffffff"></div>

            <!-- email footer -->
            <div align="center" width="100%" style="background-color:#f5f5f5; padding:20px 30px 15px 30px; font-family: sans-serif; font-size: 16px; color: #055959">
            Please do not reply to this message | Veuillez ne pas répondre à ce message
            </div>

      </div>
    </div>
  </div>';

        foreach($this->fileupload_fields as $upload_field)
        {
            $field_name = $upload_field["name"];
            if(!$this->IsFileUploaded($field_name))
            {
                continue;
            }        
            
            $filename = basename($_FILES[$field_name]['name']);
            $ret_str .= "<div class='label'>File upload '$field_name' :</div><div class='value'>$filename </div>\n";
        }
        return $ret_str;
    }

    function ExtraInfoToMail()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ret_str='';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $ip = $_SERVER['REMOTE_ADDR'];
        $ret_str = "<div class='label'>IP address of the submitter:</div><div class='value'>$ip</div>\n";

        return $ret_str;
    }

    function GetHTMLHeaderPart()

    {
         $retstr = '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">'."\n".
                   '<html><head><title></title><style type="text/css">
  body {margin: 0; padding: 0; min-width: 100%!important;}
  img {height: auto;}
  .content {width: 100%; max-width: 600px;}
  .header {padding: 40px 30px 20px 30px;}
  .innerpadding {padding: 30px 30px 30px 30px;}
  .borderbottom {border-bottom: 1px solid #f2eeed;}
  .subhead {font-size: 15px; color: #ffffff; font-family: sans-serif; }
  .h1, .h2, .bodycopy {color: #153643; font-family: sans-serif;}
  .h1 {font-size: 33px; line-height: 38px; font-weight: bold;}
  .h2 {padding: 0 0 15px 0; font-size: 24px; line-height: 28px; font-weight: bold;}
  .bodycopy {font-size: 16px; line-height: 22px;}
  .button {text-align: center; font-size: 18px; font-family: sans-serif; font-weight: bold; padding: 0 30px 0 30px;}
  .button a {color: #ffffff; text-decoration: none;}
  .footer {padding: 20px 30px 15px 30px;}
  .footercopy {font-family: sans-serif; font-size: 14px; color: #ffffff;}
  .footercopy a {color: #ffffff; text-decoration: underline;}
  @media only screen and (max-width: 550px), screen and (max-device-width: 550px) {
  body[yahoo] .hide {display: none!important;}
  body[yahoo] .buttonwrapper {background-color: transparent!important;}
  body[yahoo] .button {padding: 0px!important;}
  body[yahoo] .button a {background-color: #e05443; padding: 15px 15px 13px!important;}
  body[yahoo] .unsubscribe {display: block; margin-top: 20px; padding: 10px 50px; background: #2f3942; border-radius: 5px; text-decoration: none!important; font-weight: bold;}
  }
  /*@media only screen and (min-device-width: 601px) {
    .content {width: 600px !important;}
    .col425 {width: 425px!important;}
    .col380 {width: 380px!important;}
    }*/
  </style>'.
  '<meta http-equiv=Content-Type content="text/html; charset=utf-8">';
       
         $retstr .= '</head><body yahoo bgcolor="#fcfcfc" style="margin: 0; padding: 0; min-width: 100%!important;">';
         return $retstr;
    }

    function GetHTMLFooterPart()

    {
        $retstr ='</body></html>';
        return $retstr ;
    }

    function ComposeFormtoEmail()

    {
        $header = $this->GetHTMLHeaderPart();
        $formsubmission = $this->FormSubmissionToMail();
        $footer = $this->GetHTMLFooterPart();
        $message = $header."<p>$formsubmission</p><hr/>$extra_info".$footer;


        return $message;
    }

    function AttachFiles()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        foreach($this->fileupload_fields as $upld_field)
        {
            $field_name = $upld_field["name"];
            if(!$this->IsFileUploaded($field_name))
            {
                continue;
            }
            
            $filename =basename($_FILES[$field_name]['name']);
            $this->mailer->AddAttachment($_FILES[$field_name]["tmp_name"],$filename);
        }
    }

    function GetFromAddress()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if(!empty($this->from_address))
        {
            return $this->from_address;
        }

        $host = $_SERVER['SERVER_NAME'];
        $from ="nobody@$host";
        return $from;
    }

    function Validate()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ret = true;
        $numErr=0;
        //security validations
        if(empty($_POST[$this->GetFormIDInputName()]) ||
          $_POST[$this->GetFormIDInputName()] != $this->GetFormIDInputValue() )
        {
            $numErr=$numErr+1;
            //The proper error is not given intentionally
            $this->add_error();

            register_error("Automated submission prevention: case 1 failed");
            $ret = false;
        }

        //This is a hidden input field. Humans won't fill this field.
        if(!empty($_POST[$this->GetSpamTrapInputName()]) )
        {
            $numErr=$numErr+1;
            //The proper error is not given intentionally
            $this->add_error();

            register_error("Automated submission prevention: case 2 failed");
            $ret = false;
        }

        //select validations
        if((($_POST['reason']) =='Select...') || (($_POST['reason']) == "Choisir..."))
        {
            $numErr=$numErr+1;
            $this->add_error();

            register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Errreason')));
            $ret = false;
        }

        if ($_POST['reason'] == 'Autres$Other')
        {
            if (empty($_POST['subject']))
            {
                $numErr=$numErr+1;
                $this->add_error();

                register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Errsubject')));
                $ret = false;
            }
        }

        //name validations
        if(empty($_POST['name']))
        {
            $numErr=$numErr+1;
            $this->add_error();

            //'contactform:Errname'
            register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Errname')));
            $ret = false;
        }
        else
            if(strlen($_POST['name'])>75)
            {
                $numErr=$numErr+1;
                $this->add_error();

                //'contactform:Errnamebig'
                register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Errnamebig')));
                $ret = false;
            }

        //email validations
        if(empty($_POST['email']))
        {
            $numErr=$numErr+1;
            $this->add_error();

            register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Erremail')));
            $ret = false;
        }
        else
            if(strlen($_POST['email'])>100)
            {
                $numErr=$numErr+1;
                $this->add_error();

                register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Erremailbig')));
                $ret = false;
            }
            else
                if(!$this->validate_email($_POST['email']))
                {
                    $numErr=$numErr+1;
                    $this->add_error();

                    //'contactform:Erremailvalid'
                    register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Erremailvalid')));
                    $ret = false;
                }

        //department validaions
        if (elgg_is_active_plugin('gcconnex_theme')) {
            if(empty($_POST['depart']))
            {
                $numErr=$numErr+1;
                $this->add_error();

                register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Errdepart')));
                $ret = false;
            }
            else
                if(strlen($_POST['depart'])>255)
                {
                    $numErr=$numErr+1;
                    $this->add_error();

                    register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Errdepartbig')));
                    $ret = false;
                }
        }

        //message validaions
        if(empty($_POST['message']))
        {
            $numErr=$numErr+1;
            $this->add_error();

            register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Errmess')));
            $ret = false;
        }
        else
            if(strlen($_POST['message'])>2048)
            {
                $numErr=$numErr+1;
                $this->add_error();

                register_error(str_replace('[#]',$numErr,elgg_echo('contactform:Errmessbig')));
                $ret = false;
            }

        //file upload validations
        if(!empty($this->fileupload_fields))
        {
            $numErr=$numErr+1;
            if(!$this->ValidateFileUploads($numErr))

            {
                $ret = false;
            }
        }
        return $ret;
    }

    function ValidateFileType($field_name,$valid_filetypes)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ret=true;
        $info = pathinfo($_FILES[$field_name]['name']);
        $extn = $info['extension'];
        $extn = strtolower($extn);

        $arr_valid_filetypes= explode(',',$valid_filetypes);
        if(!in_array($extn,$arr_valid_filetypes))
        {
            $this->add_error();

            register_error("Valid file types are: $valid_filetypes");
            $ret=false;
        }
        return $ret;
    }

    function ValidateFileSize($field_name,$max_size)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $size_of_uploaded_file = $_FILES[$field_name]["size"]/1024;//size in KBs
        if($size_of_uploaded_file > $max_size)
        {
            $this->add_error();

            register_error("The file is too big. File size should be less than $max_size KB");
            return false;
        }
        return true;
    }

    function IsFileUploaded($field_name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if(empty($_FILES[$field_name]['name']))
        {
            return false;
        }
        if(!is_uploaded_file($_FILES[$field_name]['tmp_name']))
        {
            return false;
        }
        return true;
    }
    function ValidateFileUploads()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ret=true;
        foreach($this->fileupload_fields as $upld_field)
        {
            $field_name = $upld_field["name"];

            $valid_filetypes = $upld_field["file_types"];
            
            if(!$this->IsFileUploaded($field_name))
            {
                continue;
            }

            if($_FILES[$field_name]["error"] != 0)
            {
                $this->add_error("Error in file upload; Error code:".$_FILES[$field_name]["error"]);
                $ret=false;
            }

            if(!empty($valid_filetypes) &&
             !$this->ValidateFileType($field_name,$valid_filetypes))
            {
                $ret=false;
            }

            if(!empty($upld_field["maxsize"]) &&
            $upld_field["maxsize"]>0)
            {
                if(!$this->ValidateFileSize($field_name,$upld_field["maxsize"]))
                {
                    $ret=false;
                }
            }
        }
        return $ret;
    }

    function StripSlashes($str)

    {
        if(get_magic_quotes_gpc())
        {
            $str = stripslashes($str);
        }
        return $str;
    }
    /*
    Sanitize() function removes any potential threat from the
    data submitted. Prevents email injections or any other hacker attempts.
    if $remove_nl is true, newline chracters are removed from the input.
    */
    function Sanitize($str,$remove_nl=true)

    {
        $str = $this->StripSlashes($str);

        if($remove_nl)
        {
            $injections = array('/(\n+)/i',
                '/(\r+)/i',
                '/(\t+)/i',
                '/(%0A+)/i',
                '/(%0D+)/i',
                '/(%08+)/i',
                '/(%09+)/i'
                );
            $str = preg_replace($injections,'',$str);
        }

        return $str;
    }

    /*Collects clean data from the $_POST array and keeps in internal variables.*/
    function CollectData()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->name = $this->Sanitize($_POST['name']);
        $this->email = $this->Sanitize($_POST['email']);

        /*newline is OK in the message.*/
        $this->message = $this->StripSlashes($_POST['message']);
    }

    function add_error($error)

    {
        array_push($this->errors,$error);
    }
    function validate_email($email)

    {
        return eregi("^[_\.0-9a-zA-Z-]+@([0-9a-zA-Z][0-9a-zA-Z-]+\.)+[a-zA-Z]{2,6}$", $email);
    }

    function GetKey()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return $this->form_random_key.$_SERVER['SERVER_NAME'].$_SERVER['REMOTE_ADDR'];
    }

}

?>

1		<?PHP
2		/*
3		Contact Form from HTML Form Guide
4
5		This program is free software published under the
6		terms of the GNU Lesser General Public License.
7
8		This program is distributed in the hope that it will
9		be useful - WITHOUT ANY WARRANTY; without even the
10		implied warranty of MERCHANTABILITY or FITNESS FOR A
11		PARTICULAR PURPOSE.
12
13		@copyright html-form-guide.com 2010
14		*/
15		require_once( elgg_get_plugins_path() ."phpmailer/vendors/class.phpmailer.php");
16
17		/*
18		Interface to Captcha handler
19		*/
20		class FG_CaptchaHandler
21		{
22		function Validate() { return false;}
		0 ignored issues – show Best Practice introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
23		function GetError(){ return '';}
		0 ignored issues – show Best Practice introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
24		}
25		/*
26		FGContactForm is a general purpose contact form class
27		It supports Captcha, HTML Emails, sending emails
28		conditionally, File atachments and more.
29		*/
30	View Code Duplication	class FGContactForm
		0 ignored issues – show Duplication introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		var $receipients;
33		var $errors;
34		var $error_message;
35		var $name;
36		var $email;
37		var $message;
gctools-outilsgc / gcconnex

Branch — gcconnex (718fe4)

FGContactForm::Validate() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
