gctools-outilsgc /
gcconnex
| Conditions | 11 |
| Paths | 56 |
| Total Lines | 65 |
| Code Lines | 20 |
| Lines | 4 |
| Ratio | 6.15 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 181 | function apply_post($user, $guid, $lang) |
||
| 182 | { |
||
| 183 | $user_entity = is_numeric($user) ? get_user($user) : (strpos($user, '@') !== false ? get_user_by_email($user)[0] : get_user_by_username($user)); |
||
| 184 | if (!$user_entity) { |
||
| 185 | return "User was not found. Please try a different GUID, username, or email address"; |
||
| 186 | } |
||
| 187 | if (!$user_entity instanceof ElggUser) { |
||
| 188 | return "Invalid user. Please try a different GUID, username, or email address"; |
||
| 189 | } |
||
| 190 | |||
| 191 | if (!elgg_is_logged_in()) { |
||
| 192 | login($user_entity); |
||
| 193 | } |
||
| 194 | |||
| 195 | $entity = get_entity($guid); |
||
| 196 | if (!$entity) { |
||
| 197 | return "Opportunity was not found. Please try a different GUID"; |
||
| 198 | } |
||
| 199 | if (!elgg_instanceof($entity, 'object', 'mission')) { |
||
| 200 | return "Invalid opportunity. Please try a different GUID"; |
||
| 201 | } |
||
| 202 | |||
| 203 | // Creates an applied relationship between user and mission if there is no relationship there already. |
||
| 204 | View Code Duplication | if(!check_entity_relationship($entity->guid, 'mission_accepted', $user_entity->guid) && !check_entity_relationship($entity->guid, 'mission_tentative', $user_entity->guid)) { |
|
| 205 | add_entity_relationship($entity->guid, 'mission_applied', $user_entity->guid); |
||
| 206 | $message = 'Apply'; |
||
| 207 | } |
||
| 208 | |||
| 209 | // Opt in applicant if they are not opted in yet. |
||
| 210 | if(!check_if_opted_in($user_entity)) { |
||
| 211 | $user_entity->opt_in_missions = 'gcconnex_profile:opt:yes'; |
||
| 212 | $user_entity->save(); |
||
| 213 | } |
||
| 214 | |||
| 215 | return 'You '.$message; |
||
|
|
|||
| 216 | |||
| 217 | // $opportunities = elgg_list_entities(array( |
||
| 218 | // 'type' => 'object', |
||
| 219 | // 'subtype' => 'mission', |
||
| 220 | // 'guid' => $guid |
||
| 221 | // )); |
||
| 222 | // $opportunity = json_decode($opportunities)[0]; |
||
| 223 | |||
| 224 | // $opportunity->title = gc_explode_translation($opportunity->title, $lang); |
||
| 225 | |||
| 226 | // $likes = elgg_get_annotations(array( |
||
| 227 | // 'guid' => $opportunity->guid, |
||
| 228 | // 'annotation_name' => 'likes' |
||
| 229 | // )); |
||
| 230 | // $opportunity->likes = count($likes); |
||
| 231 | |||
| 232 | // $liked = elgg_get_annotations(array( |
||
| 233 | // 'guid' => $opportunity->guid, |
||
| 234 | // 'annotation_owner_guid' => $user_entity->guid, |
||
| 235 | // 'annotation_name' => 'likes' |
||
| 236 | // )); |
||
| 237 | // $opportunity->liked = count($liked) > 0; |
||
| 238 | |||
| 239 | // $opportunity->comments = get_entity_comments($opportunity->guid); |
||
| 240 | |||
| 241 | // $opportunity->userDetails = get_user_block($opportunity->owner_guid, $lang); |
||
| 242 | // $opportunity->description = gc_explode_translation($opportunity->description, $lang); |
||
| 243 | |||
| 244 | //return $opportunity; |
||
| 245 | } |
If you define a variable conditionally, it can happen that it is not defined for all execution paths.
Let’s take a look at an example:
In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.
Available Fixes
Check for existence of the variable explicitly:
Define a default value for the variable:
Add a value for the missing path: