mod/gcforums/start.php ➔ render_forum_topics()

Complexity

Conditions	11
Paths	10

Size

Total Lines	106
Code Lines	66

Duplication

Lines	7
Ratio	6.6 %

Importance

Changes

0

<?php
function render_forum_topics($topic_guid)
{
	elgg_load_css('gcforums-css');
	$entity = get_entity($topic_guid);

	if ($entity instanceof ElggEntity) {

		$dbprefix = elgg_get_config('dbprefix');
		$base_url = elgg_get_site_entity()->getURL();
		$group_guid = gcforums_get_forum_in_group($topic_guid, $topic_guid);

		// set the breadcrumb trail
		assemble_forum_breadcrumb($entity);

		if ($entity->getSubtype() === 'hjforumtopic') {

			$options = render_edit_options($entity->getGUID(), $entity->getGUID());
			if ($options == '') $options = '-';
			$topic = get_entity($topic_guid);
			$title = $topic->title;
			$description = $topic->description;

			/// owner information
			$owner = $topic->getOwnerEntity();
			$timestamp = date('Y-m-d H:i:s', $topic->time_created);
			$params = array(
				'entity' => $topic,
				'title' => false,
			);

			$summary = elgg_view('object/elements/summary', $params);
			$admin_only = (elgg_is_admin_logged_in()) ? "(guid:{$topic->guid})" : "";
			$owner_icon = elgg_view_entity_icon($topic->getOwnerEntity(), 'medium');

			$content .= "

The variable $content does not exist. Did you forget to declare it?

			<div class='topic-owner-information-content'>
				<div class='topic-information-options'>{$options} {$admin_only}</div>
				<div class='topic-owner-icon'>{$owner_icon}</div>
				<div class='topic-owner-information'><b>".elgg_echo('gcforums:user:name')."</b> {$owner->name} ({$owner->username})</div>
				<div class='topic-owner-information'><b>".elgg_echo('gcforums:user:email')."</b> {$owner->email}</div>
				<div class='topic-owner-information'><b>".elgg_echo('gcforums:user:posting')."</b> {$timestamp}</div>
			</div>";

			$content .= "<div class='topic-content'>{$topic->description}</div>";
			$content .= "<h3>Comments</h3>";

			// some comments were accidentally saved as private 0
			$old_access = elgg_set_ignore_access();
			$comments = elgg_get_entities(array(
				'types' => 'object',
				'container_guids' => $topic->guid,
				'limit' => 0,
			));
			
			/// comments
			$content .= "<div class='topic-main-comments'>";
			foreach ($comments as $comment) {
				// condition, do not change access id all the time
				if ($comment->access_id != $entity->access_id) {
					$comment->access_id = $entity->access_id;
					$comment->save();
				}

				$options = render_edit_options($comment->getGUID(), $comment->getGUID());
				if ($options == '') $options = '-';
				$admin_only = (elgg_is_admin_logged_in()) ? "(id:{$comment->guid} | acl:{$comment->access_id})" : "";
				$owner_icon = elgg_view_entity_icon($comment->getOwnerEntity(), 'small');
				$content .= "
				<div class='topic-comments'>
					<div class='topic-comment-options'>{$options} {$admin_only}</div>
					<div class='comment-owner-information-content'>
						<div class='comment-owner-icon'>{$owner_icon} {$comment->getOwnerEntity()->email}</div>
					</div>
					<div class='topic-comment-content'>{$comment->description}</div>
				</div> <br/>";
			}
			$content .= "</div>";
			
			elgg_set_ignore_access($old_access);

			$vars['group_guid'] = $group_guid;

$vars was never initialized. Although not strictly required by PHP, it is generally a good practice to add $vars = array(); before regardless.

			$vars['topic_guid'] = $topic->guid;
			$vars['current_entity'] = $topic->guid;
			$vars['topic_access'] = $topic->access_id;
			$vars['entity_type'] = 'hjforumpost';

			if (elgg_is_logged_in() && check_entity_relationship(elgg_get_logged_in_user_entity()->getGUID(), 'member', $group_guid)) {
				$topic_content .= elgg_view_form('gcforums/create', array(), $vars);

The variable $topic_content does not exist. Did you forget to declare it?

				$content .= $topic_content;
			}

			$return['filter'] = '';

$return was never initialized. Although not strictly required by PHP, it is generally a good practice to add $return = array(); before regardless.

			$return['title'] = $title;
			$return['content'] = $content;
			
		}

	} else {

		$return['filter'] = '';

$return was never initialized. Although not strictly required by PHP, it is generally a good practice to add $return = array(); before regardless.

		$return['title'] = '404 - '.elgg_echo('gcforums:notfound');
		$return['content'] = elgg_echo('gcforums:notfound');
		
	}
	return $return;

The variable $return does not seem to be defined for all execution paths leading up to this point.

}