AccessRequests::fetchAll() - Code Metrics - Inspection of "Adding mod_pleio to Elgg" - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add-pleio-mod ( 6d68a5 )

unknown

created 2018-03-13 15:32 UTC

AccessRequests::fetchAll() A

↳ Parent: AccessRequests

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	2
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	10
cp	0
crap	6

<?php
namespace ModPleio;

class AccessRequests {
    function count() {
        $count = get_data_row("SELECT COUNT(*) AS total FROM pleio_request_access");
        return (int) $count->total;
    }

    function get($id) {
        $id = (int) $id;
        $entity = get_data_row("SELECT * FROM pleio_request_access WHERE id = {$id}");
        if ($entity) {

            return new AccessRequest($entity);
        }

        return null;
    }

    function fetchAll($limit = 20, $offset = 0) {
        $limit = (int) $limit;
        $offset = (int) $offset;
        
        $return = [];
        $entities = get_data("SELECT * FROM pleio_request_access ORDER BY time_created DESC LIMIT {$offset}, {$limit}");
        foreach ($entities as $entity) {
            $return[] = new AccessRequest($entity);
        }

        return $return;
    }
}

1			<?php
2			namespace ModPleio;
3
4			class AccessRequests {
5			function count() {
6			$count = get_data_row("SELECT COUNT(*) AS total FROM pleio_request_access");
7			return (int) $count->total;
8			}
9
10			function get($id) {
11			$id = (int) $id;
12			$entity = get_data_row("SELECT * FROM pleio_request_access WHERE id = {$id}");
13			if ($entity) {
			0 ignored issues – show Bug Best Practice introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report The expression `$entity` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
14			return new AccessRequest($entity);
15			}
16
17			return null;
18			}
19
20			function fetchAll($limit = 20, $offset = 0) {
21			$limit = (int) $limit;
22			$offset = (int) $offset;
23
24			$return = [];
25			$entities = get_data("SELECT * FROM pleio_request_access ORDER BY time_created DESC LIMIT {$offset}, {$limit}");
26			foreach ($entities as $entity) {
27			$return[] = new AccessRequest($entity);
28			}
29
30			return $return;
31			}
32			}

gctools-outilsgc / gcconnex

Push — add-pleio-mod ( 6d68a5 )

AccessRequests::fetchAll() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like