AccessRequest::__construct() - Code Metrics - Inspection of "Adding mod_pleio to Elgg" - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add-pleio-mod ( 6d68a5 )

unknown

created 2018-03-13 15:32 UTC

AccessRequest::__construct() A

↳ Parent: AccessRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	5
cp	0
crap	2

<?php
namespace ModPleio;

class AccessRequest {
    public function __construct($data) {
        $this->id = (int) $data->id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->user = unserialize($data->user);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->time_created = $data->time_created;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function getURL() {
        return $this->user["url"];
    }

    public function getIconURL() {
        return $this->user["icon"];
    }

    public function getType() {
        return "accessRequest";
    }

    public function approve() {
        $resourceOwner = new ResourceOwner($this->user);
        $loginHandler = new LoginHandler($resourceOwner);
        $site = elgg_get_site_entity();

        try {
            $user = $loginHandler->createUser();
            if ($user) {
                $this->remove();
                $this->sendEmail(
                    elgg_echo("pleio:approved:subject", [$site->name]),
                    elgg_echo("pleio:approved:body", [
                        $user->name,
                        $site->name,
                        $site->url
                    ])
                );
                return true;
            }
        } catch (\RegistrationException $e) {
            register_error($e->getMessage());
        }

        return false;
    }

    public function decline() {
        $site = elgg_get_site_entity();
        $resourceOwner = new ResourceOwner($this->user);

        if ($this->remove()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $this->sendEmail(
                elgg_echo("pleio:declined:subject", [$site->name]),
                elgg_echo("pleio:declined:body", [
                    $resourceOwner->getName(),
                    $site->name
                ])
            );

            return true;
        }

        return false;
    }

    public function remove() {
        return delete_data("DELETE FROM pleio_request_access WHERE id = {$this->id}");
    }

    private function sendEmail($subject, $body, $params = null) {
        $site = elgg_get_site_entity();

        if ($site->email) {
            $from = $site->email;
        } else {
            $from = "noreply@" . get_site_domain($site->guid);
        }

        return elgg_send_email($from, $this->user["email"], $subject, $body, $params);
    }
}

1			<?php
2			namespace ModPleio;
3
4			class AccessRequest {
5			public function __construct($data) {
6			$this->id = (int) $data->id;
			0 ignored issues – show Bug introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
7			$this->user = unserialize($data->user);
			0 ignored issues – show Bug introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report The property `user` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
8			$this->time_created = $data->time_created;
			0 ignored issues – show Bug introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report The property `time_created` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
9			}
10
11			public function getURL() {
12			return $this->user["url"];
13			}
14
15			public function getIconURL() {
16			return $this->user["icon"];
17			}
18
19			public function getType() {
20			return "accessRequest";
21			}
22
23			public function approve() {
24			$resourceOwner = new ResourceOwner($this->user);
25			$loginHandler = new LoginHandler($resourceOwner);
26			$site = elgg_get_site_entity();
27
28			try {
29			$user = $loginHandler->createUser();
30			if ($user) {
31			$this->remove();
32			$this->sendEmail(
33			elgg_echo("pleio:approved:subject", [$site->name]),
34			elgg_echo("pleio:approved:body", [
35			$user->name,
36			$site->name,
37			$site->url
38			])
39			);
40			return true;
41			}
42			} catch (\RegistrationException $e) {
43			register_error($e->getMessage());
44			}
45
46			return false;
47			}
48
49			public function decline() {
50			$site = elgg_get_site_entity();
51			$resourceOwner = new ResourceOwner($this->user);
52
53			if ($this->remove()) {
			0 ignored issues – show Bug Best Practice introduced 2018-03-13 15:59 UTC by Report Bug Copy Issue Report The expression `$this->remove()` of type `integer\|false` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
54			$this->sendEmail(
55			elgg_echo("pleio:declined:subject", [$site->name]),
56			elgg_echo("pleio:declined:body", [
57			$resourceOwner->getName(),
58			$site->name
59			])
60			);
61
62			return true;
63			}
64
65			return false;
66			}
67
68			public function remove() {
69			return delete_data("DELETE FROM pleio_request_access WHERE id = {$this->id}");
70			}
71
72			private function sendEmail($subject, $body, $params = null) {
73			$site = elgg_get_site_entity();
74
75			if ($site->email) {
76			$from = $site->email;
77			} else {
78			$from = "noreply@" . get_site_domain($site->guid);
79			}
80
81			return elgg_send_email($from, $this->user["email"], $subject, $body, $params);
82			}
83			}

gctools-outilsgc / gcconnex

Push — add-pleio-mod ( 6d68a5 )

AccessRequest::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like