Issues in index.php - All Issues - Inspection of "Update functions.php" - gctools-outilsgc/gcconnex - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — distributed_digests ( 63d323...74ebac )

by Ilia

created 2018-09-13 14:15 UTC

index.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Elgg front controller entry point
 *
 * @package Elgg
 * @subpackage Core
 */

/*
 * Rewrite rules for PHP cli webserver used for testing. Do not use on production sites
 * as normal web server replacement.
 *
 * You need to explicitly point to index.php in order for router to work properly:
 *
 * <code>php -S localhost:8888 index.php</code>
 */
if (php_sapi_name() === 'cli-server') {
	$urlPath = parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH);

	if (preg_match('/^\/cache\/(.*)$/', $urlPath, $matches)) {
		$_GET['request'] = $matches[1];
		require('engine/handlers/cache_handler.php');
		exit;
	} else if (preg_match('/^\/export\/([A-Za-z]+)\/([0-9]+)\/?$/', $urlPath, $matches)) {
		$_GET['view'] = $matches[1];
		$_GET['guid'] = $matches[2];
		require('engine/handlers/export_handler.php');
		exit;
	} else if (preg_match('/^\/export\/([A-Za-z]+)\/([0-9]+)\/([A-Za-z]+)\/([A-Za-z0-9\_]+)\/$/', $urlPath, $matches)) {
		$_GET['view'] = $matches[1];
		$_GET['guid'] = $matches[2];
		$_GET['type'] = $matches[3];
		$_GET['idname'] = $matches[4];
		require('engine/handlers/export_handler.php');
		exit;
	} else if (preg_match("/^\/rewrite.php$/", $urlPath, $matches)) {
		require('install.php');
		exit;
	} else if ($urlPath !== '/' && file_exists(__DIR__ . $urlPath)) {
		// serve the requested resource as-is.
		return false;
	} else {
		$_GET['__elgg_uri'] = $urlPath;
	}
}

// allow testing from the upgrade page before the site is upgraded.
if (isset($_GET['__testing_rewrite'])) {
	if (isset($_GET['__elgg_uri']) && false !== strpos($_GET['__elgg_uri'], '__testing_rewrite')) {
		echo "success";
	}
	exit;
}

require_once(dirname(__FILE__) . "/engine/start.php");

$router = _elgg_services()->router;
$request = _elgg_services()->request;

// TODO use formal Response object instead
header("Content-Type: text/html;charset=utf-8");

if (!$router->route($request)) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
	forward('', '404');
}

1			<?php
2			/**
3			* Elgg front controller entry point
4			*
5			* @package Elgg
6			* @subpackage Core
7			*/
8
9			/*
10			* Rewrite rules for PHP cli webserver used for testing. Do not use on production sites
11			* as normal web server replacement.
12			*
13			* You need to explicitly point to index.php in order for router to work properly:
14			*
15			* <code>php -S localhost:8888 index.php</code>
16			*/
17			if (php_sapi_name() === 'cli-server') {
18			$urlPath = parse_url($_SERVER["REQUEST_URI"], PHP_URL_PATH);
19
20			if (preg_match('/^\/cache\/(.*)$/', $urlPath, $matches)) {
21			$_GET['request'] = $matches[1];
22			require('engine/handlers/cache_handler.php');
23			exit;
24			} else if (preg_match('/^\/export\/([A-Za-z]+)\/([0-9]+)\/?$/', $urlPath, $matches)) {
25			$_GET['view'] = $matches[1];
26			$_GET['guid'] = $matches[2];
27			require('engine/handlers/export_handler.php');
28			exit;
29			} else if (preg_match('/^\/export\/([A-Za-z]+)\/([0-9]+)\/([A-Za-z]+)\/([A-Za-z0-9\_]+)\/$/', $urlPath, $matches)) {
30			$_GET['view'] = $matches[1];
31			$_GET['guid'] = $matches[2];
32			$_GET['type'] = $matches[3];
33			$_GET['idname'] = $matches[4];
34			require('engine/handlers/export_handler.php');
35			exit;
36			} else if (preg_match("/^\/rewrite.php$/", $urlPath, $matches)) {
37			require('install.php');
38			exit;
39			} else if ($urlPath !== '/' && file_exists(__DIR__ . $urlPath)) {
40			// serve the requested resource as-is.
41			return false;
42			} else {
43			$_GET['__elgg_uri'] = $urlPath;
44			}
45			}
46
47			// allow testing from the upgrade page before the site is upgraded.
48			if (isset($_GET['__testing_rewrite'])) {
49			if (isset($_GET['__elgg_uri']) && false !== strpos($_GET['__elgg_uri'], '__testing_rewrite')) {
50			echo "success";
51			}
52			exit;
53			}
54
55			require_once(dirname(__FILE__) . "/engine/start.php");
56
57			$router = _elgg_services()->router;
58			$request = _elgg_services()->request;
59
60			// TODO use formal Response object instead
61			header("Content-Type: text/html;charset=utf-8");
62
63			if (!$router->route($request)) {
			0 ignored issues – show Bug Best Practice introduced 2017-09-27 16:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$router->route($request)` of type `null\|boolean` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
64			forward('', '404');
65			}

gctools-outilsgc / gcconnex

Push — distributed_digests ( 63d323...74ebac )

index.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like